acl_test.py Increase the timeout of check_rule_counters#21989
Closed
arista-nwolfe wants to merge 1 commit intosonic-net:masterfrom
Closed
acl_test.py Increase the timeout of check_rule_counters#21989arista-nwolfe wants to merge 1 commit intosonic-net:masterfrom
acl_test.py Increase the timeout of check_rule_counters#21989arista-nwolfe wants to merge 1 commit intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
sonic-net#21988 Signed-off-by: Nathan Wolfe <nwolfe@arista.com>
|
Azure Pipelines successfully started running 1 pipeline(s). |
github-actions
bot
requested review from
bingwang-ms,
stepanblyschak and
xwjiang-ms
arista-nwolfe
force-pushed
the
master-acl-rule-timeout-increase
branch
from
7becdaa to
1b421c0
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
We're seeing this timeout at Arista because we've internally patched #21760 which adds 2 new ACL rules (38 & 39) which pushes us over the 60s threshold. |
Contributor
Author
|
I talked with @markx-arista and he's going to include this timeout increase in his PR #21760 which adds the new ACL rules to keep the changes together so closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check_rule_counterswaits for 60s for all ACL rules to be installed from the first ACL rule creation to the last.We've seen that occasionally the amount of time from the first rule creation to the last rule creation is greater than 60s.
Hence increasing the timeout from 60s to 120s.
More details in #21988
Summary:
Fixes #21988
Type of change
Back port request