art1f1c3R/36400654 base console conn bug fix#21966
Merged
auspham merged 2 commits intosonic-net:masterfrom Jan 20, 2026
Merged
Conversation
Collaborator
|
/azp run |
github-actions
bot
requested review from
bingwang-ms,
matthew-soulsby and
xwjiang-ms
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Carl Flottmann <t-cflottmann@microsoft.com>
art1f1c3R
force-pushed
the
art1f1c3R/36400654-base-console-conn-bug-fix
branch
from
fd5d085 to
ce28a08
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Carl Flottmann <t-cflottmann@microsoft.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
art1f1c3R
changed the title
auspham
approved these changes
Jan 20, 2026
6 tasks
PriyanshTratiya
pushed a commit
to PriyanshTratiya/sonic-mgmt
that referenced
this pull request
Jan 21, 2026
* fix: added kwargs arg to console connection to align with netmiko Signed-off-by: Carl Flottmann <t-cflottmann@microsoft.com> * explicitly add delay factor with kwargs Signed-off-by: Carl Flottmann <t-cflottmann@microsoft.com> --------- Signed-off-by: Carl Flottmann <t-cflottmann@microsoft.com> Signed-off-by: Priyansh Tratiya <ptratiya@microsoft.com>
saravanan-nexthop
pushed a commit
to nexthop-ai/sonic-mgmt
that referenced
this pull request
Jan 22, 2026
* fix: added kwargs arg to console connection to align with netmiko Signed-off-by: Carl Flottmann <t-cflottmann@microsoft.com> * explicitly add delay factor with kwargs Signed-off-by: Carl Flottmann <t-cflottmann@microsoft.com> --------- Signed-off-by: Carl Flottmann <t-cflottmann@microsoft.com> Signed-off-by: Saravanan Sellappa <saravanan@nexthop.ai>
justin-oliver
pushed a commit
to justin-oliver/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
* fix: added kwargs arg to console connection to align with netmiko Signed-off-by: Carl Flottmann <t-cflottmann@microsoft.com> * explicitly add delay factor with kwargs Signed-off-by: Carl Flottmann <t-cflottmann@microsoft.com> --------- Signed-off-by: Carl Flottmann <t-cflottmann@microsoft.com>
Contributor
|
any plan to fix this on 2511? i made a similar PR there: #21987 |
auspham
added
the
Request for 202511 branch
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jan 30, 2026
* fix: added kwargs arg to console connection to align with netmiko Signed-off-by: Carl Flottmann <t-cflottmann@microsoft.com> * explicitly add delay factor with kwargs Signed-off-by: Carl Flottmann <t-cflottmann@microsoft.com> --------- Signed-off-by: Carl Flottmann <t-cflottmann@microsoft.com>
Collaborator
|
Cherry-pick PR to 202511: #22196 |
5 tasks
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Feb 2, 2026
* fix: added kwargs arg to console connection to align with netmiko Signed-off-by: Carl Flottmann <t-cflottmann@microsoft.com> * explicitly add delay factor with kwargs Signed-off-by: Carl Flottmann <t-cflottmann@microsoft.com> --------- Signed-off-by: Carl Flottmann <t-cflottmann@microsoft.com> Signed-off-by: Yael Tzur <ytzur@nvidia.com>
vmittal-msft
pushed a commit
that referenced
this pull request
Feb 4, 2026
mssonicbld
added
Included in 202511 branch
and removed
Created PR to 202511 branch
labels
abhishek-nexthop
pushed a commit
to nexthop-ai/sonic-mgmt
that referenced
this pull request
Feb 6, 2026
* fix: added kwargs arg to console connection to align with netmiko Signed-off-by: Carl Flottmann <t-cflottmann@microsoft.com> * explicitly add delay factor with kwargs Signed-off-by: Carl Flottmann <t-cflottmann@microsoft.com> --------- Signed-off-by: Carl Flottmann <t-cflottmann@microsoft.com>
Anirudh-nokia
pushed a commit
to Anirudh-nokia/sonic-mgmt-fork
that referenced
this pull request
Feb 6, 2026
* fix: added kwargs arg to console connection to align with netmiko Signed-off-by: Carl Flottmann <t-cflottmann@microsoft.com> * explicitly add delay factor with kwargs Signed-off-by: Carl Flottmann <t-cflottmann@microsoft.com> --------- Signed-off-by: Carl Flottmann <t-cflottmann@microsoft.com> Signed-off-by: ayya <anirudh.ayya@nokia.com>
lakshmi-nexthop
pushed a commit
to lakshmi-nexthop/sonic-mgmt
that referenced
this pull request
Feb 11, 2026
* fix: added kwargs arg to console connection to align with netmiko * explicitly add delay factor with kwargs --------- Signed-off-by: Carl Flottmann <t-cflottmann@microsoft.com> Co-authored-by: Carl Flottmann <carlflottmann@gmail.com> Signed-off-by: Lakshmi Yarramaneni <lakshmi@nexthop.ai>
nnelluri-cisco
pushed a commit
to nnelluri-cisco/sonic-mgmt
that referenced
this pull request
Feb 12, 2026
* fix: added kwargs arg to console connection to align with netmiko Signed-off-by: Carl Flottmann <t-cflottmann@microsoft.com> * explicitly add delay factor with kwargs Signed-off-by: Carl Flottmann <t-cflottmann@microsoft.com> --------- Signed-off-by: Carl Flottmann <t-cflottmann@microsoft.com> Signed-off-by: nnelluri-cisco <nnelluri@cisco.com>
rraghav-cisco
pushed a commit
to rraghav-cisco/sonic-mgmt
that referenced
this pull request
Feb 13, 2026
* fix: added kwargs arg to console connection to align with netmiko Signed-off-by: Carl Flottmann <t-cflottmann@microsoft.com> * explicitly add delay factor with kwargs Signed-off-by: Carl Flottmann <t-cflottmann@microsoft.com> --------- Signed-off-by: Carl Flottmann <t-cflottmann@microsoft.com> Signed-off-by: Raghavendran Ramanathan <rraghav@cisco.com>
anilal-amd
pushed a commit
to anilal-amd/anilal-forked-sonic-mgmt
that referenced
this pull request
Feb 19, 2026
* fix: added kwargs arg to console connection to align with netmiko Signed-off-by: Carl Flottmann <t-cflottmann@microsoft.com> * explicitly add delay factor with kwargs Signed-off-by: Carl Flottmann <t-cflottmann@microsoft.com> --------- Signed-off-by: Carl Flottmann <t-cflottmann@microsoft.com> Signed-off-by: Zhuohui Tan <zhuohui.tan@amd.com>
abhishek-nexthop
pushed a commit
to nexthop-ai/sonic-mgmt
that referenced
this pull request
Mar 17, 2026
* fix: added kwargs arg to console connection to align with netmiko Signed-off-by: Carl Flottmann <t-cflottmann@microsoft.com> * explicitly add delay factor with kwargs Signed-off-by: Carl Flottmann <t-cflottmann@microsoft.com> --------- Signed-off-by: Carl Flottmann <t-cflottmann@microsoft.com> Signed-off-by: Abhishek <abhishek@nexthop.ai>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Mar 27, 2026
* fix: added kwargs arg to console connection to align with netmiko Signed-off-by: Carl Flottmann <t-cflottmann@microsoft.com> * explicitly add delay factor with kwargs Signed-off-by: Carl Flottmann <t-cflottmann@microsoft.com> --------- Signed-off-by: Carl Flottmann <t-cflottmann@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
After investigating the error in Test plan 6968ad1915026fd4f746b408, it raises an error due to the
BaseConsoleConn.find_promptdefinition not having apatternkeyword argument. Since this function callssuper, this has been changed to use**kwargsso all keyword arguments are accounted for.Summary:
Attending to issues noticed in ADO 36400654.
Type of change
Approach
What is the motivation for this PR?
Test plan 6968ad1915026fd4f746b408 was failing due to a python exception, causing the testbed recovery to fail.
How did you do it?
Traced the exception to the
BaseConsoleConntype and how it usesnetmiko.cisco_base_connection.CiscoBaseConnection.How did you verify/test it?