Skip to content

feat: allow previous connection for deploy-l1#21909

Merged
yejianquan merged 1 commit intosonic-net:masterfrom
auspham:austinpham/36386319-deploy-l1-keep-old-connection
Jan 16, 2026
Merged

feat: allow previous connection for deploy-l1#21909
yejianquan merged 1 commit intosonic-net:masterfrom
auspham:austinpham/36386319-deploy-l1-keep-old-connection

Conversation

@auspham
Copy link
Copy Markdown
Contributor

@auspham auspham commented Jan 12, 2026

Description of PR

Summary:
Fixes # (issue) Currently, deploy-l1 is using overwrite mode. Which replace all the previous connection and add a new one on top.

However, this will also not allow us to re-use l1.

New changes add a parameter allow_previous_connection which helps to allow existing connections.

It only remove if the connection is overlap with the second connection

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505
  • 202511

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@github-actions github-actions bot requested review from r12f and sdszhang January 12, 2026 22:35
@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@auspham auspham force-pushed the austinpham/36386319-deploy-l1-keep-old-connection branch from c434026 to f6ad4a0 Compare January 12, 2026 23:08
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@github-actions github-actions bot requested a review from sdszhang January 12, 2026 23:08
@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@auspham auspham force-pushed the austinpham/36386319-deploy-l1-keep-old-connection branch from f6ad4a0 to 4f4d033 Compare January 12, 2026 23:26
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Copy Markdown
Contributor

@sdszhang sdszhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any update from Riff yet. Let's go with current method first without changing the behavior for NUT testbed.

Copy link
Copy Markdown
Collaborator

@yejianquan yejianquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yejianquan yejianquan merged commit f9c4c35 into sonic-net:master Jan 16, 2026
21 checks passed
PriyanshTratiya pushed a commit to PriyanshTratiya/sonic-mgmt that referenced this pull request Jan 21, 2026
Description of PR
Summary:
Fixes # (issue) Currently, deploy-l1 is using overwrite mode. Which replace all the previous connection and add a new one on top.

However, this will also not allow us to re-use l1.

New changes add a parameter allow_previous_connection which helps to allow existing connections.

It only remove if the connection is overlap with the second connection

Signed-off-by: Austin Pham <[email protected]>
Signed-off-by: Priyansh Tratiya <[email protected]>
AndoniSanguesa pushed a commit to AndoniSanguesa/sonic-mgmt that referenced this pull request Jan 21, 2026
Description of PR
Summary:
Fixes # (issue) Currently, deploy-l1 is using overwrite mode. Which replace all the previous connection and add a new one on top.

However, this will also not allow us to re-use l1.

New changes add a parameter allow_previous_connection which helps to allow existing connections.

It only remove if the connection is overlap with the second connection

Signed-off-by: Austin Pham <[email protected]>
Signed-off-by: Andoni Sanguesa <[email protected]>
AndoniSanguesa pushed a commit to AndoniSanguesa/sonic-mgmt that referenced this pull request Jan 21, 2026
Description of PR
Summary:
Fixes # (issue) Currently, deploy-l1 is using overwrite mode. Which replace all the previous connection and add a new one on top.

However, this will also not allow us to re-use l1.

New changes add a parameter allow_previous_connection which helps to allow existing connections.

It only remove if the connection is overlap with the second connection

Signed-off-by: Austin Pham <[email protected]>
Signed-off-by: Andoni Sanguesa <[email protected]>
saravanan-nexthop pushed a commit to nexthop-ai/sonic-mgmt that referenced this pull request Jan 22, 2026
Description of PR
Summary:
Fixes # (issue) Currently, deploy-l1 is using overwrite mode. Which replace all the previous connection and add a new one on top.

However, this will also not allow us to re-use l1.

New changes add a parameter allow_previous_connection which helps to allow existing connections.

It only remove if the connection is overlap with the second connection

Signed-off-by: Austin Pham <[email protected]>
Signed-off-by: Saravanan Sellappa <[email protected]>
justin-oliver pushed a commit to justin-oliver/sonic-mgmt that referenced this pull request Jan 26, 2026
Description of PR
Summary:
Fixes # (issue) Currently, deploy-l1 is using overwrite mode. Which replace all the previous connection and add a new one on top.

However, this will also not allow us to re-use l1.

New changes add a parameter allow_previous_connection which helps to allow existing connections.

It only remove if the connection is overlap with the second connection

Signed-off-by: Austin Pham <[email protected]>
ytzur1 pushed a commit to ytzur1/sonic-mgmt that referenced this pull request Feb 2, 2026
Description of PR
Summary:
Fixes # (issue) Currently, deploy-l1 is using overwrite mode. Which replace all the previous connection and add a new one on top.

However, this will also not allow us to re-use l1.

New changes add a parameter allow_previous_connection which helps to allow existing connections.

It only remove if the connection is overlap with the second connection

Signed-off-by: Austin Pham <[email protected]>
Signed-off-by: Yael Tzur <[email protected]>
abhishek-nexthop pushed a commit to nexthop-ai/sonic-mgmt that referenced this pull request Feb 6, 2026
Description of PR
Summary:
Fixes # (issue) Currently, deploy-l1 is using overwrite mode. Which replace all the previous connection and add a new one on top.

However, this will also not allow us to re-use l1.

New changes add a parameter allow_previous_connection which helps to allow existing connections.

It only remove if the connection is overlap with the second connection

Signed-off-by: Austin Pham <[email protected]>
nnelluri-cisco pushed a commit to nnelluri-cisco/sonic-mgmt that referenced this pull request Feb 12, 2026
Description of PR
Summary:
Fixes # (issue) Currently, deploy-l1 is using overwrite mode. Which replace all the previous connection and add a new one on top.

However, this will also not allow us to re-use l1.

New changes add a parameter allow_previous_connection which helps to allow existing connections.

It only remove if the connection is overlap with the second connection

Signed-off-by: Austin Pham <[email protected]>
Signed-off-by: nnelluri-cisco <[email protected]>
rraghav-cisco pushed a commit to rraghav-cisco/sonic-mgmt that referenced this pull request Feb 13, 2026
Description of PR
Summary:
Fixes # (issue) Currently, deploy-l1 is using overwrite mode. Which replace all the previous connection and add a new one on top.

However, this will also not allow us to re-use l1.

New changes add a parameter allow_previous_connection which helps to allow existing connections.

It only remove if the connection is overlap with the second connection

Signed-off-by: Austin Pham <[email protected]>
Signed-off-by: Raghavendran Ramanathan <[email protected]>
anilal-amd pushed a commit to anilal-amd/anilal-forked-sonic-mgmt that referenced this pull request Feb 19, 2026
Description of PR
Summary:
Fixes # (issue) Currently, deploy-l1 is using overwrite mode. Which replace all the previous connection and add a new one on top.

However, this will also not allow us to re-use l1.

New changes add a parameter allow_previous_connection which helps to allow existing connections.

It only remove if the connection is overlap with the second connection

Signed-off-by: Austin Pham <[email protected]>
Signed-off-by: Zhuohui Tan <[email protected]>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
… automatically (sonic-net#21909)

#### Why I did it
src/sonic-platform-common
```
* f679a67 - (HEAD -> 202411, origin/202411) Restore optoe page to default 0 for active cables (sonic-net#550) (7 hours ago) [mssonicbld]
```
#### How I did it
#### How to verify it
#### Description for the changelog
abhishek-nexthop pushed a commit to nexthop-ai/sonic-mgmt that referenced this pull request Mar 17, 2026
Description of PR
Summary:
Fixes # (issue) Currently, deploy-l1 is using overwrite mode. Which replace all the previous connection and add a new one on top.

However, this will also not allow us to re-use l1.

New changes add a parameter allow_previous_connection which helps to allow existing connections.

It only remove if the connection is overlap with the second connection

Signed-off-by: Austin Pham <[email protected]>
Signed-off-by: Abhishek <[email protected]>
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Mar 27, 2026
Description of PR
Summary:
Fixes # (issue) Currently, deploy-l1 is using overwrite mode. Which replace all the previous connection and add a new one on top.

However, this will also not allow us to re-use l1.

New changes add a parameter allow_previous_connection which helps to allow existing connections.

It only remove if the connection is overlap with the second connection

Signed-off-by: Austin Pham <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants