Fix issues of test_platform_info#2187
Merged
wangxin merged 3 commits intosonic-net:masterfrom Sep 22, 2020
wangxin:fix-platform-info-pr
Merged
Fix issues of test_platform_info#2187wangxin merged 3 commits intosonic-net:masterfrom wangxin:fix-platform-info-pr
wangxin merged 3 commits intosonic-net:masterfrom
wangxin:fix-platform-info-pr
Conversation
Changes: 1. Update `ans_host` to `duthost`. 2. Import mellanox_thermal_control_test_helper to register mockers for Mellanox platform 3. Update the methods checking platform fan and temperature to support both master and 201911 Signed-off-by: Xin Wang <xiwang5@microsoft.com>
Collaborator
Author
|
@Junchao-Mellanox Could you please help review? |
Contributor
|
LGTM. Just one thought, the logic of RandomFanStatusMocker.check_result and RandomThermalStatusMocker.check_result looks similar, should we consider combining them into one? |
Junchao-Mellanox
approved these changes
Sep 4, 2020
Collaborator
Author
|
Thanks! Updated the PR. Used mixin to combine common code. |
Collaborator
Author
|
retest this please |
Collaborator
|
retest vsimage please |
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
dd0fb84 (HEAD -> 202111, origin/202111) [mirrororch]: Implement HW resources availability validation for SPAN/ERSPAN (sonic-net#2187)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Fix multiple issues of
tests/platform_tests/test_platform_info.py.Changes:
ans_hosttoduthost.Type of change
Approach
What is the motivation for this PR?
There are couple of issues in test_platform_info.py and its dependent scripts.
test_platform_info.py, line 94 is still using deprecatedans_host. The issue was not exposed because it is in a branch that is rarely hit.How did you do it?
ans_hosttoduthost.How did you verify/test it?
Test run the
test_platform_info.pyscript on SONiC.20191130.44. Only one casetest_thermal_control_fan_statusfailed because expected log is not found. This is another problem. All the other cases related with the changes are passed.Any platform specific information?
Mellanox platform specific change.
Supported testbed topology if it's a new test case?
Documentation