configure bring up server trunk port in playbook#218
Merged
lguohan merged 1 commit intosonic-net:masterfrom Jul 25, 2017
Merged
configure bring up server trunk port in playbook#218lguohan merged 1 commit intosonic-net:masterfrom
lguohan merged 1 commit intosonic-net:masterfrom
Conversation
pavel-shirshov
approved these changes
Jul 25, 2017
lguohan
added a commit
that referenced
this pull request
Aug 3, 2017
auspham
pushed a commit
to auspham/sonic-mgmt
that referenced
this pull request
May 30, 2025
…estarting of orchagent (sonic-net#16765) (sonic-net#218) Description of PR test_lldp_neighbor_post_orchagent_reboot uses prefix restart_orchagent() to warm restart orchagent. This warm restart of orchagent(kill orchagent and restart orchagent process) is not supported on chassis with type VOQ. Add code to handle chassis type VOQ case by restarting the swss@0(1) service. This will cause ports to be removed from lldp table and add back in so we can test the issue found in sonic-net#6560. Summary: Fixes # (issue) Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202012 202205 202305 202311 202405 202411 Approach What is the motivation for this PR? Currently test_lldp_neighbor_post_orchagent_reboot is failing against chassis with type VOQ. It's found warm restart of orchagent is not supported on VOQ type chassis. How did you do it? For VOQ type chassis, uses "systemctl restart swss@0(1)" instead. How did you verify/test it? After the fix the test passed consistently against VOQ type chassis. <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: Fixes # (issue) ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] Test case(new/improvement) ### Back port request - [ ] 202012 - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 ### Approach #### What is the motivation for this PR? #### How did you do it? #### How did you verify/test it? #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.