Fix test_default_route_with_bgp_flap for t0-isolated-d32u32s2 and related topos#21708
Merged
StormLiangMS merged 1 commit intosonic-net:masterfrom Feb 26, 2026
Merged
Conversation
Collaborator
|
/azp run |
github-actions
bot
requested review from
prabhataravind,
wenyiz2021 and
xwjiang-ms
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Dayou Liu <113053330+dayouliu1@users.noreply.github.com>
dayouliu1
force-pushed
the
fix-test-default-route-t0-iso
branch
from
8a28293 to
096598e
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run Azure.sonic-mgmt |
Collaborator
|
/AzurePipelines run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
Current Github check timed out, failure does not seem related to the change |
Contributor
Author
|
/azpw run Azure.sonic-mgmt |
Collaborator
|
/AzurePipelines run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
StormLiangMS
added
the
Request for 202511 branch
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Feb 26, 2026
…net#21708) What is the motivation for this PR? Fix test_default_route_with_bgp_flap for t0-isolated-d32u32s2 and related topologies with PT0 TOR neighbours. We do not count the PT0 TOR peers as upstream neighbours in this scenario as they do not announce default routes. Signed-off-by: Dayou Liu <113053330+dayouliu1@users.noreply.github.com> Signed-off-by: mssonicbld <sonicbld@microsoft.com>
Collaborator
|
Cherry-pick PR to 202511: #22640 |
12 tasks
vmittal-msft
pushed a commit
that referenced
this pull request
Feb 27, 2026
#22640) What is the motivation for this PR? Fix test_default_route_with_bgp_flap for t0-isolated-d32u32s2 and related topologies with PT0 TOR neighbours. We do not count the PT0 TOR peers as upstream neighbours in this scenario as they do not announce default routes. Signed-off-by: Dayou Liu <113053330+dayouliu1@users.noreply.github.com> Signed-off-by: mssonicbld <sonicbld@microsoft.com> Co-authored-by: Dayou Liu <113053330+dayouliu1@users.noreply.github.com>
mssonicbld
added
Included in 202511 branch
and removed
Created PR to 202511 branch
labels
Contributor
|
Hi @dayouliu1, PT neighbors are expected to advertise default route. seems it was broken recently. #22565 has opened to correct the behavior. |
aronovic
pushed a commit
to aronovic/sonic-mgmt
that referenced
this pull request
Mar 3, 2026
…net#21708) What is the motivation for this PR? Fix test_default_route_with_bgp_flap for t0-isolated-d32u32s2 and related topologies with PT0 TOR neighbours. We do not count the PT0 TOR peers as upstream neighbours in this scenario as they do not announce default routes. Signed-off-by: Dayou Liu <113053330+dayouliu1@users.noreply.github.com> Signed-off-by: Mihut Aronovici <aronovic@cisco.com>
rraghav-cisco
pushed a commit
to rraghav-cisco/sonic-mgmt
that referenced
this pull request
Mar 3, 2026
…net#21708) What is the motivation for this PR? Fix test_default_route_with_bgp_flap for t0-isolated-d32u32s2 and related topologies with PT0 TOR neighbours. We do not count the PT0 TOR peers as upstream neighbours in this scenario as they do not announce default routes. Signed-off-by: Dayou Liu <113053330+dayouliu1@users.noreply.github.com> Signed-off-by: Raghavendran Ramanathan <rraghav@cisco.com>
selldinesh
pushed a commit
to selldinesh/sonic-mgmt
that referenced
this pull request
Mar 16, 2026
…net#21708) What is the motivation for this PR? Fix test_default_route_with_bgp_flap for t0-isolated-d32u32s2 and related topologies with PT0 TOR neighbours. We do not count the PT0 TOR peers as upstream neighbours in this scenario as they do not announce default routes. Signed-off-by: Dayou Liu <113053330+dayouliu1@users.noreply.github.com> Signed-off-by: selldinesh <dinesh.sellappan@keysight.com>
abhishek-nexthop
pushed a commit
to nexthop-ai/sonic-mgmt
that referenced
this pull request
Mar 17, 2026
…net#21708) What is the motivation for this PR? Fix test_default_route_with_bgp_flap for t0-isolated-d32u32s2 and related topologies with PT0 TOR neighbours. We do not count the PT0 TOR peers as upstream neighbours in this scenario as they do not announce default routes. Signed-off-by: Dayou Liu <113053330+dayouliu1@users.noreply.github.com> Signed-off-by: Abhishek <abhishek@nexthop.ai>
vrajeshe
pushed a commit
to vrajeshe/sonic-mgmt
that referenced
this pull request
Mar 23, 2026
…net#21708) What is the motivation for this PR? Fix test_default_route_with_bgp_flap for t0-isolated-d32u32s2 and related topologies with PT0 TOR neighbours. We do not count the PT0 TOR peers as upstream neighbours in this scenario as they do not announce default routes. Signed-off-by: Dayou Liu <113053330+dayouliu1@users.noreply.github.com> Signed-off-by: Venkata Gouri Rajesh Etla <vrajeshe@cisco.com>
ravaliyel
pushed a commit
to ravaliyel/sonic-mgmt
that referenced
this pull request
Mar 27, 2026
…net#21708) What is the motivation for this PR? Fix test_default_route_with_bgp_flap for t0-isolated-d32u32s2 and related topologies with PT0 TOR neighbours. We do not count the PT0 TOR peers as upstream neighbours in this scenario as they do not announce default routes. Signed-off-by: Dayou Liu <113053330+dayouliu1@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix
test_default_route_with_bgp_flapfort0-isolated-d32u32s2and related topologies with PT0 TOR neighbours. We do not count the PT0 TOR peers as upstream neighbours in this scenario as they do not announce default routes.How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation