[iface_namingmode] Get port_speed from DUT host variables#2164
Merged
lolyu merged 1 commit intosonic-net:masterfrom Sep 3, 2020
Merged
[iface_namingmode] Get port_speed from DUT host variables#2164lolyu merged 1 commit intosonic-net:masterfrom
lolyu merged 1 commit intosonic-net:masterfrom
Conversation
lolyu
force-pushed
the
port_speed_fix
branch
from
68cc475 to
b8b09b8
Compare
|
This pull request introduces 1 alert when merging b8b09b807e7b1fd916dc100a0d4802ed28eff3fb into 710fc2a - view on LGTM.com new alerts:
|
lolyu
force-pushed
the
port_speed_fix
branch
from
b8b09b8 to
0c1c95a
Compare
Collaborator
Author
|
Retest this please |
`port_alias` module retrieves `port_speed` from `port_config.ini`. But for 7060 devices, `port_config.ini` has no port speed info. So get port speed from host variable `iface_speed` defined in inventory. Signed-off-by: Longxiang Lyu <[email protected]>
lolyu
force-pushed
the
port_speed_fix
branch
from
0c1c95a to
bcf453a
Compare
neethajohn
approved these changes
Sep 1, 2020
Collaborator
Author
|
Retest this please |
2 similar comments
Collaborator
Author
|
Retest this please |
Collaborator
Author
|
Retest this please |
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
6a6b711 (HEAD -> 202111, origin/202111) Fix issue: sometimes PFC WD unable to create zero buffer pool (sonic-net#2164) 459aee0 Use abort instead of exit in case calling SAI API failure (sonic-net#2170) e767137 Fix issue config qos reload causing orchagent aborted via tracking dependencies among QoS tables (sonic-net#2116)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
port_aliasmodule retrievesport_speedfromport_config.ini. Butfor 7060 devices,
port_config.inihas no port speed info.So get port speed from the host variable
iface_speeddefined in inventory.Signed-off-by: Longxiang Lyu [email protected]
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
test
iface_namingmodeAny platform specific information?
Arista-7060CX-32S-C32Supported testbed topology if it's a new test case?
Documentation