Fix test_bgp_router_id.py for v6 topo#21455
Merged
StormLiangMS merged 2 commits intosonic-net:masterfrom Jan 16, 2026
Merged
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
markx-arista
force-pushed
the
fix-test-bgp-router-id-v6-topo
branch
from
a2ac2cc to
97d6573
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
markx-arista
changed the title
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
markx-arista
force-pushed
the
fix-test-bgp-router-id-v6-topo
branch
from
97d6573 to
2b98b8f
Compare
Collaborator
|
/azp run |
github-actions
bot
requested review from
BYGX-wcr,
cyw233,
lolyu,
sanjair-git,
xwjiang-ms and
yutongzhang-microsoft
|
Azure Pipelines successfully started running 1 pipeline(s). |
Skip v4 neighbor checks for v6 topo. Add new lookback_ipv6 fixture because IPv6 loopback IP is not directly used for route advertisement. Also add test_bgp_router_id_set_ipv6 for v6 topo only. Delete xfail and add skip for test_bgp_router_id_set/test_bgp_router_id_set_ipv6 based on v6/non-v6 topo. Signed-off-by: markxiao <[email protected]>
markx-arista
force-pushed
the
fix-test-bgp-router-id-v6-topo
branch
from
2b98b8f to
fb4460f
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
davidm-arista
added
Request for msft-202412 Branch
Request for 202511 branch
Collaborator
|
@markx-arista PR conflicts with 202511 branch |
7 tasks
Collaborator
|
Cherry-pick PR to msft-202412: Azure/sonic-mgmt.msft#962 |
mssonicbld
added
Included in msft-202412 Branch
and removed
Created PR to msft-202412 Branch
labels
PriyanshTratiya
pushed a commit
to PriyanshTratiya/sonic-mgmt
that referenced
this pull request
Jan 21, 2026
Skip v4 neighbor checks for v6 topo. Add new lookback_ipv6 fixture because IPv6 loopback IP is not directly used for route advertisement. Also add test_bgp_router_id_set_ipv6 for v6 topo only. Delete xfail and add skip for test_bgp_router_id_set/test_bgp_router_id_set_ipv6 based on v6/non-v6 topo. Signed-off-by: markxiao <[email protected]> Signed-off-by: Priyansh Tratiya <[email protected]>
AndoniSanguesa
pushed a commit
to AndoniSanguesa/sonic-mgmt
that referenced
this pull request
Jan 21, 2026
Skip v4 neighbor checks for v6 topo. Add new lookback_ipv6 fixture because IPv6 loopback IP is not directly used for route advertisement. Also add test_bgp_router_id_set_ipv6 for v6 topo only. Delete xfail and add skip for test_bgp_router_id_set/test_bgp_router_id_set_ipv6 based on v6/non-v6 topo. Signed-off-by: markxiao <[email protected]> Signed-off-by: Andoni Sanguesa <[email protected]>
AndoniSanguesa
pushed a commit
to AndoniSanguesa/sonic-mgmt
that referenced
this pull request
Jan 21, 2026
Skip v4 neighbor checks for v6 topo. Add new lookback_ipv6 fixture because IPv6 loopback IP is not directly used for route advertisement. Also add test_bgp_router_id_set_ipv6 for v6 topo only. Delete xfail and add skip for test_bgp_router_id_set/test_bgp_router_id_set_ipv6 based on v6/non-v6 topo. Signed-off-by: markxiao <[email protected]> Signed-off-by: Andoni Sanguesa <[email protected]>
saravanan-nexthop
pushed a commit
to nexthop-ai/sonic-mgmt
that referenced
this pull request
Jan 22, 2026
Skip v4 neighbor checks for v6 topo. Add new lookback_ipv6 fixture because IPv6 loopback IP is not directly used for route advertisement. Also add test_bgp_router_id_set_ipv6 for v6 topo only. Delete xfail and add skip for test_bgp_router_id_set/test_bgp_router_id_set_ipv6 based on v6/non-v6 topo. Signed-off-by: markxiao <[email protected]> Signed-off-by: Saravanan Sellappa <[email protected]>
7 tasks
Contributor
Author
|
Cherry-pick PR to 202511: #22097 |
justin-oliver
pushed a commit
to justin-oliver/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
Skip v4 neighbor checks for v6 topo. Add new lookback_ipv6 fixture because IPv6 loopback IP is not directly used for route advertisement. Also add test_bgp_router_id_set_ipv6 for v6 topo only. Delete xfail and add skip for test_bgp_router_id_set/test_bgp_router_id_set_ipv6 based on v6/non-v6 topo. Signed-off-by: markxiao <[email protected]>
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Feb 2, 2026
Skip v4 neighbor checks for v6 topo. Add new lookback_ipv6 fixture because IPv6 loopback IP is not directly used for route advertisement. Also add test_bgp_router_id_set_ipv6 for v6 topo only. Delete xfail and add skip for test_bgp_router_id_set/test_bgp_router_id_set_ipv6 based on v6/non-v6 topo. Signed-off-by: markxiao <[email protected]> Signed-off-by: Yael Tzur <[email protected]>
abhishek-nexthop
pushed a commit
to nexthop-ai/sonic-mgmt
that referenced
this pull request
Feb 6, 2026
Skip v4 neighbor checks for v6 topo. Add new lookback_ipv6 fixture because IPv6 loopback IP is not directly used for route advertisement. Also add test_bgp_router_id_set_ipv6 for v6 topo only. Delete xfail and add skip for test_bgp_router_id_set/test_bgp_router_id_set_ipv6 based on v6/non-v6 topo. Signed-off-by: markxiao <[email protected]>
nnelluri-cisco
pushed a commit
to nnelluri-cisco/sonic-mgmt
that referenced
this pull request
Feb 12, 2026
Skip v4 neighbor checks for v6 topo. Add new lookback_ipv6 fixture because IPv6 loopback IP is not directly used for route advertisement. Also add test_bgp_router_id_set_ipv6 for v6 topo only. Delete xfail and add skip for test_bgp_router_id_set/test_bgp_router_id_set_ipv6 based on v6/non-v6 topo. Signed-off-by: markxiao <[email protected]> Signed-off-by: nnelluri-cisco <[email protected]>
rraghav-cisco
pushed a commit
to rraghav-cisco/sonic-mgmt
that referenced
this pull request
Feb 13, 2026
Skip v4 neighbor checks for v6 topo. Add new lookback_ipv6 fixture because IPv6 loopback IP is not directly used for route advertisement. Also add test_bgp_router_id_set_ipv6 for v6 topo only. Delete xfail and add skip for test_bgp_router_id_set/test_bgp_router_id_set_ipv6 based on v6/non-v6 topo. Signed-off-by: markxiao <[email protected]> Signed-off-by: Raghavendran Ramanathan <[email protected]>
anilal-amd
pushed a commit
to anilal-amd/anilal-forked-sonic-mgmt
that referenced
this pull request
Feb 19, 2026
Skip v4 neighbor checks for v6 topo. Add new lookback_ipv6 fixture because IPv6 loopback IP is not directly used for route advertisement. Also add test_bgp_router_id_set_ipv6 for v6 topo only. Delete xfail and add skip for test_bgp_router_id_set/test_bgp_router_id_set_ipv6 based on v6/non-v6 topo. Signed-off-by: markxiao <[email protected]> Signed-off-by: Zhuohui Tan <[email protected]>
abhishek-nexthop
pushed a commit
to nexthop-ai/sonic-mgmt
that referenced
this pull request
Mar 17, 2026
Skip v4 neighbor checks for v6 topo. Add new lookback_ipv6 fixture because IPv6 loopback IP is not directly used for route advertisement. Also add test_bgp_router_id_set_ipv6 for v6 topo only. Delete xfail and add skip for test_bgp_router_id_set/test_bgp_router_id_set_ipv6 based on v6/non-v6 topo. Signed-off-by: markxiao <[email protected]> Signed-off-by: Abhishek <[email protected]>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Mar 27, 2026
Skip v4 neighbor checks for v6 topo. Add new lookback_ipv6 fixture because IPv6 loopback IP is not directly used for route advertisement. Also add test_bgp_router_id_set_ipv6 for v6 topo only. Delete xfail and add skip for test_bgp_router_id_set/test_bgp_router_id_set_ipv6 based on v6/non-v6 topo. Signed-off-by: markxiao <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Skip v4 neighbor checks for v6 topo.
Add new lookback_ipv6 fixture because IPv6 loopback IP is not directly used for route advertisement. Also add test_bgp_router_id_set_ipv6 for v6 topo only.
Delete xfail and add skip for test_bgp_router_id_set/test_bgp_router_id_set_ipv6 based on v6/non-v6 topo.
Summary:
Fixes #21454
Type of change
Back port request
Approach
What is the motivation for this PR?
test_bgp_router_id.py failed on v6 topo
How did you do it?
Skip v4 neighbor checks for v6 topo
Get correct IPv6 announced routes
Delete xfail and add proper skip
How did you verify/test it?
The test passed after the fix
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation