Skip to content

Fix memory comparison in test_bgp_session_flap.py for v6 topo#21451

Merged
StormLiangMS merged 1 commit intosonic-net:masterfrom
markx-arista:fix-test-bgp-session-flap-v6-topo
Jan 16, 2026
Merged

Fix memory comparison in test_bgp_session_flap.py for v6 topo#21451
StormLiangMS merged 1 commit intosonic-net:masterfrom
markx-arista:fix-test-bgp-session-flap-v6-topo

Conversation

@markx-arista
Copy link
Copy Markdown
Contributor

Description of PR

Fix test_bgp_session_flap when memory stat is always 0, e.g., v4 neighbors memory usage in v6 topo.

Summary:
Fixes #21450

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202412
  • 202505

Approach

What is the motivation for this PR?

Fix test_bgp_session_flap.py for v6 topo

How did you do it?

Change memory comparison sign from less than to less than or equal to.

How did you verify/test it?

The test passed after the change

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@markx-arista markx-arista force-pushed the fix-test-bgp-session-flap-v6-topo branch from b7f9c40 to 23e98d7 Compare November 28, 2025 03:21
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@markx-arista markx-arista force-pushed the fix-test-bgp-session-flap-v6-topo branch from 23e98d7 to 9a97898 Compare November 28, 2025 03:24
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Copy Markdown
Collaborator

@r12f r12f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be better to add a comment, but overall looking good. very straight forward fix.

Fix test_bgp_session_flap when memory stat is always 0, e.g., v4 neighbors memory usage in v6 topo.

Signed-off-by: markxiao <markxiao@arista.com>
@markx-arista markx-arista force-pushed the fix-test-bgp-session-flap-v6-topo branch from 9a97898 to 5377179 Compare December 8, 2025 19:41
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@markx-arista
Copy link
Copy Markdown
Contributor Author

will be better to add a comment, but overall looking good. very straight forward fix.

Done

@markx-arista markx-arista reopened this Dec 8, 2025
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@davidm-arista davidm-arista added Request for msft-202412 Branch Request for 202511 branch Request to backport a change to 202511 branch labels Dec 17, 2025
Copy link
Copy Markdown
Collaborator

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StormLiangMS StormLiangMS merged commit 36b298c into sonic-net:master Jan 16, 2026
28 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Jan 20, 2026
sonic-net#21451)

Fix test_bgp_session_flap when memory stat is always 0, e.g., v4 neighbors memory usage in v6 topo.

Signed-off-by: markxiao <markxiao@arista.com>
@mssonicbld
Copy link
Copy Markdown
Collaborator

Cherry-pick PR to 202511: #22028

@mssonicbld
Copy link
Copy Markdown
Collaborator

Cherry-pick PR to msft-202412: Azure/sonic-mgmt.msft#964

PriyanshTratiya pushed a commit to PriyanshTratiya/sonic-mgmt that referenced this pull request Jan 21, 2026
sonic-net#21451)

Fix test_bgp_session_flap when memory stat is always 0, e.g., v4 neighbors memory usage in v6 topo.

Signed-off-by: markxiao <markxiao@arista.com>
Signed-off-by: Priyansh Tratiya <ptratiya@microsoft.com>
AndoniSanguesa pushed a commit to AndoniSanguesa/sonic-mgmt that referenced this pull request Jan 21, 2026
sonic-net#21451)

Fix test_bgp_session_flap when memory stat is always 0, e.g., v4 neighbors memory usage in v6 topo.

Signed-off-by: markxiao <markxiao@arista.com>
Signed-off-by: Andoni Sanguesa <andoniesanguesa@gmail.com>
AndoniSanguesa pushed a commit to AndoniSanguesa/sonic-mgmt that referenced this pull request Jan 21, 2026
sonic-net#21451)

Fix test_bgp_session_flap when memory stat is always 0, e.g., v4 neighbors memory usage in v6 topo.

Signed-off-by: markxiao <markxiao@arista.com>
Signed-off-by: Andoni Sanguesa <andoniesanguesa@gmail.com>
saravanan-nexthop pushed a commit to nexthop-ai/sonic-mgmt that referenced this pull request Jan 22, 2026
sonic-net#21451)

Fix test_bgp_session_flap when memory stat is always 0, e.g., v4 neighbors memory usage in v6 topo.

Signed-off-by: markxiao <markxiao@arista.com>
Signed-off-by: Saravanan Sellappa <saravanan@nexthop.ai>
justin-oliver pushed a commit to justin-oliver/sonic-mgmt that referenced this pull request Jan 26, 2026
sonic-net#21451)

Fix test_bgp_session_flap when memory stat is always 0, e.g., v4 neighbors memory usage in v6 topo.

Signed-off-by: markxiao <markxiao@arista.com>
vmittal-msft pushed a commit that referenced this pull request Feb 1, 2026
#21451) (#22028)

Fix test_bgp_session_flap when memory stat is always 0, e.g., v4 neighbors memory usage in v6 topo.

Signed-off-by: markxiao <markxiao@arista.com>
Co-authored-by: Mark Xiao <markxiao@arista.com>
ytzur1 pushed a commit to ytzur1/sonic-mgmt that referenced this pull request Feb 2, 2026
sonic-net#21451)

Fix test_bgp_session_flap when memory stat is always 0, e.g., v4 neighbors memory usage in v6 topo.

Signed-off-by: markxiao <markxiao@arista.com>
Signed-off-by: Yael Tzur <ytzur@nvidia.com>
abhishek-nexthop pushed a commit to nexthop-ai/sonic-mgmt that referenced this pull request Feb 6, 2026
sonic-net#21451)

Fix test_bgp_session_flap when memory stat is always 0, e.g., v4 neighbors memory usage in v6 topo.

Signed-off-by: markxiao <markxiao@arista.com>
lakshmi-nexthop pushed a commit to lakshmi-nexthop/sonic-mgmt that referenced this pull request Feb 11, 2026
sonic-net#21451) (sonic-net#22028)

Fix test_bgp_session_flap when memory stat is always 0, e.g., v4 neighbors memory usage in v6 topo.

Signed-off-by: markxiao <markxiao@arista.com>
Co-authored-by: Mark Xiao <markxiao@arista.com>
Signed-off-by: Lakshmi Yarramaneni <lakshmi@nexthop.ai>
nnelluri-cisco pushed a commit to nnelluri-cisco/sonic-mgmt that referenced this pull request Feb 12, 2026
sonic-net#21451)

Fix test_bgp_session_flap when memory stat is always 0, e.g., v4 neighbors memory usage in v6 topo.

Signed-off-by: markxiao <markxiao@arista.com>
Signed-off-by: nnelluri-cisco <nnelluri@cisco.com>
rraghav-cisco pushed a commit to rraghav-cisco/sonic-mgmt that referenced this pull request Feb 13, 2026
sonic-net#21451)

Fix test_bgp_session_flap when memory stat is always 0, e.g., v4 neighbors memory usage in v6 topo.

Signed-off-by: markxiao <markxiao@arista.com>
Signed-off-by: Raghavendran Ramanathan <rraghav@cisco.com>
anilal-amd pushed a commit to anilal-amd/anilal-forked-sonic-mgmt that referenced this pull request Feb 19, 2026
sonic-net#21451)

Fix test_bgp_session_flap when memory stat is always 0, e.g., v4 neighbors memory usage in v6 topo.

Signed-off-by: markxiao <markxiao@arista.com>
Signed-off-by: Zhuohui Tan <zhuohui.tan@amd.com>
abhishek-nexthop pushed a commit to nexthop-ai/sonic-mgmt that referenced this pull request Mar 17, 2026
sonic-net#21451)

Fix test_bgp_session_flap when memory stat is always 0, e.g., v4 neighbors memory usage in v6 topo.

Signed-off-by: markxiao <markxiao@arista.com>
Signed-off-by: Abhishek <abhishek@nexthop.ai>
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Mar 27, 2026
sonic-net#21451)

Fix test_bgp_session_flap when memory stat is always 0, e.g., v4 neighbors memory usage in v6 topo.

Signed-off-by: markxiao <markxiao@arista.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: test_bgp_session_flap.py failed on v6 topo

7 participants