Fix memory comparison in test_bgp_session_flap.py for v6 topo#21451
Merged
StormLiangMS merged 1 commit intosonic-net:masterfrom Jan 16, 2026
Merged
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
b7f9c40 to
23e98d7
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
23e98d7 to
9a97898
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
r12f
approved these changes
Dec 5, 2025
Collaborator
r12f
left a comment
There was a problem hiding this comment.
will be better to add a comment, but overall looking good. very straight forward fix.
Fix test_bgp_session_flap when memory stat is always 0, e.g., v4 neighbors memory usage in v6 topo. Signed-off-by: markxiao <markxiao@arista.com>
9a97898 to
5377179
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
Done |
Collaborator
|
/azp run |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jan 20, 2026
sonic-net#21451) Fix test_bgp_session_flap when memory stat is always 0, e.g., v4 neighbors memory usage in v6 topo. Signed-off-by: markxiao <markxiao@arista.com>
Collaborator
|
Cherry-pick PR to 202511: #22028 |
7 tasks
7 tasks
Collaborator
|
Cherry-pick PR to msft-202412: Azure/sonic-mgmt.msft#964 |
PriyanshTratiya
pushed a commit
to PriyanshTratiya/sonic-mgmt
that referenced
this pull request
Jan 21, 2026
sonic-net#21451) Fix test_bgp_session_flap when memory stat is always 0, e.g., v4 neighbors memory usage in v6 topo. Signed-off-by: markxiao <markxiao@arista.com> Signed-off-by: Priyansh Tratiya <ptratiya@microsoft.com>
AndoniSanguesa
pushed a commit
to AndoniSanguesa/sonic-mgmt
that referenced
this pull request
Jan 21, 2026
sonic-net#21451) Fix test_bgp_session_flap when memory stat is always 0, e.g., v4 neighbors memory usage in v6 topo. Signed-off-by: markxiao <markxiao@arista.com> Signed-off-by: Andoni Sanguesa <andoniesanguesa@gmail.com>
AndoniSanguesa
pushed a commit
to AndoniSanguesa/sonic-mgmt
that referenced
this pull request
Jan 21, 2026
sonic-net#21451) Fix test_bgp_session_flap when memory stat is always 0, e.g., v4 neighbors memory usage in v6 topo. Signed-off-by: markxiao <markxiao@arista.com> Signed-off-by: Andoni Sanguesa <andoniesanguesa@gmail.com>
saravanan-nexthop
pushed a commit
to nexthop-ai/sonic-mgmt
that referenced
this pull request
Jan 22, 2026
sonic-net#21451) Fix test_bgp_session_flap when memory stat is always 0, e.g., v4 neighbors memory usage in v6 topo. Signed-off-by: markxiao <markxiao@arista.com> Signed-off-by: Saravanan Sellappa <saravanan@nexthop.ai>
justin-oliver
pushed a commit
to justin-oliver/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
sonic-net#21451) Fix test_bgp_session_flap when memory stat is always 0, e.g., v4 neighbors memory usage in v6 topo. Signed-off-by: markxiao <markxiao@arista.com>
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Feb 2, 2026
sonic-net#21451) Fix test_bgp_session_flap when memory stat is always 0, e.g., v4 neighbors memory usage in v6 topo. Signed-off-by: markxiao <markxiao@arista.com> Signed-off-by: Yael Tzur <ytzur@nvidia.com>
abhishek-nexthop
pushed a commit
to nexthop-ai/sonic-mgmt
that referenced
this pull request
Feb 6, 2026
sonic-net#21451) Fix test_bgp_session_flap when memory stat is always 0, e.g., v4 neighbors memory usage in v6 topo. Signed-off-by: markxiao <markxiao@arista.com>
lakshmi-nexthop
pushed a commit
to lakshmi-nexthop/sonic-mgmt
that referenced
this pull request
Feb 11, 2026
sonic-net#21451) (sonic-net#22028) Fix test_bgp_session_flap when memory stat is always 0, e.g., v4 neighbors memory usage in v6 topo. Signed-off-by: markxiao <markxiao@arista.com> Co-authored-by: Mark Xiao <markxiao@arista.com> Signed-off-by: Lakshmi Yarramaneni <lakshmi@nexthop.ai>
nnelluri-cisco
pushed a commit
to nnelluri-cisco/sonic-mgmt
that referenced
this pull request
Feb 12, 2026
sonic-net#21451) Fix test_bgp_session_flap when memory stat is always 0, e.g., v4 neighbors memory usage in v6 topo. Signed-off-by: markxiao <markxiao@arista.com> Signed-off-by: nnelluri-cisco <nnelluri@cisco.com>
rraghav-cisco
pushed a commit
to rraghav-cisco/sonic-mgmt
that referenced
this pull request
Feb 13, 2026
sonic-net#21451) Fix test_bgp_session_flap when memory stat is always 0, e.g., v4 neighbors memory usage in v6 topo. Signed-off-by: markxiao <markxiao@arista.com> Signed-off-by: Raghavendran Ramanathan <rraghav@cisco.com>
anilal-amd
pushed a commit
to anilal-amd/anilal-forked-sonic-mgmt
that referenced
this pull request
Feb 19, 2026
sonic-net#21451) Fix test_bgp_session_flap when memory stat is always 0, e.g., v4 neighbors memory usage in v6 topo. Signed-off-by: markxiao <markxiao@arista.com> Signed-off-by: Zhuohui Tan <zhuohui.tan@amd.com>
abhishek-nexthop
pushed a commit
to nexthop-ai/sonic-mgmt
that referenced
this pull request
Mar 17, 2026
sonic-net#21451) Fix test_bgp_session_flap when memory stat is always 0, e.g., v4 neighbors memory usage in v6 topo. Signed-off-by: markxiao <markxiao@arista.com> Signed-off-by: Abhishek <abhishek@nexthop.ai>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Mar 27, 2026
sonic-net#21451) Fix test_bgp_session_flap when memory stat is always 0, e.g., v4 neighbors memory usage in v6 topo. Signed-off-by: markxiao <markxiao@arista.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Fix test_bgp_session_flap when memory stat is always 0, e.g., v4 neighbors memory usage in v6 topo.
Summary:
Fixes #21450
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix test_bgp_session_flap.py for v6 topo
How did you do it?
Change memory comparison sign from less than to less than or equal to.
How did you verify/test it?
The test passed after the change
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation