Add meter_type packets when creating blocking scheduler by rgarofano-arista · Pull Request #21436 · sonic-net/sonic-mgmt

rgarofano-arista · 2025-11-25T20:54:28Z

Description of PR

Summary:
Fixes # (issue)

Type of change

Back port request

Approach

What is the motivation for this PR?

Packet trimming tests rely on simulating congestion on an egress queue. For this, the tests are trying to apply a shaper that significantly slows down the amount of packets sent out of the target egress queue per second. We found that this shaper doesn't work on th5 with the current config.

How did you do it?

The solution to this is to add "meter_type" packets when creating the blocking scheduler (shaper).

How did you verify/test it?

Verified via tcpdump that packet transmission rate was slowed down as expected on th5.

Any platform specific information?

This issue was discovered when testing on th5

Supported testbed topology if it's a new test case?

Documentation

mssonicbld · 2025-11-25T20:54:37Z

/azp run

azure-pipelines · 2025-11-25T20:54:51Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-11-26T21:38:15Z

/azp run

azure-pipelines · 2025-11-26T21:38:29Z

Azure Pipelines successfully started running 1 pipeline(s).

r12f

straight forward fix. lgtm.

weiguo-nvidia · 2025-12-11T07:57:33Z

Hi @rgarofano-arista

I verify this PR on x86_64-nvidia_sn5640-r0 platform, we do not the support the new parameter meter_type with error message "enum value SAI_METER_TYPE_PACKETS is not supported"

Test cmd

sonic-db-cli CONFIG_DB hset "SCHEDULER|SCHEDULER_BLOCK_DATA_PLANE" "type" DWRR "weight" 15 "pir" 1 "meter_type" packets

Error info in syslog

2025 Dec 11 09:31:27.772100 DUT ERR syncd#SDK: [SAI_UTILS.ERR] ./src/mlnx_sai_utils.c[1272]- sai_atribute_value_type_enum_validate: Failed to validate SAI_SCHEDULER_ATTR_METER_TYPE value - enum value SAI_METER_TYPE_PACKETS is not supported
2025 Dec 11 09:31:27.772100 DUT ERR syncd#SDK: [SAI_UTILS.ERR] ./src/mlnx_sai_utils.c[1798]- check_attribs_on_create_without_oid: Failed attributes check
2025 Dec 11 09:31:27.772100 DUT WARNING syncd#SDK: :- sai_serialize_enum: enum value -131069 not found in enum sai_status_t
2025 Dec 11 09:31:27.772100 DUT ERR syncd#SDK: :- sendApiResponse: api SAI_COMMON_API_CREATE failed in syncd mode: -131069
2025 Dec 11 09:31:27.772100 DUT WARNING syncd#SDK: :- sai_serialize_enum: enum value -131069 not found in enum sai_status_t
2025 Dec 11 09:31:27.772135 DUT ERR syncd#SDK: :- processQuadEvent: attr: SAI_SCHEDULER_ATTR_SCHEDULING_TYPE: SAI_SCHEDULING_TYPE_DWRR
2025 Dec 11 09:31:27.772135 DUT ERR syncd#SDK: :- processQuadEvent: attr: SAI_SCHEDULER_ATTR_SCHEDULING_WEIGHT: 15
2025 Dec 11 09:31:27.772144 DUT ERR syncd#SDK: :- processQuadEvent: attr: SAI_SCHEDULER_ATTR_MAX_BANDWIDTH_RATE: 1
2025 Dec 11 09:31:27.772150 DUT ERR syncd#SDK: :- processQuadEvent: attr: SAI_SCHEDULER_ATTR_METER_TYPE: SAI_METER_TYPE_PACKETS

nazariig · 2025-12-12T09:56:55Z

@rgarofano-arista please make this configuration vendor specific in case it is required for your platform

r12f

looks like meter type is vendor specific.

sdszhang · 2025-12-29T13:23:52Z

@rgarofano-arista can you resolve the conflict?

mssonicbld · 2025-12-30T19:38:52Z

/azp run

azure-pipelines · 2025-12-30T19:38:58Z

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

mssonicbld · 2025-12-30T19:40:50Z

/azp run

azure-pipelines · 2025-12-30T19:40:56Z

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

mssonicbld · 2025-12-30T21:47:53Z

/azp run

azure-pipelines · 2025-12-30T21:47:59Z

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

rgarofano-arista · 2025-12-30T21:49:12Z

looks like meter type is vendor specific.

I have changed it so that meter_type is only added to the scheduler command for the th5 asic.

mssonicbld · 2025-12-30T21:53:58Z

/azp run

azure-pipelines · 2025-12-30T21:54:04Z

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

meter_type is platform specific, so the inclusion of it is only implemented for Broadcom TH5 chip right now. Other chips in the future that require it will need to modify the code. Signed-off-by: Ryan Garofano <[email protected]>

StormLiangMS

LGTM

mssonicbld · 2026-01-20T19:28:43Z

@rgarofano-arista PR conflicts with 202511 branch

rgarofano-arista · 2026-01-20T22:09:29Z

Manual cherry-pick to 202511 #22071

) meter_type is platform specific, so the inclusion of it is only implemented for Broadcom TH5 chip right now. Other chips in the future that require it will need to modify the code. Signed-off-by: Ryan Garofano <[email protected]> Signed-off-by: Priyansh Tratiya <[email protected]>

) meter_type is platform specific, so the inclusion of it is only implemented for Broadcom TH5 chip right now. Other chips in the future that require it will need to modify the code. Signed-off-by: Ryan Garofano <[email protected]> Signed-off-by: Saravanan Sellappa <[email protected]>

) meter_type is platform specific, so the inclusion of it is only implemented for Broadcom TH5 chip right now. Other chips in the future that require it will need to modify the code. Signed-off-by: Ryan Garofano <[email protected]>

Pterosaur · 2026-01-27T02:07:28Z

Hi @r12f , could you please approve the PR request to 202412?

StormLiangMS · 2026-01-29T06:00:52Z

@rgarofano-arista could you to submit PR to 202511 and 202412 since cherrypick conflict?

rgarofano-arista · 2026-01-29T18:09:19Z

Manual cherry-pick to 202511 #22071

I already have a PR for 202511 (linked in quoted reply)
I created one for 202412: Azure/sonic-mgmt.msft#980

) meter_type is platform specific, so the inclusion of it is only implemented for Broadcom TH5 chip right now. Other chips in the future that require it will need to modify the code. Signed-off-by: Ryan Garofano <[email protected]> Signed-off-by: Yael Tzur <[email protected]>

) meter_type is platform specific, so the inclusion of it is only implemented for Broadcom TH5 chip right now. Other chips in the future that require it will need to modify the code. Signed-off-by: Ryan Garofano <[email protected]>

) meter_type is platform specific, so the inclusion of it is only implemented for Broadcom TH5 chip right now. Other chips in the future that require it will need to modify the code. Signed-off-by: Ryan Garofano <[email protected]> Signed-off-by: ayya <[email protected]>

) meter_type is platform specific, so the inclusion of it is only implemented for Broadcom TH5 chip right now. Other chips in the future that require it will need to modify the code. Signed-off-by: Ryan Garofano <[email protected]> Signed-off-by: nnelluri-cisco <[email protected]>

) meter_type is platform specific, so the inclusion of it is only implemented for Broadcom TH5 chip right now. Other chips in the future that require it will need to modify the code. Signed-off-by: Ryan Garofano <[email protected]> Signed-off-by: Raghavendran Ramanathan <[email protected]>

) meter_type is platform specific, so the inclusion of it is only implemented for Broadcom TH5 chip right now. Other chips in the future that require it will need to modify the code. Signed-off-by: Ryan Garofano <[email protected]> Signed-off-by: Zhuohui Tan <[email protected]>

…atically (sonic-net#21436) [submodule] Update submodule sonic-utilities to the latest HEAD automatically

) meter_type is platform specific, so the inclusion of it is only implemented for Broadcom TH5 chip right now. Other chips in the future that require it will need to modify the code. Signed-off-by: Ryan Garofano <[email protected]> Signed-off-by: Abhishek <[email protected]>

) meter_type is platform specific, so the inclusion of it is only implemented for Broadcom TH5 chip right now. Other chips in the future that require it will need to modify the code. Signed-off-by: Ryan Garofano <[email protected]>

…c-net#21436)" This reverts commit d474ce8.

) meter_type is platform specific, so the inclusion of it is only implemented for Broadcom TH5 chip right now. Other chips in the future that require it will need to modify the code. Signed-off-by: Ryan Garofano <[email protected]> Signed-off-by: Ze Gan <[email protected]>

) meter_type is platform specific, so the inclusion of it is only implemented for Broadcom TH5 chip right now. Other chips in the future that require it will need to modify the code. Signed-off-by: Ryan Garofano <[email protected]>

davidm-arista added Request for msft-202412 Branch Request for 202511 branch Request to backport a change to 202511 branch labels Nov 26, 2025

rgarofano-arista force-pushed the fix-shaper-packet-trimming branch from d840c81 to 96bbcc8 Compare November 26, 2025 21:37

r12f approved these changes Dec 11, 2025

View reviewed changes

dgsudharsan requested a review from nazariig December 11, 2025 05:49

r12f requested changes Dec 16, 2025

View reviewed changes

rgarofano-arista force-pushed the fix-shaper-packet-trimming branch from 96bbcc8 to cb8dad5 Compare December 30, 2025 19:38

github-actions bot requested a review from developfast December 30, 2025 19:38

rgarofano-arista force-pushed the fix-shaper-packet-trimming branch from cb8dad5 to afc14e6 Compare December 30, 2025 19:39

rgarofano-arista force-pushed the fix-shaper-packet-trimming branch from afc14e6 to 4a7fe24 Compare December 30, 2025 21:47

rgarofano-arista force-pushed the fix-shaper-packet-trimming branch from 4a7fe24 to 71059ec Compare December 30, 2025 21:53

Add meter_type packets when creating blocking scheduler

70bd85f

meter_type is platform specific, so the inclusion of it is only implemented for Broadcom TH5 chip right now. Other chips in the future that require it will need to modify the code. Signed-off-by: Ryan Garofano <[email protected]>

rgarofano-arista force-pushed the fix-shaper-packet-trimming branch from 71059ec to 70bd85f Compare January 2, 2026 17:25

mssonicbld added the Cherry Pick Conflict_msft-202412 label Jan 2, 2026

r12f approved these changes Jan 15, 2026

View reviewed changes

prsunny requested a review from kperumalbfn January 16, 2026 23:04

StormLiangMS reviewed Jan 19, 2026

View reviewed changes

StormLiangMS approved these changes Jan 19, 2026

View reviewed changes

StormLiangMS merged commit cf90103 into sonic-net:master Jan 19, 2026
17 checks passed

vmittal-msft added the Approved for 202511 branch label Jan 20, 2026

mssonicbld added the Cherry Pick Conflict_202511 label Jan 20, 2026

r12f added the Approved for msft-202412 Branch label Jan 28, 2026

r12f added Included in msft-202412 Branch and removed Cherry Pick Conflict_msft-202412 labels Feb 11, 2026

Pterosaur added a commit to Pterosaur/sonic-mgmt that referenced this pull request Mar 26, 2026

Revert "Add meter_type packets when creating blocking scheduler (soni…

7063d6d

…c-net#21436)" This reverts commit d474ce8.

Conversation

rgarofano-arista commented Nov 25, 2025

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

mssonicbld commented Nov 25, 2025

Uh oh!

azure-pipelines bot commented Nov 25, 2025

Uh oh!

mssonicbld commented Nov 26, 2025

Uh oh!

azure-pipelines bot commented Nov 26, 2025

Uh oh!

r12f left a comment

Choose a reason for hiding this comment

Uh oh!

weiguo-nvidia commented Dec 11, 2025

Uh oh!

nazariig commented Dec 12, 2025

Uh oh!

r12f left a comment

Choose a reason for hiding this comment

Uh oh!

sdszhang commented Dec 29, 2025

Uh oh!

mssonicbld commented Dec 30, 2025

Uh oh!

azure-pipelines bot commented Dec 30, 2025

Uh oh!

mssonicbld commented Dec 30, 2025

Uh oh!

azure-pipelines bot commented Dec 30, 2025

Uh oh!

mssonicbld commented Dec 30, 2025

Uh oh!

azure-pipelines bot commented Dec 30, 2025

Uh oh!

rgarofano-arista commented Dec 30, 2025

Uh oh!

mssonicbld commented Dec 30, 2025

Uh oh!

azure-pipelines bot commented Dec 30, 2025

Uh oh!

StormLiangMS left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mssonicbld commented Jan 20, 2026

Uh oh!

rgarofano-arista commented Jan 20, 2026

Uh oh!

Pterosaur commented Jan 27, 2026

Uh oh!

StormLiangMS commented Jan 29, 2026

Uh oh!

rgarofano-arista commented Jan 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants