Send more verification packets in packet trimming tests#21435
Merged
bingwang-ms merged 1 commit intosonic-net:masterfrom Dec 1, 2025
Merged
Send more verification packets in packet trimming tests#21435bingwang-ms merged 1 commit intosonic-net:masterfrom
bingwang-ms merged 1 commit intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
r12f
approved these changes
Nov 25, 2025
Collaborator
r12f
left a comment
r12f
left a comment
There was a problem hiding this comment.
The PR attached here slows down the draining time more, but it could be still not enough: https://github.com/Azure/sonic-mgmt.msft/pull/827/files.
bumping the packet count seems to be straightforward for the fix, hence approving.
@kperumalbfn @developfast , do you mind to also take a look at this PR?
kperumalbfn
reviewed
Nov 25, 2025
| DUMMY_IPV6 = "8000::2" | ||
| DUMMY_MAC = "00:11:22:33:44:55" | ||
| PACKET_COUNT = 10 | ||
| PACKET_COUNT = 100 |
kperumalbfn
approved these changes
Nov 25, 2025
r12f
added
Request for msft-202412 Branch
Request for 202511 branch
rgarofano-arista
force-pushed
the
send-more-verify-packets-th5
branch
from
699a78f to
3fd5bd6
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
developfast
approved these changes
Nov 28, 2025
Contributor
|
@rgarofano-arista can you fix the PR checker failure? |
Signed-off-by: Ryan Garofano <[email protected]>
rgarofano-arista
force-pushed
the
send-more-verify-packets-th5
branch
from
3fd5bd6 to
0a58d9d
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
Cherry-pick PR to msft-202412: Azure/sonic-mgmt.msft#897 |
mssonicbld
added
Included in msft-202412 Branch
and removed
Created PR to msft-202412 Branch
labels
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Dec 4, 2025
) Signed-off-by: Ryan Garofano <[email protected]>
mssonicbld
pushed a commit
that referenced
this pull request
Dec 9, 2025
Signed-off-by: Ryan Garofano <[email protected]>
mssonicbld
added
Included in 202511 branch
and removed
Created PR to 202511 branch
labels
nissampa
pushed a commit
to nissampa/sonic-mgmt_dpu_test
that referenced
this pull request
Dec 9, 2025
) Signed-off-by: Ryan Garofano <[email protected]> Signed-off-by: Nishanth Sampath Kumar <[email protected]>
selldinesh
pushed a commit
to selldinesh/sonic-mgmt
that referenced
this pull request
Dec 11, 2025
) Signed-off-by: Ryan Garofano <[email protected]> Signed-off-by: selldinesh <[email protected]>
echuawu
pushed a commit
to echuawu/sonic-mgmt
that referenced
this pull request
Dec 12, 2025
) Signed-off-by: Ryan Garofano <[email protected]>
saravanan-nexthop
pushed a commit
to saravanan-nexthop/sonic-mgmt
that referenced
this pull request
Dec 15, 2025
) Signed-off-by: Ryan Garofano <[email protected]> Signed-off-by: Saravanan <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
) Signed-off-by: Ryan Garofano <[email protected]> Signed-off-by: Guy Shemesh <[email protected]>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
) Signed-off-by: Ryan Garofano <[email protected]> Signed-off-by: Aharon Malkin <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
) Signed-off-by: Ryan Garofano <[email protected]> Signed-off-by: Guy Shemesh <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
) Signed-off-by: Ryan Garofano <[email protected]> Signed-off-by: Guy Shemesh <[email protected]>
vrajeshe
pushed a commit
to Akshath-17/sonic-mgmt
that referenced
this pull request
Jan 4, 2026
) Signed-off-by: Ryan Garofano <[email protected]> Signed-off-by: Venkata Gouri Rajesh Etla <[email protected]>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Jan 13, 2026
) Signed-off-by: Ryan Garofano <[email protected]>
yifan-nexthop
pushed a commit
to nexthop-ai/sonic-mgmt
that referenced
this pull request
Jan 14, 2026
) Signed-off-by: Ryan Garofano <[email protected]> Signed-off-by: YiFan Wang <[email protected]>
vmittal-msft
added
Approved for 202511 branch
and removed
Approved for 202511 branch
labels
Collaborator
|
@rgarofano-arista PR conflicts with 202511 branch |
Contributor
Author
|
The change is already present in 202511 |
PriyanshTratiya
pushed a commit
to PriyanshTratiya/sonic-mgmt
that referenced
this pull request
Jan 21, 2026
) Signed-off-by: Ryan Garofano <[email protected]> Signed-off-by: Priyansh Tratiya <[email protected]>
lakshmi-nexthop
pushed a commit
to lakshmi-nexthop/sonic-mgmt
that referenced
this pull request
Jan 28, 2026
) Signed-off-by: Ryan Garofano <[email protected]> Signed-off-by: Lakshmi Yarramaneni <[email protected]>
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Jan 29, 2026
) Signed-off-by: Ryan Garofano <[email protected]>
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Feb 2, 2026
) Signed-off-by: Ryan Garofano <[email protected]> Signed-off-by: Yael Tzur <[email protected]>
abhishek-nexthop
pushed a commit
to nexthop-ai/sonic-mgmt
that referenced
this pull request
Feb 6, 2026
) Signed-off-by: Ryan Garofano <[email protected]>
lakshmi-nexthop
pushed a commit
to lakshmi-nexthop/sonic-mgmt
that referenced
this pull request
Feb 11, 2026
) Signed-off-by: Ryan Garofano <[email protected]> Signed-off-by: Lakshmi Yarramaneni <[email protected]>
rraghav-cisco
pushed a commit
to rraghav-cisco/sonic-mgmt
that referenced
this pull request
Feb 13, 2026
) Signed-off-by: Ryan Garofano <[email protected]> Signed-off-by: Raghavendran Ramanathan <[email protected]>
anilal-amd
pushed a commit
to anilal-amd/anilal-forked-sonic-mgmt
that referenced
this pull request
Feb 19, 2026
) Signed-off-by: Ryan Garofano <[email protected]> Signed-off-by: Zhuohui Tan <[email protected]>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…lly (sonic-net#21435) [submodule][202411] Update submodule sonic-swss to the latest HEAD
abhishek-nexthop
pushed a commit
to nexthop-ai/sonic-mgmt
that referenced
this pull request
Mar 17, 2026
) Signed-off-by: Ryan Garofano <[email protected]> Signed-off-by: Abhishek <[email protected]>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Mar 27, 2026
) Signed-off-by: Ryan Garofano <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Verification for packet trimming tests was failing on th5. We found that trimming was not occurring because too many packets were leaking out of the egress queue despite the shaper being applied.
How did you do it?
By increasing the number of packets sent from 10 to 100 in the verification stage, we saw that trimming was occurring and the verification passed.
How did you verify/test it?
Verified that packet trimming tests were passing with the change.
Any platform specific information?
This issue was discovered when trying to support broadcom th5.
Supported testbed topology if it's a new test case?
Documentation