Skip to content

[dualtor] Skip test_replace_fec#21358

Merged
StormLiangMS merged 1 commit intosonic-net:masterfrom
lolyu:test_replace_fec_skip_dualtor_m2
Dec 3, 2025
Merged

[dualtor] Skip test_replace_fec#21358
StormLiangMS merged 1 commit intosonic-net:masterfrom
lolyu:test_replace_fec_skip_dualtor_m2

Conversation

@lolyu
Copy link
Copy Markdown
Collaborator

@lolyu lolyu commented Nov 19, 2025 •
edited
Loading

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Approach

What is the motivation for this PR?

Skip test_replace_fec on dualtor as the test is trying to change
downlink's fec from none to rs, this is not a valid/supported
scenario, the testcase needs a further improvement.

Signed-off-by: Longxiang Lyu lolv@microsoft.com

How did you do it?

How did you verify/test it?

generic_config_updater/test_eth_interface.py::test_replace_fec[None-rs] SKIPPED (Skip test_replace_fec on unsupported hwsku/topo due to issue)                                                                                                       [ 50%]
generic_config_updater/test_eth_interface.py::test_replace_fec[None-fc] SKIPPED (Skip test_replace_fec on unsupported hwsku/topo due to issue)                                                                                                       [100%]

======================================================================================================== 2 skipped, 4 warnings in 60.55s (0:01:00) =========================================================================================================

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@lolyu
[dualtor] Skip test_replace_fec
7fb3754 
Skip `test_replace_fec` on dualtor as the test is trying to change
downlink's fec from `none` to `rs`, this is not a valid/supported
scenario, the testcase needs a further improvement.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Nov 19, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Nov 19, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@lolyu lolyu mentioned this pull request Nov 19, 2025
Merged
11 tasks
@StormLiangMS StormLiangMS merged commit 4b976c1 into sonic-net:master Dec 3, 2025
20 checks passed
@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Dec 3, 2025

@lolyu PR conflicts with 202505 branch

opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025
@lolyu
[dualtor] Skip test_replace_fec (sonic-net#21358)
4b31fad 
Skip `test_replace_fec` on dualtor as the test is trying to change
downlink's fec from `none` to `rs`, this is not a valid/supported
scenario, the testcase needs a further improvement.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
dcaugher pushed a commit to dcaugher/sonic-mgmt that referenced this pull request Dec 8, 2025
@lolyu @dcaugher
[dualtor] Skip test_replace_fec (sonic-net#21358)
41c3ee2 
Skip `test_replace_fec` on dualtor as the test is trying to change
downlink's fec from `none` to `rs`, this is not a valid/supported
scenario, the testcase needs a further improvement.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Signed-off-by: Dan Caugherty <dcaugher@cisco.com>
nissampa pushed a commit to nissampa/sonic-mgmt_dpu_test that referenced this pull request Dec 9, 2025
@lolyu @nissampa
[dualtor] Skip test_replace_fec (sonic-net#21358)
9674338 
Skip `test_replace_fec` on dualtor as the test is trying to change
downlink's fec from `none` to `rs`, this is not a valid/supported
scenario, the testcase needs a further improvement.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Signed-off-by: Nishanth Sampath Kumar <nissampa@cisco.com>
selldinesh pushed a commit to selldinesh/sonic-mgmt that referenced this pull request Dec 11, 2025
@lolyu @selldinesh
[dualtor] Skip test_replace_fec (sonic-net#21358)
46cb073 
Skip `test_replace_fec` on dualtor as the test is trying to change
downlink's fec from `none` to `rs`, this is not a valid/supported
scenario, the testcase needs a further improvement.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Signed-off-by: selldinesh <dinesh.sellappan@keysight.com>
echuawu pushed a commit to echuawu/sonic-mgmt that referenced this pull request Dec 12, 2025
@lolyu @echuawu
[dualtor] Skip test_replace_fec (sonic-net#21358)
0f6b590 
Skip `test_replace_fec` on dualtor as the test is trying to change
downlink's fec from `none` to `rs`, this is not a valid/supported
scenario, the testcase needs a further improvement.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
saravanan-nexthop pushed a commit to saravanan-nexthop/sonic-mgmt that referenced this pull request Dec 15, 2025
@lolyu @saravanan-nexthop
[dualtor] Skip test_replace_fec (sonic-net#21358)
3551778 
Skip `test_replace_fec` on dualtor as the test is trying to change
downlink's fec from `none` to `rs`, this is not a valid/supported
scenario, the testcase needs a further improvement.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Signed-off-by: Saravanan <saravanan@nexthop.ai>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 16, 2025
@lolyu @gshemesh2
[dualtor] Skip test_replace_fec (sonic-net#21358)
4e55eb5 
Skip `test_replace_fec` on dualtor as the test is trying to change
downlink's fec from `none` to `rs`, this is not a valid/supported
scenario, the testcase needs a further improvement.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Dec 16, 2025
@lolyu @AharonMalkin
[dualtor] Skip test_replace_fec (sonic-net#21358)
e9d27cb 
Skip `test_replace_fec` on dualtor as the test is trying to change
downlink's fec from `none` to `rs`, this is not a valid/supported
scenario, the testcase needs a further improvement.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Signed-off-by: Aharon Malkin <amalkin@nvidia.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
@lolyu @gshemesh2
[dualtor] Skip test_replace_fec (sonic-net#21358)
2f6c4c3 
Skip `test_replace_fec` on dualtor as the test is trying to change
downlink's fec from `none` to `rs`, this is not a valid/supported
scenario, the testcase needs a further improvement.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
@lolyu @gshemesh2
[dualtor] Skip test_replace_fec (sonic-net#21358)
7e88305 
Skip `test_replace_fec` on dualtor as the test is trying to change
downlink's fec from `none` to `rs`, this is not a valid/supported
scenario, the testcase needs a further improvement.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
vrajeshe pushed a commit to Akshath-17/sonic-mgmt that referenced this pull request Jan 4, 2026
@lolyu @vrajeshe
[dualtor] Skip test_replace_fec (sonic-net#21358)
1b3eefc 
Skip `test_replace_fec` on dualtor as the test is trying to change
downlink's fec from `none` to `rs`, this is not a valid/supported
scenario, the testcase needs a further improvement.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Signed-off-by: Venkata Gouri Rajesh Etla <vrajeshe@cisco.com>
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Jan 13, 2026
@lolyu @venu-nexthop
[dualtor] Skip test_replace_fec (sonic-net#21358)
710be7c 
Skip `test_replace_fec` on dualtor as the test is trying to change
downlink's fec from `none` to `rs`, this is not a valid/supported
scenario, the testcase needs a further improvement.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
yifan-nexthop pushed a commit to nexthop-ai/sonic-mgmt that referenced this pull request Jan 14, 2026
@lolyu @yifan-nexthop
[dualtor] Skip test_replace_fec (sonic-net#21358)
296a525 
Skip `test_replace_fec` on dualtor as the test is trying to change
downlink's fec from `none` to `rs`, this is not a valid/supported
scenario, the testcase needs a further improvement.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Signed-off-by: YiFan Wang <yifan@nexthop.ai>
PriyanshTratiya pushed a commit to PriyanshTratiya/sonic-mgmt that referenced this pull request Jan 21, 2026
@lolyu @PriyanshTratiya
[dualtor] Skip test_replace_fec (sonic-net#21358)
9a79ea1 
Skip `test_replace_fec` on dualtor as the test is trying to change
downlink's fec from `none` to `rs`, this is not a valid/supported
scenario, the testcase needs a further improvement.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Signed-off-by: Priyansh Tratiya <ptratiya@microsoft.com>
lakshmi-nexthop pushed a commit to lakshmi-nexthop/sonic-mgmt that referenced this pull request Jan 28, 2026
@lolyu @lakshmi-nexthop
[dualtor] Skip test_replace_fec (sonic-net#21358)
da0465f 
Skip `test_replace_fec` on dualtor as the test is trying to change
downlink's fec from `none` to `rs`, this is not a valid/supported
scenario, the testcase needs a further improvement.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Signed-off-by: Lakshmi Yarramaneni <lakshmi@nexthop.ai>
ytzur1 pushed a commit to ytzur1/sonic-mgmt that referenced this pull request Jan 29, 2026
@lolyu @ytzur1
[dualtor] Skip test_replace_fec (sonic-net#21358)
8b1b29f 
Skip `test_replace_fec` on dualtor as the test is trying to change
downlink's fec from `none` to `rs`, this is not a valid/supported
scenario, the testcase needs a further improvement.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
ytzur1 pushed a commit to ytzur1/sonic-mgmt that referenced this pull request Feb 2, 2026
@lolyu @ytzur1
[dualtor] Skip test_replace_fec (sonic-net#21358)
b22dad8 
Skip `test_replace_fec` on dualtor as the test is trying to change
downlink's fec from `none` to `rs`, this is not a valid/supported
scenario, the testcase needs a further improvement.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Signed-off-by: Yael Tzur <ytzur@nvidia.com>
abhishek-nexthop pushed a commit to nexthop-ai/sonic-mgmt that referenced this pull request Feb 6, 2026
@lolyu @abhishek-nexthop
[dualtor] Skip test_replace_fec (sonic-net#21358)
f6e008f 
Skip `test_replace_fec` on dualtor as the test is trying to change
downlink's fec from `none` to `rs`, this is not a valid/supported
scenario, the testcase needs a further improvement.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
rraghav-cisco pushed a commit to rraghav-cisco/sonic-mgmt that referenced this pull request Feb 13, 2026
@lolyu @rraghav-cisco
[dualtor] Skip test_replace_fec (sonic-net#21358)
e1f9655 
Skip `test_replace_fec` on dualtor as the test is trying to change
downlink's fec from `none` to `rs`, this is not a valid/supported
scenario, the testcase needs a further improvement.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Signed-off-by: Raghavendran Ramanathan <rraghav@cisco.com>
anilal-amd pushed a commit to anilal-amd/anilal-forked-sonic-mgmt that referenced this pull request Feb 19, 2026
@lolyu @ztan-amd
[dualtor] Skip test_replace_fec (sonic-net#21358)
5ef50f1 
Skip `test_replace_fec` on dualtor as the test is trying to change
downlink's fec from `none` to `rs`, this is not a valid/supported
scenario, the testcase needs a further improvement.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Signed-off-by: Zhuohui Tan <zhuohui.tan@amd.com>
abhishek-nexthop pushed a commit to nexthop-ai/sonic-mgmt that referenced this pull request Mar 17, 2026
@lolyu @abhishek-nexthop
[dualtor] Skip test_replace_fec (sonic-net#21358)
19e5dec 
Skip `test_replace_fec` on dualtor as the test is trying to change
downlink's fec from `none` to `rs`, this is not a valid/supported
scenario, the testcase needs a further improvement.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Signed-off-by: Abhishek <abhishek@nexthop.ai>
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Mar 27, 2026
@lolyu
[dualtor] Skip test_replace_fec (sonic-net#21358)
13cf67c 
Skip `test_replace_fec` on dualtor as the test is trying to change
downlink's fec from `none` to `rs`, this is not a valid/supported
scenario, the testcase needs a further improvement.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yxieca yxieca yxieca approved these changes

Assignees

No one assigned

Labels

Approved for 202505 branch Cherry Pick Conflict_202505 Request for 202505 branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lolyu @mssonicbld @yxieca @StormLiangMS