Support multi-chip in packet trimming tests with refactor#21318
Merged
bingwang-ms merged 4 commits intosonic-net:masterfrom Dec 2, 2025
Merged
Support multi-chip in packet trimming tests with refactor#21318bingwang-ms merged 4 commits intosonic-net:masterfrom
bingwang-ms merged 4 commits intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
r12f
added
Request for msft-202412 Branch
Request for 202511 branch
kperumalbfn
reviewed
Nov 25, 2025
| "Trim sent counter on switch level is not equal to the sum of trim sent counter on port " | ||
| "level") | ||
|
|
||
| trim_queue = PacketTrimmingConfig.get_trim_queue(duthost) |
Collaborator
There was a problem hiding this comment.
Please also update tests/generic_config_updater/test_packet_trimming_config_symmetric.py and tests/generic_config_updater/test_packet_trimming_config_asymmetric.py
rgarofano-arista
force-pushed
the
refactor-packet-trimming
branch
from
e64c1a4 to
24c6262
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rgarofano-arista
force-pushed
the
refactor-packet-trimming
branch
from
24c6262 to
1fa4716
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rgarofano-arista
force-pushed
the
refactor-packet-trimming
branch
from
1fa4716 to
67e4de9
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rgarofano-arista
force-pushed
the
refactor-packet-trimming
branch
from
67e4de9 to
2a264d9
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kperumalbfn
approved these changes
Dec 2, 2025
Collaborator
|
@r12f could you add to 202412 |
dcaugher
pushed a commit
to dcaugher/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
…21318) * Support multi-chip in packet trimming tests Signed-off-by: Dan Caugherty <dcaugher@cisco.com>
nissampa
pushed a commit
to nissampa/sonic-mgmt_dpu_test
that referenced
this pull request
Dec 9, 2025
…21318) * Support multi-chip in packet trimming tests Signed-off-by: Nishanth Sampath Kumar <nissampa@cisco.com>
Contributor
|
Hi @rgarofano-arista @vmittal-msft |
Collaborator
|
hi @vmittal-msft , do you mind to help us with 202511 pickup? |
selldinesh
pushed a commit
to selldinesh/sonic-mgmt
that referenced
this pull request
Dec 11, 2025
…21318) * Support multi-chip in packet trimming tests Signed-off-by: selldinesh <dinesh.sellappan@keysight.com>
echuawu
pushed a commit
to echuawu/sonic-mgmt
that referenced
this pull request
Dec 12, 2025
…21318) * Support multi-chip in packet trimming tests
saravanan-nexthop
pushed a commit
to saravanan-nexthop/sonic-mgmt
that referenced
this pull request
Dec 15, 2025
…21318) * Support multi-chip in packet trimming tests Signed-off-by: Saravanan <saravanan@nexthop.ai>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
…21318) * Support multi-chip in packet trimming tests Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
…21318) * Support multi-chip in packet trimming tests Signed-off-by: Aharon Malkin <amalkin@nvidia.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
…21318) * Support multi-chip in packet trimming tests Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
…21318) * Support multi-chip in packet trimming tests Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
vrajeshe
pushed a commit
to Akshath-17/sonic-mgmt
that referenced
this pull request
Jan 4, 2026
…21318) * Support multi-chip in packet trimming tests Signed-off-by: Venkata Gouri Rajesh Etla <vrajeshe@cisco.com>
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jan 8, 2026
…21318) * Support multi-chip in packet trimming tests
Collaborator
|
Cherry-pick PR to 202511: #21870 |
12 tasks
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Jan 13, 2026
…21318) * Support multi-chip in packet trimming tests
yifan-nexthop
pushed a commit
to nexthop-ai/sonic-mgmt
that referenced
this pull request
Jan 14, 2026
…21318) * Support multi-chip in packet trimming tests Signed-off-by: YiFan Wang <yifan@nexthop.ai>
vmittal-msft
pushed a commit
that referenced
this pull request
Jan 14, 2026
PriyanshTratiya
pushed a commit
to PriyanshTratiya/sonic-mgmt
that referenced
this pull request
Jan 21, 2026
…21318) * Support multi-chip in packet trimming tests Signed-off-by: Priyansh Tratiya <ptratiya@microsoft.com>
lakshmi-nexthop
pushed a commit
to lakshmi-nexthop/sonic-mgmt
that referenced
this pull request
Jan 28, 2026
…21318) * Support multi-chip in packet trimming tests Signed-off-by: Lakshmi Yarramaneni <lakshmi@nexthop.ai>
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Jan 29, 2026
…21318) * Support multi-chip in packet trimming tests
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Feb 2, 2026
…21318) * Support multi-chip in packet trimming tests Signed-off-by: Yael Tzur <ytzur@nvidia.com>
abhishek-nexthop
pushed a commit
to nexthop-ai/sonic-mgmt
that referenced
this pull request
Feb 6, 2026
…21318) * Support multi-chip in packet trimming tests
lakshmi-nexthop
pushed a commit
to lakshmi-nexthop/sonic-mgmt
that referenced
this pull request
Feb 11, 2026
…21318) (sonic-net#21870) * Support multi-chip in packet trimming tests Co-authored-by: Ryan Garofano <rgarofano@arista.com> Signed-off-by: Lakshmi Yarramaneni <lakshmi@nexthop.ai>
rraghav-cisco
pushed a commit
to rraghav-cisco/sonic-mgmt
that referenced
this pull request
Feb 13, 2026
…21318) * Support multi-chip in packet trimming tests Signed-off-by: Raghavendran Ramanathan <rraghav@cisco.com>
anilal-amd
pushed a commit
to anilal-amd/anilal-forked-sonic-mgmt
that referenced
this pull request
Feb 19, 2026
…21318) * Support multi-chip in packet trimming tests Signed-off-by: Zhuohui Tan <zhuohui.tan@amd.com>
abhishek-nexthop
pushed a commit
to nexthop-ai/sonic-mgmt
that referenced
this pull request
Mar 17, 2026
…21318) * Support multi-chip in packet trimming tests Signed-off-by: Abhishek <abhishek@nexthop.ai>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Mar 27, 2026
…21318) * Support multi-chip in packet trimming tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Packet trimming configuration depends on the chip, but currently everything is based on constants. In order to support multiple chips we should refactor all packet trimming configuration to retrieve values through functions that check the asic name in duthost.
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Packet trimming tests today are written with only small set of chips in mind. The test uses constants for all configuration values. In an effort to support packet trimming on Arista Quicksilver512, we found these constants did not work to configure the chip.
How did you do it?
Refactored any config related constants into functions that are accessed through the class
PacketTrimmingConfig. These static methods requireduthostto be passed in such that values returned can be based onduthost.get_asic_name().How did you verify/test it?
We have been running packet trimming tests internally with this refactor and have sorted out any failures related to this refactor.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation