Skip to content

[ACL] Correct rule ID used to check ACL counter in teardown phase. #2124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shihhsien-wang wants to merge 1 commit into from
Closed

[ACL] Correct rule ID used to check ACL counter in teardown phase. #2124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions tests/acl/test_acl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,7 +480,7 @@ def test_dest_ip_match_forwarded(self, setup, direction, ptfadapter, counters_sa
testutils.send(ptfadapter, self.get_src_port(setup, direction), pkt)
testutils.verify_packet_any_port(ptfadapter, exp_pkt, ports=self.get_dst_ports(setup, direction))

counters_sanity_check.append(2 if direction == 'spine->tor' else 3)
counters_sanity_check.append(3 if direction == 'spine->tor' else 2)

def test_dest_ip_match_dropped(self, setup, direction, ptfadapter, counters_sanity_check):
""" test destination IP matched packet dropped """
Expand All @@ -493,7 +493,7 @@ def test_dest_ip_match_dropped(self, setup, direction, ptfadapter, counters_sani
testutils.send(ptfadapter, self.get_src_port(setup, direction), pkt)
testutils.verify_no_packet_any(ptfadapter, exp_pkt, ports=self.get_dst_ports(setup, direction))

counters_sanity_check.append(15 if direction == 'spine->tor' else 16)
counters_sanity_check.append(16 if direction == 'spine->tor' else 15)

def test_source_ip_match_dropped(self, setup, direction, ptfadapter, counters_sanity_check):
""" test source IP matched packet dropped """
Expand Down Expand Up @@ -571,7 +571,7 @@ def test_l4_dport_match_forwarded(self, setup, direction, ptfadapter, counters_s
testutils.send(ptfadapter, self.get_src_port(setup, direction), pkt)
testutils.verify_packet_any_port(ptfadapter, exp_pkt, ports=self.get_dst_ports(setup, direction))

counters_sanity_check.append(5)
counters_sanity_check.append(9)

def test_l4_sport_match_forwarded(self, setup, direction, ptfadapter, counters_sanity_check):
""" test L4 source port matched packet forwarded """
Expand Down Expand Up @@ -610,7 +610,7 @@ def test_l4_sport_range_match_forwarded(self, setup, direction, ptfadapter, coun
testutils.send(ptfadapter, self.get_src_port(setup, direction), pkt)
testutils.verify_packet_any_port(ptfadapter, exp_pkt, ports=self.get_dst_ports(setup, direction))

counters_sanity_check.append(10)
counters_sanity_check.append(17)

def test_l4_dport_range_match_dropped(self, setup, direction, ptfadapter, counters_sanity_check):
""" test L4 destination port range matched packet dropped """
Expand Down Expand Up @@ -649,7 +649,7 @@ def test_ip_proto_match_forwarded(self, setup, direction, ptfadapter, counters_s
testutils.send(ptfadapter, self.get_src_port(setup, direction), pkt)
testutils.verify_packet_any_port(ptfadapter, exp_pkt, ports=self.get_dst_ports(setup, direction))

counters_sanity_check.append(5)
counters_sanity_check.append(19)

def test_tcp_flags_match_forwarded(self, setup, direction, ptfadapter, counters_sanity_check):
""" test TCP flags matched packet forwarded """
Expand Down