Various fix for test_dip_sip#2122
Merged
wangxin merged 2 commits intosonic-net:masterfrom Aug 21, 2020
wangxin:fix-dip-sip-pr
Merged
Various fix for test_dip_sip#2122wangxin merged 2 commits intosonic-net:masterfrom wangxin:fix-dip-sip-pr
wangxin merged 2 commits intosonic-net:masterfrom
wangxin:fix-dip-sip-pr
Conversation
Changes: * Change topology mark from "any" to "t0" and "t1" * Remove unused variables * Check topology type rather than name * Fix typo in log message * Remove calling the Ansible setup module, use minigraph to get router and host IP addresses * Use router mac from duthost.facts['router_mac'] * Simplify the code for getting src and dst port ids Signed-off-by: Xin Wang <xiwang5@microsoft.com>
daall
approved these changes
Aug 20, 2020
tests/ipfwd/test_dip_sip.py
Outdated
|
|
||
| pytestmark = [ | ||
| pytest.mark.topology('any') | ||
| pytest.mark.topology('t0', "t1") |
Contributor
There was a problem hiding this comment.
Suggested change
| pytest.mark.topology('t0', "t1") | |
| pytest.mark.topology("t0", "t1") |
For consistency. :)
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
* 3fc6e27 Fix issues in clear_qos (sonic-net#2122) Signed-off-by: Volodymyr Samotiy <volodymyrs@nvidia.com>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
c5c105f (HEAD -> 202111, origin/202111) [PBH] Implement Edit Flows (sonic-net#2093) 7050581 [techsupport] Handle minor fixes of TS Lock and update auto-TS (sonic-net#2114) 3602f99 Fix issues in clear_qos (sonic-net#2122) 4f96d3b Fixing get port speed when oper status is down (sonic-net#2123)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
The test_dip_sip script has some minor issues need to be fixed.
How did you do it?
Changes:
router and host IP addresses
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation