Skip to content

Replace per port SFP presence check with global command in check_interface_status #21074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mihirpat1 wants to merge 2 commits into from
Closed

Replace per port SFP presence check with global command in check_interface_status #21074

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
617c6d9
Replace per port SFP presence check with global command in check_inte…
mihirpat1 Oct 24, 2025
429a38f
Corrected a typo in log
mihirpat1 Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions tests/common/platform/interface_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,10 +103,10 @@ def check_interface_status(dut, asic_index, interfaces, xcvr_skip_list):
mg_ports = interface_list
output = dut.command("show interface description")
intf_status = parse_intf_status(output["stdout_lines"][2:])
if dut.is_multi_asic:
check_intf_presence_command = 'show interface transceiver presence -n {} {}'.format(namespace, {})
else:
check_intf_presence_command = 'show interface transceiver presence {}'
sfp_presence_output = dut.show_and_parse("show interfaces transceiver presence")
logging.info(f"SFP presence: {sfp_presence_output}")
sfp_presence_dict = {entry['port']: entry.get('presence', '').lower() for entry in sfp_presence_output}

for intf in interfaces:
expected_oper = "up" if intf in mg_ports else "down"
expected_admin = "up" if intf in mg_ports else "down"
Expand All @@ -124,10 +124,8 @@ def check_interface_status(dut, asic_index, interfaces, xcvr_skip_list):

# Cross check the interface SFP presence status
if intf not in xcvr_skip_list[dut.hostname]:
check_presence_output = dut.command(check_intf_presence_command.format(intf))
presence_list = check_presence_output["stdout_lines"][2].split()
assert intf in presence_list, "Wrong interface name in the output: %s" % str(presence_list)
assert 'Present' in presence_list, "Status is not expected, presence status: %s" % str(presence_list)
presence = sfp_presence_dict.get(intf, '')
assert presence == 'present', "Status is not expected, presence status: %s" % str(presence)

logging.info("Check interface status using the interface_facts module")
intf_facts = dut.interface_facts(up_ports=mg_ports, namespace=namespace)["ansible_facts"]
Expand Down
Loading