Fix exception in fdb.py caused by IPv6 Address in vlan interfaces#2103
Closed
bingwang-ms wants to merge 1 commit intosonic-net:masterfrom
Closed
Fix exception in fdb.py caused by IPv6 Address in vlan interfaces#2103bingwang-ms wants to merge 1 commit intosonic-net:masterfrom
bingwang-ms wants to merge 1 commit intosonic-net:masterfrom
Conversation
PR sonic-net#1982 added IPv6 address to vlan interface, which caused regression in test_fdb_mac_expire. This commit is to address this issue.
wangxin
approved these changes
Aug 14, 2020
neethajohn
approved these changes
Aug 14, 2020
Contributor
|
Is #2109 trying to address the same issue? |
3 tasks
yxieca
approved these changes
Aug 17, 2020
Collaborator
|
@bingwang-ms please resolve the merge conflict. |
Collaborator
Author
|
Already fixed in #2109 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
PR #1982 added IPv6 address to vlan interface, which caused
regression in test_fdb_mac_expire. This commit is to address this issue.
Type of change
Approach
What is the motivation for this PR?
PR #1982 added IPv6 address to vlan interface. As a result, the config file /root/fdb_info.txt for test_fdb_mac_expire is misformatted, which will cause exception in fdb.py. This PR is to address this issue.
How did you do it?
Update the template for generating /root/fdb_info.txt, and only IPv4 address is included in the generated config file.
How did you verify/test it?
Verify it on Arista-7260
Any platform specific information?
No
Supported testbed topology if it's a new test case?
N/A
Documentation
N/A