Skip to content

[testbed]: put mgmt interface of VMs into another vrf#210

Merged
pavel-shirshov merged 3 commits intosonic-net:masterfrom
pavel-shirshov:pavelsh/veos_vrf
Jul 31, 2017
Merged

[testbed]: put mgmt interface of VMs into another vrf#210
pavel-shirshov merged 3 commits intosonic-net:masterfrom
pavel-shirshov:pavelsh/veos_vrf

Conversation

@pavel-shirshov
Copy link
Contributor

Otherwise default routes from management interfaces could interfere with main routing table

@pavel-shirshov
Copy link
Contributor Author

Please don't merge until I test it fully.

@pavel-shirshov pavel-shirshov merged commit b3106e9 into sonic-net:master Jul 31, 2017
@pavel-shirshov pavel-shirshov deleted the pavelsh/veos_vrf branch July 31, 2017 18:06
lguohan pushed a commit that referenced this pull request Aug 3, 2017
* Use separate vrf for management interface.
zhixzhu pushed a commit to zhixzhu/sonic-mgmt that referenced this pull request May 1, 2025
<!--
Please make sure you've read and understood our contributing guidelines;
https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md

Please provide following information to help code review process a bit easier:
-->
### Description of PR
<!--
- Please include a summary of the change and which issue is fixed.
- Please also include relevant motivation and context. Where should reviewer start? background context?
- List any dependencies that are required for this change.
-->

Summary:
Fixes # (issue)

### Type of change

<!--
- Fill x for your type of change.
- e.g.
- [x] Bug fix
-->

- [ ] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [ ] New Test case
 - [ ] Skipped for non-supported platforms
- [ ] Test case improvement

### Back port request
- [ ] 202012
- [ ] 202205
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [ ] 202411

### Approach
#### What is the motivation for this PR?
The eos default cred is all digits. It may be interpreted as an integer and raise below error during tests:
```
 File "/var/src/sonic-mgmt/tests/common/devices/eos.py", line 85, in shutdown
 out = self.eos_config(
 File "/var/src/sonic-mgmt/tests/common/devices/base.py", line 131, in _run
 raise RunAnsibleModuleFail("run module {} failed".format(self.module_name), res)
tests.common.errors.RunAnsibleModuleFail: run module eos_config failed, Ansible Results =>
failed = True
module_stdout =
module_stderr = Expected unicode or bytes, got 123456
msg = MODULE FAILURE
See stdout/stderr for the exact error
_ansible_no_log = None
changed = False
stdout =
stderr =
```
#### How did you do it?
Add quote to the all digits default cred to force string type.
#### How did you verify/test it?

#### Any platform specific information?

#### Supported testbed topology if it's a new test case?

### Documentation
<!--
(If it's a new feature, new test case)
Did you update documentation/Wiki relevant to your implementation?
Link to the wiki page?
-->
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…et#7491)

20e1589 [Mellanox] [201911] backport kernel patches for hw-management 7.0100.2303 (sonic-net#210)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants