Multi_asic support for Counterpoll command by ansrajpu-git · Pull Request #20875 · sonic-net/sonic-mgmt

ansrajpu-git · 2025-09-30T21:15:22Z

Description of PR

Summary:
The existing "counterpoll" CLI command does not have support for multi asic.
This PR is raised to accommodate all changes required to support sonic-mgmt test w.r.t the sonic-utilities PR # sonic-net/sonic-utilities#4012 which was raised to enhance the feature for multi-asic
Fixes # (issue)

Type of change

Back port request

Approach

Verified the CLI used across all test suites and made changes accordingly

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Executed related test and verified the results.

Any platform specific information?

Mutli_asic

Supported testbed topology if it's a new test case?

Documentation

mssonicbld · 2025-09-30T21:15:31Z

/azp run

azure-pipelines · 2025-09-30T21:15:44Z

Azure Pipelines successfully started running 1 pipeline(s).

ansrajpu-git · 2025-09-30T21:16:49Z

@arlakshm @vmittal-msft , Kindly review this PR.

mssonicbld · 2025-10-01T18:19:00Z

/azp run

azure-pipelines · 2025-10-01T18:19:14Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-10-01T18:22:21Z

/azp run

azure-pipelines · 2025-10-01T18:22:36Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-10-03T17:02:40Z

/azp run

azure-pipelines · 2025-10-03T17:02:56Z

Azure Pipelines successfully started running 1 pipeline(s).

ansrajpu-git · 2025-10-07T17:32:25Z

@vmittal-msft, Please review. Please note the build failure is happening because this PR has a dependency on PR# sonic-net/sonic-utilities#4012 which is still not merged.

abdosi · 2025-10-29T17:50:27Z

@liamkearney-msft : please help review.

tests/snmp/conftest.py

saiarcot895 · 2025-11-24T16:57:04Z

@ansrajpu-git This PR is required for sonic-utilities submodule update, as multi-ASIC T1 KVM tests are failing. Please help with getting this ready for merge.

@vmittal-msft FYI.

vmittal-msft · 2025-11-24T22:12:59Z

@ansrajpu-git can you please share test results ? Also, is this only applicable for chassis or pizza box as well ? If generic changes, have we tested on pizza box ?

vmittal-msft · 2025-11-26T00:49:01Z

/azpw run

mssonicbld · 2025-11-26T00:49:03Z

/AzurePipelines run

azure-pipelines · 2025-11-26T00:49:16Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-11-26T18:22:07Z

/azp run

azure-pipelines · 2025-11-26T18:22:21Z

Azure Pipelines successfully started running 1 pipeline(s).

ansrajpu-git · 2025-11-26T18:44:52Z

@ansrajpu-git can you please share test results ? Also, is this only applicable for chassis or pizza box as well ? If generic changes, have we tested on pizza box ?

@vmittal-msft , Below is the snapshot of chassis results

Verified on T1 topo as well. Below are the results:

liamkearney-msft · 2025-11-26T23:37:53Z

tests/common/helpers/counterpoll_helper.py

+    def disable_counterpoll(duthost, counter_type_list, asic_id=None):
        for counterpoll_type in counter_type_list:
-            duthost.command(CounterpollConstants.COUNTERPOLL_DISABLE.format(counterpoll_type))
+            if duthost.is_multi_asic:


just a thought - if asic_id == None but the duthost is multi_asic, should we iterate through the asics within this function?
as in, for multi asic duts, if you specify the asic we only operate on that asic, but if you dont it will operate on all the asics?
That way the caller of theses functions wont need to iterate / check for multi asic before calling, its all handled by the counterpoll helper functions.

@liamkearney-msft , thanks for your review. The 'asic_id' is misleading, so made appropriate change as its 'asic' instance. As per my understanding multi_asic dut with single asic instance will have not None value & asic_index as '0'. Also, I kept the multi_asic check in caller function & removed from the called, to maintain a homogeneity in code.For ex., some function like -'verify_counterpoll_status' are nested.

saiarcot895 · 2025-11-30T19:13:05Z

tests/common/helpers/counterpoll_helper.py

        for counterpoll_type in counter_type_list:
-            duthost.command(CounterpollConstants.COUNTERPOLL_DISABLE.format(counterpoll_type))
+            if duthost.is_multi_asic:
+                asic_index = " -n asic{}".format(asic_id.asic_index)


This needs an additional check to see if the image this test is running on supports the -n option. Otherwise, if this test case runs on an image without the sonic-utilities PR present (which is the current master branch of buildimage), then this command will fail, and all tests running this command will fail.

saiarcot895

Please add support for checking if the image being used supports -n or not.

mssonicbld · 2025-12-03T04:04:25Z

/azp run

azure-pipelines · 2025-12-03T04:04:38Z

Azure Pipelines successfully started running 1 pipeline(s).

ansrajpu-git · 2025-12-03T04:33:11Z

Please add support for checking if the image being used supports -n or not.

@saiarcot895 , this PR is dependent on sonic-utility PR-sonic-net/sonic-utilities#4012, which is already merged in master.

saiarcot895 · 2025-12-03T07:07:15Z

This PR will be tested against the last good build from sonic-buildimage master branch (which doesn't support the -n flag). The sonic-utilities change will not get merged/made available in sonic-buildimage unless all of the tests in sonic-mgmt master branch pass (which doesn't use the -n flag).

There is a deadlock there.

Signed-off-by: ansrajpu <anshu.rajput@nokia.com>

mssonicbld · 2025-12-03T15:48:59Z

/azp run

azure-pipelines · 2025-12-03T15:49:16Z

Azure Pipelines successfully started running 1 pipeline(s).

ansrajpu-git · 2025-12-03T16:07:51Z

@vmittal-msft

ansrajpu-git · 2026-01-06T17:26:33Z

This PR is depended on the new sonic-utility PR #sonic-net/sonic-utilities#4152.
Also, please update the backport release branch to 202511

ansrajpu-git requested review from prgeor and wangxin as code owners September 30, 2025 21:15

mlok-nokia added this to SONiC Chassis Oct 22, 2025

abdosi requested a review from liamkearney-msft October 29, 2025 17:49

liamkearney-msft reviewed Oct 30, 2025

View reviewed changes

tests/snmp/conftest.py Outdated Show resolved Hide resolved

vmittal-msft previously approved these changes Nov 26, 2025

View reviewed changes

liamkearney-msft reviewed Nov 26, 2025

View reviewed changes

saiarcot895 reviewed Nov 30, 2025

View reviewed changes

saiarcot895 requested changes Nov 30, 2025

View reviewed changes

ansrajpu-git dismissed vmittal-msft’s stale review via e14a30f December 3, 2025 04:04

github-actions bot requested review from Javier-Tan, Junchao-Mellanox, bachalla, cyw233, liamkearney-msft, lolyu, theasianpianist, vaibhavhd, wsycqyz, xwjiang-ms, yejianquan and yutongzhang-microsoft December 3, 2025 04:04

ansrajpu-git added 10 commits December 3, 2025 10:46

[GITPPR_TBD]Counterpoll command multi_asic support

a159b1b

Signed-off-by: ansrajpu <anshu.rajput@nokia.com>

[GITPR_TBD]Multi_asic support for Counterpoll cmd

01e9e3a

Signed-off-by: ansrajpu <anshu.rajput@nokia.com>

flake8 fix

7d2e7e9

Signed-off-by: ansrajpu <anshu.rajput@nokia.com>

[GITPR_TBD]Multi_asic support for Counterpoll cmd cntd

787469c

Signed-off-by: ansrajpu <anshu.rajput@nokia.com>

Flake8 fix

5368385

Signed-off-by: ansrajpu <anshu.rajput@nokia.com>

[GITPR_TBD]Counterpoll msaic changes

4a3f19d

Signed-off-by: ansrajpu <anshu.rajput@nokia.com>

Flake8 fix

0da4526

Signed-off-by: ansrajpu <anshu.rajput@nokia.com>

[GITPR_20785]Using common method for snmp_conftest

abecc9b

Signed-off-by: ansrajpu <anshu.rajput@nokia.com>

[GIT_PR20875]Removing duplicate check for multi_asic in func

6be87c7

Signed-off-by: ansrajpu <anshu.rajput@nokia.com>

flake8 fix

094886d

Signed-off-by: ansrajpu <anshu.rajput@nokia.com>

ansrajpu-git force-pushed the masic_counterpoll branch from e14a30f to 094886d Compare December 3, 2025 15:48

Conversation

ansrajpu-git commented Sep 30, 2025

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

mssonicbld commented Sep 30, 2025

Uh oh!

azure-pipelines bot commented Sep 30, 2025

Uh oh!

ansrajpu-git commented Sep 30, 2025

Uh oh!

mssonicbld commented Oct 1, 2025

Uh oh!

azure-pipelines bot commented Oct 1, 2025

Uh oh!

mssonicbld commented Oct 1, 2025

Uh oh!

azure-pipelines bot commented Oct 1, 2025

Uh oh!

mssonicbld commented Oct 3, 2025

Uh oh!

azure-pipelines bot commented Oct 3, 2025

Uh oh!

ansrajpu-git commented Oct 7, 2025

Uh oh!

abdosi commented Oct 29, 2025

Uh oh!

Uh oh!

saiarcot895 commented Nov 24, 2025

Uh oh!

vmittal-msft commented Nov 24, 2025

Uh oh!

vmittal-msft commented Nov 26, 2025

Uh oh!

mssonicbld commented Nov 26, 2025

Uh oh!

azure-pipelines bot commented Nov 26, 2025

Uh oh!

mssonicbld commented Nov 26, 2025

Uh oh!

azure-pipelines bot commented Nov 26, 2025

Uh oh!

ansrajpu-git commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

liamkearney-msft Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

ansrajpu-git Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

saiarcot895 Nov 30, 2025

Choose a reason for hiding this comment

Uh oh!

saiarcot895 left a comment

Choose a reason for hiding this comment

Uh oh!

mssonicbld commented Dec 3, 2025

Uh oh!

azure-pipelines bot commented Dec 3, 2025

Uh oh!

ansrajpu-git commented Dec 3, 2025

Uh oh!

saiarcot895 commented Dec 3, 2025

Uh oh!

mssonicbld commented Dec 3, 2025

Uh oh!

azure-pipelines bot commented Dec 3, 2025

Uh oh!

ansrajpu-git commented Dec 3, 2025

Uh oh!

ansrajpu-git commented Jan 6, 2026

ansrajpu-git commented Nov 26, 2025 •

edited

Loading