Skip to content

Update J2CP QoS test parameters for PR23848 #20806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arlakshm merged 1 commit into from
Oct 2, 2025
Merged

Update J2CP QoS test parameters for PR23848 #20806

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
128 changes: 68 additions & 60 deletions tests/qos/files/qos_params.j2c.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,22 +108,22 @@ qos_params:
pkts_num_trig_egr_drp: 2396745
pkts_num_fill_egr_min: 0
cell_size: 4096
400000_50m:
400000_30m:
pkts_num_leak_out: 140
internal_hdr_size: 48
xoff_1:
dscp: 3
ecn: 1
pg: 3
pkts_num_trig_pfc: 764336
pkts_num_trig_ingr_drp: 765653
pkts_num_trig_pfc: 762403
pkts_num_trig_ingr_drp: 775751
Copy link
Copy Markdown
Contributor

@vmittal-msft vmittal-msft Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

400000 30m 0 2560 1495040 -5 1454025

Based on above pg limits for 400g/30m, total space a pg should get is shared space + per pg headroom limit. so i believe the ingress drop should happen with more than 1.5 MB space occupied ( per pg limit - 1.5mb & shared space) but about no is 775kb which seems less to me. Can you please double check ?

Copy link
Copy Markdown
Contributor Author

@peterbailey-arista peterbailey-arista Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for reviewing, Vineet

1495040 bytes is the headroom space for this profile
775751 - 762403 = 13348 packets to fill the headroom

13348 * 112 = 1494976 bytes, the margin and dynamic accounting in the test then accounts for the < 1 packet difference between 1494976 and 1495040

Let me know if that clarifies. Thanks again

pkts_num_margin: 100
xoff_2:
dscp: 4
ecn: 1
pg: 4
pkts_num_trig_pfc: 764336
pkts_num_trig_ingr_drp: 765653
pkts_num_trig_pfc: 762403
pkts_num_trig_ingr_drp: 775751
pkts_num_margin: 100
hdrm_pool_size:
dscps: [3, 4]
Expand All @@ -132,30 +132,32 @@ qos_params:
src_port_ids: [0, 2, 4, 6, 8, 10, 12, 14, 16]
dst_port_id: 18
pgs_num: 18
pkts_num_trig_pfc: 764223
pkts_num_hdrm_full: 1317
pkts_num_hdrm_partial: 1300
margin: 300
packet_size: 1246
cell_size: 4096
pkts_num_trig_pfc: 60391
pkts_num_hdrm_full: 1153
pkts_num_hdrm_partial: 1143
margin: 30
wm_pg_headroom:
dscp: 3
ecn: 1
pg: 3
pkts_num_trig_pfc: 764336
pkts_num_trig_ingr_drp: 765653
pkts_num_trig_pfc: 762403
pkts_num_trig_ingr_drp: 775751
cell_size: 4096
pkts_num_margin: 30
xon_1:
dscp: 3
ecn: 1
pg: 3
pkts_num_trig_pfc: 764336
pkts_num_trig_pfc: 762403
pkts_num_dismiss_pfc: 12985
pkts_num_margin: 150
xon_2:
dscp: 4
ecn: 1
pg: 4
pkts_num_trig_pfc: 764336
pkts_num_trig_pfc: 762403
pkts_num_dismiss_pfc: 12985
pkts_num_margin: 150
lossy_queue_1:
Expand All @@ -169,7 +171,7 @@ qos_params:
ecn: 1
pg: 3
pkts_num_fill_min: 0
pkts_num_trig_pfc: 764336
pkts_num_trig_pfc: 762403
packet_size: 64
cell_size: 4096
pkts_num_margin: 40
Expand All @@ -187,7 +189,7 @@ qos_params:
ecn: 1
queue: 3
pkts_num_fill_min: 0
pkts_num_trig_ingr_drp: 765653
pkts_num_trig_ingr_drp: 775751
cell_size: 4096
wm_buf_pool_lossless:
dscp: 3
Expand All @@ -196,7 +198,7 @@ qos_params:
queue: 3
pkts_num_fill_ingr_min: 0
pkts_num_trig_pfc: 28160
pkts_num_trig_ingr_drp: 765653
pkts_num_trig_ingr_drp: 775751
pkts_num_fill_egr_min: 8
cell_size: 4096
wm_q_shared_lossy:
Expand All @@ -222,15 +224,15 @@ qos_params:
dscp: 3
ecn: 1
pg: 3
pkts_num_trig_pfc: 764336
pkts_num_trig_ingr_drp: 1477730
pkts_num_trig_pfc: 762403
pkts_num_trig_ingr_drp: 1476277
pkts_num_margin: 100
xoff_2:
dscp: 4
ecn: 1
pg: 4
pkts_num_trig_pfc: 764336
pkts_num_trig_ingr_drp: 1477730
pkts_num_trig_pfc: 762403
pkts_num_trig_ingr_drp: 1476277
pkts_num_margin: 100
hdrm_pool_size:
dscps: [3, 4]
Expand All @@ -239,30 +241,32 @@ qos_params:
src_port_ids: [0, 2, 4, 6, 8, 10, 12, 14, 16]
dst_port_id: 18
pgs_num: 18
pkts_num_trig_pfc: 700628
pkts_num_hdrm_full: 713397
pkts_num_hdrm_partial: 713300
margin: 100
packet_size: 1246
cell_size: 4096
pkts_num_trig_pfc: 60391
pkts_num_hdrm_full: 61692
pkts_num_hdrm_partial: 61682
margin: 10
wm_pg_headroom:
dscp: 3
ecn: 1
pg: 3
pkts_num_trig_pfc: 764336
pkts_num_trig_ingr_drp: 1477730
pkts_num_trig_pfc: 762403
pkts_num_trig_ingr_drp: 1476277
cell_size: 4096
pkts_num_margin: 30
xon_1:
dscp: 3
ecn: 1
pg: 3
pkts_num_trig_pfc: 764336
pkts_num_trig_pfc: 762403
pkts_num_dismiss_pfc: 12985
pkts_num_margin: 150
xon_2:
dscp: 4
ecn: 1
pg: 4
pkts_num_trig_pfc: 764336
pkts_num_trig_pfc: 762403
pkts_num_dismiss_pfc: 12985
pkts_num_margin: 150
lossy_queue_1:
Expand All @@ -276,7 +280,7 @@ qos_params:
ecn: 1
pg: 3
pkts_num_fill_min: 0
pkts_num_trig_pfc: 764336
pkts_num_trig_pfc: 762403
packet_size: 64
cell_size: 4096
pkts_num_margin: 40
Expand All @@ -294,7 +298,7 @@ qos_params:
ecn: 1
queue: 3
pkts_num_fill_min: 0
pkts_num_trig_ingr_drp: 1477730
pkts_num_trig_ingr_drp: 1476277
cell_size: 4096
wm_buf_pool_lossless:
dscp: 3
Expand Down Expand Up @@ -482,22 +486,22 @@ qos_params:
pkts_num_trig_egr_drp: 2179900
pkts_num_fill_egr_min: 0
cell_size: 4096
400000_50m:
400000_30m:
pkts_num_leak_out: 140
internal_hdr_size: 48
xoff_1:
dscp: 3
ecn: 1
pg: 3
pkts_num_trig_pfc: 764223
pkts_num_trig_ingr_drp: 765540
pkts_num_trig_pfc: 762403
pkts_num_trig_ingr_drp: 775751
pkts_num_margin: 100
xoff_2:
dscp: 4
ecn: 1
pg: 4
pkts_num_trig_pfc: 764223
pkts_num_trig_ingr_drp: 765540
pkts_num_trig_pfc: 762403
pkts_num_trig_ingr_drp: 775751
pkts_num_margin: 100
hdrm_pool_size:
dscps: [3, 4]
Expand All @@ -506,30 +510,32 @@ qos_params:
src_port_ids: [0, 2, 4, 6, 8, 10, 12, 14, 16]
dst_port_id: 18
pgs_num: 18
pkts_num_trig_pfc: 764223
pkts_num_hdrm_full: 1317
pkts_num_hdrm_partial: 1300
margin: 300
packet_size: 1246
cell_size: 4096
pkts_num_trig_pfc: 60391
pkts_num_hdrm_full: 1153
pkts_num_hdrm_partial: 1143
margin: 30
wm_pg_headroom:
dscp: 3
ecn: 1
pg: 3
pkts_num_trig_pfc: 764223
pkts_num_trig_ingr_drp: 765540
pkts_num_trig_pfc: 762403
pkts_num_trig_ingr_drp: 775751
cell_size: 4096
pkts_num_margin: 30
xon_1:
dscp: 3
ecn: 1
pg: 3
pkts_num_trig_pfc: 764223
pkts_num_trig_pfc: 762403
pkts_num_dismiss_pfc: 12985
pkts_num_margin: 150
xon_2:
dscp: 4
ecn: 1
pg: 4
pkts_num_trig_pfc: 764223
pkts_num_trig_pfc: 762403
pkts_num_dismiss_pfc: 12985
pkts_num_margin: 150
lossy_queue_1:
Expand All @@ -543,7 +549,7 @@ qos_params:
ecn: 1
pg: 3
pkts_num_fill_min: 0
pkts_num_trig_pfc: 764223
pkts_num_trig_pfc: 762403
packet_size: 64
cell_size: 4096
pkts_num_margin: 40
Expand All @@ -561,7 +567,7 @@ qos_params:
ecn: 1
queue: 3
pkts_num_fill_min: 0
pkts_num_trig_ingr_drp: 765540
pkts_num_trig_ingr_drp: 775751
cell_size: 4096
wm_buf_pool_lossless:
dscp: 3
Expand All @@ -570,7 +576,7 @@ qos_params:
queue: 3
pkts_num_fill_ingr_min: 0
pkts_num_trig_pfc: 28160
pkts_num_trig_ingr_drp: 765540
pkts_num_trig_ingr_drp: 775751
pkts_num_fill_egr_min: 8
cell_size: 4096
wm_q_shared_lossy:
Expand All @@ -596,15 +602,15 @@ qos_params:
dscp: 3
ecn: 1
pg: 3
pkts_num_trig_pfc: 764223
pkts_num_trig_ingr_drp: 1477617
pkts_num_trig_pfc: 762403
pkts_num_trig_ingr_drp: 1476277
pkts_num_margin: 100
xoff_2:
dscp: 4
ecn: 1
pg: 4
pkts_num_trig_pfc: 764223
pkts_num_trig_ingr_drp: 1477617
pkts_num_trig_pfc: 762403
pkts_num_trig_ingr_drp: 1476277
pkts_num_margin: 100
hdrm_pool_size:
dscps: [3, 4]
Expand All @@ -613,30 +619,32 @@ qos_params:
src_port_ids: [0, 2, 4, 6, 8, 10, 12, 14, 16]
dst_port_id: 18
pgs_num: 18
pkts_num_trig_pfc: 700628
pkts_num_hdrm_full: 713397
pkts_num_hdrm_partial: 713300
margin: 100
packet_size: 1246
cell_size: 4096
pkts_num_trig_pfc: 60391
pkts_num_hdrm_full: 61692
pkts_num_hdrm_partial: 61682
margin: 10
wm_pg_headroom:
dscp: 3
ecn: 1
pg: 3
pkts_num_trig_pfc: 764223
pkts_num_trig_ingr_drp: 1477617
pkts_num_trig_pfc: 762403
pkts_num_trig_ingr_drp: 1476277
cell_size: 4096
pkts_num_margin: 30
xon_1:
dscp: 3
ecn: 1
pg: 3
pkts_num_trig_pfc: 764223
pkts_num_trig_pfc: 762403
pkts_num_dismiss_pfc: 12985
pkts_num_margin: 150
xon_2:
dscp: 4
ecn: 1
pg: 4
pkts_num_trig_pfc: 764223
pkts_num_trig_pfc: 762403
pkts_num_dismiss_pfc: 12985
pkts_num_margin: 150
lossy_queue_1:
Expand All @@ -650,7 +658,7 @@ qos_params:
ecn: 1
pg: 3
pkts_num_fill_min: 0
pkts_num_trig_pfc: 764223
pkts_num_trig_pfc: 762403
packet_size: 64
cell_size: 4096
pkts_num_margin: 40
Expand All @@ -668,7 +676,7 @@ qos_params:
ecn: 1
queue: 3
pkts_num_fill_min: 0
pkts_num_trig_ingr_drp: 1477617
pkts_num_trig_ingr_drp: 1476277
cell_size: 4096
wm_buf_pool_lossless:
dscp: 3
Expand Down