Skip to content

Add test plan and tests for liquid cooling leakage detection#20792

Merged
roy-sror merged 4 commits intosonic-net:masterfrom
JibinBao:Add_liquid_detection_test
Mar 18, 2026
Merged

Add test plan and tests for liquid cooling leakage detection#20792
roy-sror merged 4 commits intosonic-net:masterfrom
JibinBao:Add_liquid_detection_test

Conversation

@JibinBao
Copy link
Copy Markdown
Contributor

@JibinBao JibinBao commented Sep 24, 2025

Description of PR

  1. Add test plan and tests for liquid cooling leakage detection.
  2. Refactor the existing thermal control library to support the new liquid cooling leakage detection case
    HLD: Liquid Cooling leakage detection in SONiC SONiC#2032.

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Approach

What is the motivation for this PR?

Add test plan and tests for liquid cooling leakage detection

How did you do it?

Add test plan and tests for liquid cooling leakage detection

How did you verify/test it?

Run the tests on dut supporting liquid cooling leakage detection

Any platform specific information?

Device supporting supporting liquid cooling leakage detection

Supported testbed topology if it's a new test case?

Any

Documentation

@JibinBao JibinBao requested a review from prgeor as a code owner September 24, 2025 05:43
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@JibinBao JibinBao force-pushed the Add_liquid_detection_test branch from 9608a8d to a00d598 Compare September 24, 2025 06:30
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@JibinBao JibinBao force-pushed the Add_liquid_detection_test branch from a00d598 to c936dd4 Compare September 24, 2025 06:39
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@JibinBao
Copy link
Copy Markdown
Contributor Author

/azpw run Azure.sonic-mgmt

@mssonicbld
Copy link
Copy Markdown
Collaborator

/AzurePipelines run Azure.sonic-mgmt

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@roy-sror
Copy link
Copy Markdown
Contributor

@prgeor - can you pls approve this PR?

@roy-sror
Copy link
Copy Markdown
Contributor

roy-sror commented Nov 4, 2025

@prgeor - can you please have a look?

@nhe-NV nhe-NV added the Request for 202511 branch Request to backport a change to 202511 branch label Nov 24, 2025
@JibinBao
Copy link
Copy Markdown
Contributor Author

Hi, @prgeor Can you please review it?

@wangxin wangxin requested a review from rlhui January 15, 2026 10:12
@wangxin wangxin requested a review from judyjoseph January 15, 2026 10:12
@wangxin
Copy link
Copy Markdown
Collaborator

wangxin commented Jan 15, 2026

@judyjoseph @rlhui Can you review this platform related PR?

kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…t#20792)

Add GNMI client cert cname list to yang model.

#### Why I did it
Allow gnmi service authentication client cert by cname.

### How I did it
Add GNMI client cert cname list to yang model.

#### How to verify it
Pass all UT.

### Description for the changelog
Add GNMI client cert cname list to yang model.
@yxieca
Copy link
Copy Markdown
Collaborator

yxieca commented Mar 18, 2026

AI agent on behalf of Ying. Found issues: TODO/FIXME present.

@roy-sror roy-sror merged commit e8d2d77 into sonic-net:master Mar 18, 2026
21 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Mar 18, 2026
@mssonicbld
Copy link
Copy Markdown
Collaborator

Cherry-pick PR to 202511: #23074

mssonicbld pushed a commit that referenced this pull request Mar 18, 2026
Signed-off-by: mssonicbld <sonicbld@microsoft.com>
vrajeshe pushed a commit to vrajeshe/sonic-mgmt that referenced this pull request Mar 23, 2026
…et#20792)

Signed-off-by: Venkata Gouri Rajesh Etla <vrajeshe@cisco.com>
@judyjoseph
Copy link
Copy Markdown
Contributor

@nhe-NV We are hitting test failures with leak detection in 202511 .. Wanted to check why this label Request for 202511 was added ? We haven't backported any liquid leak detection platform daemon PRs to 202511

ravaliyel pushed a commit to ravaliyel/sonic-mgmt that referenced this pull request Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants