Open
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Collaborator
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Collaborator
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
mihirpat1
reviewed
Sep 10, 2025
docs/testplan/transceiver_onboarding/optics_insertion_removal_testplan.md
Outdated
Show resolved
Hide resolved
docs/testplan/transceiver_onboarding/optics_insertion_removal_testplan.md
Outdated
Show resolved
Hide resolved
docs/testplan/transceiver_onboarding/optics_insertion_removal_testplan.md
Outdated
Show resolved
Hide resolved
docs/testplan/transceiver_onboarding/optics_insertion_removal_testplan.md
Outdated
Show resolved
Hide resolved
docs/testplan/transceiver_onboarding/optics_insertion_removal_testplan.md
Outdated
Show resolved
Hide resolved
Collaborator
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Collaborator
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
docs/testplan/transceiver_onboarding/optics_insertion_removal_testplan.md
Outdated
Show resolved
Hide resolved
Collaborator
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
11 tasks
mihirpat1
reviewed
Sep 12, 2025
docs/testplan/transceiver_onboarding/optics_insertion_removal_testplan.md
Outdated
Show resolved
Hide resolved
docs/testplan/transceiver_onboarding/optics_insertion_removal_testplan.md
Outdated
Show resolved
Hide resolved
docs/testplan/transceiver_onboarding/optics_insertion_removal_testplan.md
Outdated
Show resolved
Hide resolved
docs/testplan/transceiver_onboarding/optics_insertion_removal_testplan.md
Outdated
Show resolved
Hide resolved
docs/testplan/transceiver_onboarding/optics_insertion_removal_testplan.md
Outdated
Show resolved
Hide resolved
docs/testplan/transceiver_onboarding/optics_insertion_removal_testplan.md
Outdated
Show resolved
Hide resolved
docs/testplan/transceiver_onboarding/optics_insertion_removal_testplan.md
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a comprehensive test plan for validating the insertion and removal of optical transceivers in SONiC. The document establishes testing procedures for both physical OIR (Online Insertion and Removal) operations and remote reseat scenarios.
- Defines test cases for physical and remote optics insertion/removal validation
- Specifies configuration attributes and API structure for OIR testing
- Covers various optics types including AOC, AEC, DR8, DAC, SR/LR, FR, ZR, and breakout cables
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
docs/testplan/transceiver_onboarding/optics_insertion_removal_testplan.md
Outdated
Show resolved
Hide resolved
docs/testplan/transceiver_onboarding/optics_insertion_removal_testplan.md
Outdated
Show resolved
Hide resolved
docs/testplan/transceiver_onboarding/optics_insertion_removal_testplan.md
Outdated
Show resolved
Hide resolved
docs/testplan/transceiver_onboarding/optics_insertion_removal_testplan.md
Outdated
Show resolved
Hide resolved
Collaborator
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Collaborator
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Collaborator
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Collaborator
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Collaborator
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
8d0c871 to
0c4d3a9
Compare
Collaborator
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
az-pz
commented
Feb 20, 2026
Collaborator
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Collaborator
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Collaborator
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Collaborator
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Add OIR API. Address PR comments. Update docs/testplan/transceiver_onboarding/optics_insertion_removal_testplan.md Co-authored-by: mihirpat1 <112018033+mihirpat1@users.noreply.github.com> Add tables to monitor Update OIR API. Update testplan to check for presence data. Add checks for peer port as well. Added the sample PhysicalOIR class. Signed-off-by: Ariz Zubair(Microsoft) <arizzubair@microsoft.com>
Signed-off-by: Ariz Zubair(Microsoft) <arizzubair@microsoft.com>
Signed-off-by: Ariz Zubair(Microsoft) <arizzubair@microsoft.com>
Updated the expected results for optics removal validation to include link flap count for the local port. Signed-off-by: Ariz Zubair(Microsoft) <arizzubair@microsoft.com>
Signed-off-by: Ariz Zubair(Microsoft) <arizzubair@microsoft.com>
…R test plan Signed-off-by: Ariz Zubair(Microsoft) <arizzubair@microsoft.com>
…parameter Signed-off-by: Ariz Zubair(Microsoft) <arizzubair@microsoft.com>
aa32b4d to
60f5838
Compare
Collaborator
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
yxieca
approved these changes
Mar 18, 2026
Collaborator
yxieca
left a comment
There was a problem hiding this comment.
AI agent on behalf of Ying. Reviewed; no issues found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
This PR adds a testplan for optics insertion and removal testing in sonic-mgmt.
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation
ADO: 34410994