Skip to content

Optics insertion removal testplan#20524

Open
az-pz wants to merge 8 commits intosonic-net:masterfrom
az-pz:ariz/create-optics-insertion-removal-testplan
Open

Optics insertion removal testplan#20524
az-pz wants to merge 8 commits intosonic-net:masterfrom
az-pz:ariz/create-optics-insertion-removal-testplan

Conversation

@az-pz
Copy link
Contributor

@az-pz az-pz commented Sep 4, 2025

Description of PR

Summary:
This PR adds a testplan for optics insertion and removal testing in sonic-mgmt.
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

ADO: 34410994

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@az-pz az-pz marked this pull request as ready for review September 9, 2025 22:21
@az-pz az-pz requested review from wangxin and yxieca as code owners September 9, 2025 22:21
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a comprehensive test plan for validating the insertion and removal of optical transceivers in SONiC. The document establishes testing procedures for both physical OIR (Online Insertion and Removal) operations and remote reseat scenarios.

  • Defines test cases for physical and remote optics insertion/removal validation
  • Specifies configuration attributes and API structure for OIR testing
  • Covers various optics types including AOC, AEC, DR8, DAC, SR/LR, FR, ZR, and breakout cables

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@az-pz az-pz force-pushed the ariz/create-optics-insertion-removal-testplan branch from 8d0c871 to 0c4d3a9 Compare February 20, 2026 14:40
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@az-pz az-pz mentioned this pull request Mar 12, 2026
12 tasks
az-pz and others added 8 commits March 16, 2026 14:55
Add OIR API.

Address PR comments.

Update docs/testplan/transceiver_onboarding/optics_insertion_removal_testplan.md

Co-authored-by: mihirpat1 <112018033+mihirpat1@users.noreply.github.com>

Add tables to monitor

Update OIR API.

Update testplan to check for presence data.

Add checks for peer port as well.

Added the sample PhysicalOIR class.

Signed-off-by: Ariz Zubair(Microsoft) <arizzubair@microsoft.com>
Signed-off-by: Ariz Zubair(Microsoft) <arizzubair@microsoft.com>
Signed-off-by: Ariz Zubair(Microsoft) <arizzubair@microsoft.com>
Signed-off-by: Ariz Zubair(Microsoft) <arizzubair@microsoft.com>
Updated the expected results for optics removal validation to include link flap count for the local port.

Signed-off-by: Ariz Zubair(Microsoft) <arizzubair@microsoft.com>
Signed-off-by: Ariz Zubair(Microsoft) <arizzubair@microsoft.com>
…R test plan

Signed-off-by: Ariz Zubair(Microsoft) <arizzubair@microsoft.com>
…parameter

Signed-off-by: Ariz Zubair(Microsoft) <arizzubair@microsoft.com>
@az-pz az-pz force-pushed the ariz/create-optics-insertion-removal-testplan branch from aa32b4d to 60f5838 Compare March 16, 2026 14:56
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

Copy link
Collaborator

@yxieca yxieca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI agent on behalf of Ying. Reviewed; no issues found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants