Fix is_xcvr_optical check failure for Moby backplane port SFP type#20489
Merged
prgeor merged 1 commit intosonic-net:masterfrom Sep 3, 2025
Merged
Fix is_xcvr_optical check failure for Moby backplane port SFP type#20489prgeor merged 1 commit intosonic-net:masterfrom
prgeor merged 1 commit intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
Test result: There are still some keyError failures with this fix, which will be addressed as a separate issue. |
Contributor
Author
|
@prgeor can you help to review this one? |
prgeor
approved these changes
Sep 3, 2025
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Sep 4, 2025
Collaborator
|
Cherry-pick PR to 202505: #20518 |
Merged
11 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Sep 4, 2025
xixuej
pushed a commit
to xixuej/sonic-mgmt
that referenced
this pull request
Sep 17, 2025
vidyac86
pushed a commit
to vidyac86/sonic-mgmt
that referenced
this pull request
Oct 23, 2025
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
Signed-off-by: Aharon Malkin <amalkin@nvidia.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Jan 13, 2026
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
lakshmi-nexthop
pushed a commit
to lakshmi-nexthop/sonic-mgmt
that referenced
this pull request
Jan 28, 2026
Signed-off-by: Lakshmi Yarramaneni <lakshmi@nexthop.ai>
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Feb 2, 2026
Signed-off-by: Yael Tzur <ytzur@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fix the following issue:
Moby's backplane port has the following attribute:
'type': 'Backplane Cartridge',
'type_abbrv_name': 'BP',
However, 'BP' is not in the non-optical check list, this PR adds it into the list.
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix optical checking API to include the new backplane port used in Moby.
How did you do it?
Add Moby BP port type into the list.
How did you verify/test it?
Local testbed.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation