Update qos dscp mapping script by echuawu · Pull Request #20429 · sonic-net/sonic-mgmt

echuawu · 2025-08-28T03:00:11Z

Description of PR

Optimize the tests/qos/test_qos_dscp_mapping.py test to dramatically reduce the running time dramatically.
If there are 4 upstream links in the topology, for the basic traffic test, the running time would be reduced by 75% compared with the original script.
If there are 8 upstream links in the topology, for the basic traffic test, the running time would be reduced over 85% compared with the original script.

Script modifications:

Optimize the test cases and use one case to do the two dscp mode test
Change the teardown step to a fixture to make sure it must be executed
Make sure dscp_to_tc_map is AZURE
Add warm reboot action to enhance the test coverage
Remove skip condition for mellanox
Optimize the packet validation flow which dramatically reduced the execution time
Optimize the queue counter check flow to reduce the queue counter check execution time
Add port and dscp mode as well as route check to enhance the script debuggability
Use completeness_level, by default the script would run warm reboot test
if completeness_level had been set as basic, it would skip warm reboot test and the function test
after warm reboot action

Summary:
Fixes # (issue)

Type of change

Back port request

Approach

What is the motivation for this PR?

Enhance the tests/qos/test_qos_dscp_mapping.py

How did you do it?

Optimize the test cases and use one case to do the two dscp mode test
Change the teardown step to a fixture to make sure it must be executed
Make sure dscp_to_tc_map is AZURE
Add warm reboot action to enhance the test coverage
Remove skip condition for mellanox
Optimize the packet validation flow which dramatically reduced the execution time
Optimize the queue counter check flow to reduce the queue counter check execution time
Add port and dscp mode as well as route check to enhance the script debuggability
Use completeness_level, by default the script would run warm reboot test
if completeness_level had been set as basic, it would skip warm reboot test and the function test
after warm reboot action

How did you verify/test it?

Run it locally

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

mssonicbld · 2025-08-28T03:00:18Z

/azp run

azure-pipelines · 2025-08-28T03:00:43Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-08-28T07:15:46Z

/azp run

azure-pipelines · 2025-08-28T07:16:02Z

Azure Pipelines successfully started running 1 pipeline(s).

echuawu · 2025-08-28T07:36:45Z

Hi @wangxin ,
During PR checker running, there is a common issue regarding the testbed, please help check.

==============================================================================
Task         : Command line
Description  : Run a command line script using Bash on Linux and macOS and cmd.exe on Windows
Version      : 2.250.1
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/command-line
==============================================================================
Generating script.
========================== Starting Command Output ===========================
/usr/bin/bash --noprofile --norc /agent/_work/_temp/2de78f50-e43e-48d0-94f6-d11072f1eb53.sh
Step: Prepare Testbed
Preparing the testbed(add-topo, deploy-mg) may take 15-30 minutes. Before the testbed is ready, the progress of the test plan keeps displayed as 0, please be patient
TEST_PLAN_ID_LIST: 68b0034e33016fb86d910830
Please visit Elastictest page https://elastictest.org/scheduler/testplan/68b0034e33016fb86d910830 for detailed test plan progress 
[test_plan.py] poll PREPARE_TESTBED status
Test plan utils parameters: Namespace(action='poll', test_plan_id='68b0034e33016fb86d910830', expected_state='PREPARE_TESTBED', expected_result=None, interval=60, timeout=-1)
Polling progress and status of test plan at https://elastictest.org/scheduler/testplan/68b0034e33016fb86d910830
Polling interval: 60 seconds
az login --identity --client-id
Az login successfully. Login time: 2025-08-28 07:21:50.368095+00:00
Get token successfully. Token will expire on 2025-08-29 06:42:11.000000.
Test plan id: 68b0034e33016fb86d910830, status: PREPARE_TESTBED, expected_status: PREPARE_TESTBED, elapsed: 0 seconds
Test plan id: 68b0034e33016fb86d910830, status: PREPARE_TESTBED, expected_status: PREPARE_TESTBED, elapsed: 61 seconds
Test plan id: 68b0034e33016fb86d910830, status: FAILED, expected_status: PREPARE_TESTBED, elapsed: 121 seconds
Test summary:
{
    "errors": 0,
    "failures": 0,
    "skipped": 0,
    "tests": 0,
    "times": 0.0,
    "xfails": 0,
    "passes": 0,
    "err_msg": [],
    "warn_msg": [
        "Testbed Unhealthy: vms-kvm-four-asic-t1-lag_250018 was kicked out: PrepareTestbedFailed: . 2025-08-28 07:22:20 UTC",
        "Testbed Unhealthy: vms-kvm-four-asic-t1-lag_250055 was kicked out: PrepareTestbedFailed: . 2025-08-28 07:22:20 UTC",
        "Testbed Unhealthy: vms-kvm-four-asic-t1-lag_250049 was kicked out: PrepareTestbedFailed: . 2025-08-28 07:22:20 UTC",
        "Testbed Unhealthy: vms-kvm-four-asic-t1-lag_250019 was kicked out: PrepareTestbedFailed: . 2025-08-28 07:22:33 UTC"
    ],
    "tests_ignore_retries": 0,
    "passes_ignore_retries": 0,
    "errors_ignore_retries": 0,
    "failures_ignore_retries": 0,
    "times_ignore_retries": 0.0
}
Error type: PREPARE_TESTBED_FAILED
Error message: Prepare testbed failed: testbed_q_sonic-elastictest-prod-vmss-D16s-v3_249993 for PREPARE_TESTBED_FAILED, testbed is: vms-kvm-four-asic-t1-lag_249993, cmd is: Cleanup env
Operation failed with exception: Exception('Test plan id: 68b0034e33016fb86d910830, status: FAILED, result: FAILED, Elapsed 121 seconds. Check https://elastictest.org/scheduler/testplan/68b0034e33016fb86d910830 for test plan status')

##[error]Bash exited with code '3'.
Finishing: Prepare Testbed

echuawu · 2025-08-28T08:38:43Z

/azpw run

mssonicbld · 2025-08-28T08:38:46Z

/AzurePipelines run

azure-pipelines · 2025-08-28T08:39:02Z

Azure Pipelines successfully started running 1 pipeline(s).

echuawu · 2025-08-29T11:16:29Z

/azpw run

mssonicbld · 2025-08-29T11:16:32Z

/AzurePipelines run

azure-pipelines · 2025-08-29T11:16:45Z

Azure Pipelines successfully started running 1 pipeline(s).

echuawu · 2025-09-01T08:17:37Z

/azpw run

mssonicbld · 2025-09-01T08:17:40Z

/AzurePipelines run

azure-pipelines · 2025-09-01T08:17:56Z

Azure Pipelines successfully started running 1 pipeline(s).

echuawu · 2025-09-02T02:07:59Z

/azpw run

mssonicbld · 2025-09-02T02:08:02Z

/AzurePipelines run

azure-pipelines · 2025-09-02T02:08:17Z

Azure Pipelines successfully started running 1 pipeline(s).

echuawu · 2025-09-04T02:19:32Z

/azpw run

mssonicbld · 2025-09-04T02:19:34Z

/AzurePipelines run

azure-pipelines · 2025-09-04T02:19:48Z

Azure Pipelines successfully started running 1 pipeline(s).

echuawu · 2025-09-10T04:51:37Z

/azpw run

mssonicbld · 2025-09-10T04:51:40Z

/AzurePipelines run

azure-pipelines · 2025-09-10T04:51:45Z

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

mssonicbld · 2025-09-16T11:00:53Z

/azp run

azure-pipelines · 2025-09-16T11:01:08Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2025-09-18T02:33:51Z

Azure Pipelines successfully started running 1 pipeline(s).

1.Optimize the test cases and use one case to do the two dscp mode test 2.Change the teardown step to a fixture to make sure it must be executed 3.Make sure dscp_to_tc_map is AZURE 4.Add warm reboot action to enhance the test coverage 5.Remove skip condition for mellanox 6.Optimize the packet validation flow which dramatically reduce the execution time 7.Optimize the queue counter check flow to reduce the queue counter check execution time 8.Add port and dscp mode as well as route check to enhance the script debuggability 9.Use completeness_level, by default the script would run warm reboot test if completeness_level had been set as basic, it would skip warm reboot test and the function test after warm reboot action Change-Id: I7c3c49e3b956457c0728468105ae819555992bae

mssonicbld · 2025-09-18T09:11:06Z

/azp run

azure-pipelines · 2025-09-18T09:11:21Z

Azure Pipelines successfully started running 1 pipeline(s).

1.Optimize the test cases and use one case to do the two dscp mode test 2.Change the teardown step to a fixture to make sure it must be executed 3.Make sure dscp_to_tc_map is AZURE 4.Add warm reboot action to enhance the test coverage 5.Remove skip condition for mellanox 6.Optimize the packet validation flow which dramatically reduce the execution time 7.Optimize the queue counter check flow to reduce the queue counter check execution time 8.Add port and dscp mode as well as route check to enhance the script debuggability 9.Use completeness_level, by default the script would run warm reboot test if completeness_level had been set as basic, it would skip warm reboot test and the function test after warm reboot action

1.Optimize the test cases and use one case to do the two dscp mode test 2.Change the teardown step to a fixture to make sure it must be executed 3.Make sure dscp_to_tc_map is AZURE 4.Add warm reboot action to enhance the test coverage 5.Remove skip condition for mellanox 6.Optimize the packet validation flow which dramatically reduce the execution time 7.Optimize the queue counter check flow to reduce the queue counter check execution time 8.Add port and dscp mode as well as route check to enhance the script debuggability 9.Use completeness_level, by default the script would run warm reboot test if completeness_level had been set as basic, it would skip warm reboot test and the function test after warm reboot action Signed-off-by: vikumarks <[email protected]>

1.Optimize the test cases and use one case to do the two dscp mode test 2.Change the teardown step to a fixture to make sure it must be executed 3.Make sure dscp_to_tc_map is AZURE 4.Add warm reboot action to enhance the test coverage 5.Remove skip condition for mellanox 6.Optimize the packet validation flow which dramatically reduce the execution time 7.Optimize the queue counter check flow to reduce the queue counter check execution time 8.Add port and dscp mode as well as route check to enhance the script debuggability 9.Use completeness_level, by default the script would run warm reboot test if completeness_level had been set as basic, it would skip warm reboot test and the function test after warm reboot action Signed-off-by: Alberto Villarreal <[email protected]>

1.Optimize the test cases and use one case to do the two dscp mode test 2.Change the teardown step to a fixture to make sure it must be executed 3.Make sure dscp_to_tc_map is AZURE 4.Add warm reboot action to enhance the test coverage 5.Remove skip condition for mellanox 6.Optimize the packet validation flow which dramatically reduce the execution time 7.Optimize the queue counter check flow to reduce the queue counter check execution time 8.Add port and dscp mode as well as route check to enhance the script debuggability 9.Use completeness_level, by default the script would run warm reboot test if completeness_level had been set as basic, it would skip warm reboot test and the function test after warm reboot action Signed-off-by: opcoder0 <[email protected]>

1.Optimize the test cases and use one case to do the two dscp mode test 2.Change the teardown step to a fixture to make sure it must be executed 3.Make sure dscp_to_tc_map is AZURE 4.Add warm reboot action to enhance the test coverage 5.Remove skip condition for mellanox 6.Optimize the packet validation flow which dramatically reduce the execution time 7.Optimize the queue counter check flow to reduce the queue counter check execution time 8.Add port and dscp mode as well as route check to enhance the script debuggability 9.Use completeness_level, by default the script would run warm reboot test if completeness_level had been set as basic, it would skip warm reboot test and the function test after warm reboot action Signed-off-by: selldinesh <[email protected]>

1.Optimize the test cases and use one case to do the two dscp mode test 2.Change the teardown step to a fixture to make sure it must be executed 3.Make sure dscp_to_tc_map is AZURE 4.Add warm reboot action to enhance the test coverage 5.Remove skip condition for mellanox 6.Optimize the packet validation flow which dramatically reduce the execution time 7.Optimize the queue counter check flow to reduce the queue counter check execution time 8.Add port and dscp mode as well as route check to enhance the script debuggability 9.Use completeness_level, by default the script would run warm reboot test if completeness_level had been set as basic, it would skip warm reboot test and the function test after warm reboot action

1.Optimize the test cases and use one case to do the two dscp mode test 2.Change the teardown step to a fixture to make sure it must be executed 3.Make sure dscp_to_tc_map is AZURE 4.Add warm reboot action to enhance the test coverage 5.Remove skip condition for mellanox 6.Optimize the packet validation flow which dramatically reduce the execution time 7.Optimize the queue counter check flow to reduce the queue counter check execution time 8.Add port and dscp mode as well as route check to enhance the script debuggability 9.Use completeness_level, by default the script would run warm reboot test if completeness_level had been set as basic, it would skip warm reboot test and the function test after warm reboot action Signed-off-by: Saravanan <[email protected]>

1.Optimize the test cases and use one case to do the two dscp mode test 2.Change the teardown step to a fixture to make sure it must be executed 3.Make sure dscp_to_tc_map is AZURE 4.Add warm reboot action to enhance the test coverage 5.Remove skip condition for mellanox 6.Optimize the packet validation flow which dramatically reduce the execution time 7.Optimize the queue counter check flow to reduce the queue counter check execution time 8.Add port and dscp mode as well as route check to enhance the script debuggability 9.Use completeness_level, by default the script would run warm reboot test if completeness_level had been set as basic, it would skip warm reboot test and the function test after warm reboot action Signed-off-by: Guy Shemesh <[email protected]>

1.Optimize the test cases and use one case to do the two dscp mode test 2.Change the teardown step to a fixture to make sure it must be executed 3.Make sure dscp_to_tc_map is AZURE 4.Add warm reboot action to enhance the test coverage 5.Remove skip condition for mellanox 6.Optimize the packet validation flow which dramatically reduce the execution time 7.Optimize the queue counter check flow to reduce the queue counter check execution time 8.Add port and dscp mode as well as route check to enhance the script debuggability 9.Use completeness_level, by default the script would run warm reboot test if completeness_level had been set as basic, it would skip warm reboot test and the function test after warm reboot action Signed-off-by: Aharon Malkin <[email protected]>

1.Optimize the test cases and use one case to do the two dscp mode test 2.Change the teardown step to a fixture to make sure it must be executed 3.Make sure dscp_to_tc_map is AZURE 4.Add warm reboot action to enhance the test coverage 5.Remove skip condition for mellanox 6.Optimize the packet validation flow which dramatically reduce the execution time 7.Optimize the queue counter check flow to reduce the queue counter check execution time 8.Add port and dscp mode as well as route check to enhance the script debuggability 9.Use completeness_level, by default the script would run warm reboot test if completeness_level had been set as basic, it would skip warm reboot test and the function test after warm reboot action Signed-off-by: Guy Shemesh <[email protected]>

1.Optimize the test cases and use one case to do the two dscp mode test 2.Change the teardown step to a fixture to make sure it must be executed 3.Make sure dscp_to_tc_map is AZURE 4.Add warm reboot action to enhance the test coverage 5.Remove skip condition for mellanox 6.Optimize the packet validation flow which dramatically reduce the execution time 7.Optimize the queue counter check flow to reduce the queue counter check execution time 8.Add port and dscp mode as well as route check to enhance the script debuggability 9.Use completeness_level, by default the script would run warm reboot test if completeness_level had been set as basic, it would skip warm reboot test and the function test after warm reboot action

1.Optimize the test cases and use one case to do the two dscp mode test 2.Change the teardown step to a fixture to make sure it must be executed 3.Make sure dscp_to_tc_map is AZURE 4.Add warm reboot action to enhance the test coverage 5.Remove skip condition for mellanox 6.Optimize the packet validation flow which dramatically reduce the execution time 7.Optimize the queue counter check flow to reduce the queue counter check execution time 8.Add port and dscp mode as well as route check to enhance the script debuggability 9.Use completeness_level, by default the script would run warm reboot test if completeness_level had been set as basic, it would skip warm reboot test and the function test after warm reboot action Signed-off-by: YiFan Wang <[email protected]>

1.Optimize the test cases and use one case to do the two dscp mode test 2.Change the teardown step to a fixture to make sure it must be executed 3.Make sure dscp_to_tc_map is AZURE 4.Add warm reboot action to enhance the test coverage 5.Remove skip condition for mellanox 6.Optimize the packet validation flow which dramatically reduce the execution time 7.Optimize the queue counter check flow to reduce the queue counter check execution time 8.Add port and dscp mode as well as route check to enhance the script debuggability 9.Use completeness_level, by default the script would run warm reboot test if completeness_level had been set as basic, it would skip warm reboot test and the function test after warm reboot action Signed-off-by: Guy Shemesh <[email protected]>

1.Optimize the test cases and use one case to do the two dscp mode test 2.Change the teardown step to a fixture to make sure it must be executed 3.Make sure dscp_to_tc_map is AZURE 4.Add warm reboot action to enhance the test coverage 5.Remove skip condition for mellanox 6.Optimize the packet validation flow which dramatically reduce the execution time 7.Optimize the queue counter check flow to reduce the queue counter check execution time 8.Add port and dscp mode as well as route check to enhance the script debuggability 9.Use completeness_level, by default the script would run warm reboot test if completeness_level had been set as basic, it would skip warm reboot test and the function test after warm reboot action Signed-off-by: Lakshmi Yarramaneni <[email protected]>

1.Optimize the test cases and use one case to do the two dscp mode test 2.Change the teardown step to a fixture to make sure it must be executed 3.Make sure dscp_to_tc_map is AZURE 4.Add warm reboot action to enhance the test coverage 5.Remove skip condition for mellanox 6.Optimize the packet validation flow which dramatically reduce the execution time 7.Optimize the queue counter check flow to reduce the queue counter check execution time 8.Add port and dscp mode as well as route check to enhance the script debuggability 9.Use completeness_level, by default the script would run warm reboot test if completeness_level had been set as basic, it would skip warm reboot test and the function test after warm reboot action

1.Optimize the test cases and use one case to do the two dscp mode test 2.Change the teardown step to a fixture to make sure it must be executed 3.Make sure dscp_to_tc_map is AZURE 4.Add warm reboot action to enhance the test coverage 5.Remove skip condition for mellanox 6.Optimize the packet validation flow which dramatically reduce the execution time 7.Optimize the queue counter check flow to reduce the queue counter check execution time 8.Add port and dscp mode as well as route check to enhance the script debuggability 9.Use completeness_level, by default the script would run warm reboot test if completeness_level had been set as basic, it would skip warm reboot test and the function test after warm reboot action Signed-off-by: Yael Tzur <[email protected]>

1.Optimize the test cases and use one case to do the two dscp mode test 2.Change the teardown step to a fixture to make sure it must be executed 3.Make sure dscp_to_tc_map is AZURE 4.Add warm reboot action to enhance the test coverage 5.Remove skip condition for mellanox 6.Optimize the packet validation flow which dramatically reduce the execution time 7.Optimize the queue counter check flow to reduce the queue counter check execution time 8.Add port and dscp mode as well as route check to enhance the script debuggability 9.Use completeness_level, by default the script would run warm reboot test if completeness_level had been set as basic, it would skip warm reboot test and the function test after warm reboot action

1.Optimize the test cases and use one case to do the two dscp mode test 2.Change the teardown step to a fixture to make sure it must be executed 3.Make sure dscp_to_tc_map is AZURE 4.Add warm reboot action to enhance the test coverage 5.Remove skip condition for mellanox 6.Optimize the packet validation flow which dramatically reduce the execution time 7.Optimize the queue counter check flow to reduce the queue counter check execution time 8.Add port and dscp mode as well as route check to enhance the script debuggability 9.Use completeness_level, by default the script would run warm reboot test if completeness_level had been set as basic, it would skip warm reboot test and the function test after warm reboot action Signed-off-by: Raghavendran Ramanathan <[email protected]>

echuawu requested a review from wangxin as a code owner August 28, 2025 03:00

echuawu force-pushed the qos_remap_update branch from 53393f4 to d3f6e9e Compare August 28, 2025 07:15

nhe-NV approved these changes Aug 29, 2025

View reviewed changes

echuawu force-pushed the qos_remap_update branch from d3f6e9e to 9029a05 Compare September 16, 2025 11:00

echuawu force-pushed the qos_remap_update branch from 9029a05 to d6d4d05 Compare September 18, 2025 02:33

echuawu force-pushed the qos_remap_update branch from d6d4d05 to 3740c26 Compare September 18, 2025 09:11

prabhataravind requested a review from kperumalbfn October 14, 2025 21:00

roy-sror approved these changes Oct 28, 2025

View reviewed changes

roy-sror merged commit 2a9038d into sonic-net:master Oct 28, 2025
19 checks passed

dhanasekar-arista mentioned this pull request Jan 20, 2026

Regression: test_qos_dscp_mapping.py fails on Broadcom platforms #21985

Closed

dhanasekar-arista mentioned this pull request Feb 2, 2026

Skip Update of Switch level DSCP->TC map #22215

Merged

12 tasks

mssonicbld mentioned this pull request Mar 5, 2026

[action] [PR:22215] Skip Update of Switch level DSCP->TC map #22745

Merged

12 tasks

Conversation

echuawu commented Aug 28, 2025

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

mssonicbld commented Aug 28, 2025

Uh oh!

azure-pipelines bot commented Aug 28, 2025

Uh oh!

mssonicbld commented Aug 28, 2025

Uh oh!

azure-pipelines bot commented Aug 28, 2025

Uh oh!

echuawu commented Aug 28, 2025

Uh oh!

echuawu commented Aug 28, 2025

Uh oh!

mssonicbld commented Aug 28, 2025

Uh oh!

azure-pipelines bot commented Aug 28, 2025

Uh oh!

echuawu commented Aug 29, 2025

Uh oh!

mssonicbld commented Aug 29, 2025

Uh oh!

azure-pipelines bot commented Aug 29, 2025

Uh oh!

echuawu commented Sep 1, 2025

Uh oh!

mssonicbld commented Sep 1, 2025

Uh oh!

azure-pipelines bot commented Sep 1, 2025

Uh oh!

echuawu commented Sep 2, 2025

Uh oh!

mssonicbld commented Sep 2, 2025

Uh oh!

azure-pipelines bot commented Sep 2, 2025

Uh oh!

echuawu commented Sep 4, 2025

Uh oh!

mssonicbld commented Sep 4, 2025

Uh oh!

azure-pipelines bot commented Sep 4, 2025

Uh oh!

echuawu commented Sep 10, 2025

Uh oh!

mssonicbld commented Sep 10, 2025

Uh oh!

azure-pipelines bot commented Sep 10, 2025

Uh oh!

mssonicbld commented Sep 16, 2025

Uh oh!

azure-pipelines bot commented Sep 16, 2025

Uh oh!

azure-pipelines bot commented Sep 18, 2025

Uh oh!

mssonicbld commented Sep 18, 2025

Uh oh!

azure-pipelines bot commented Sep 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants