Qos_yaml_updated for j2C+_topo-t2_single_node_max and min_wrt_PR23709#20393
Closed
ansrajpu-git wants to merge 1 commit intosonic-net:masterfrom
Closed
Qos_yaml_updated for j2C+_topo-t2_single_node_max and min_wrt_PR23709#20393ansrajpu-git wants to merge 1 commit intosonic-net:masterfrom
ansrajpu-git wants to merge 1 commit intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@vmittal-msft , please review |
vmittal-msft
approved these changes
Aug 25, 2025
Contributor
Contributor
|
@ansrajpu-git please rebase |
|
@kenneth-arista please quickly check |
Contributor
|
If the values in this PR were calculated for PR 23709 then we should not merge this PR. sonic-net/sonic-buildimage#23709 was abandoned in favor of sonic-net/sonic-buildimage#23848 which I already updated MGMT for over here: #20806 23848 and 20806 have both merged already, I believe this is the cause for your branch's conflicts @vmittal-msft I don't think we should approve these changes |
Contributor
Author
|
@peterbailey-arista, I agree with you & this PR should not be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Qos_yaml_updated for j2C+_topo-t2_single_node_max and topo-t2_single_node_min with respect to PR #sonic-net/sonic-buildimage#23709
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Change in cable length & headroom size for UT2 & LT2 PR #23709
How did you do it?
How did you verify/test it?
Executed sonic-mgmt qos tests with 30m cable length profile
Any platform specific information?
Supported testbed topology if it's a new test case?
This PR is dependent on PR -sonic-net/sonic-buildimage#23709
Documentation