[syslog] Add wait_until to syslog test to stabilize kvm runners#2027
Merged
daall merged 2 commits intosonic-net:masterfrom Aug 5, 2020
Merged
[syslog] Add wait_until to syslog test to stabilize kvm runners#2027daall merged 2 commits intosonic-net:masterfrom
daall merged 2 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Danny Allen <[email protected]>
yxieca
approved these changes
Aug 5, 2020
lguohan
approved these changes
Aug 5, 2020
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…atically (sonic-net#15835) src/sonic-utilities * bc7c7929 - (HEAD -> 202205, origin/202205) Add FEC correctable and uncorrectable port stats (sonic-net#2027) (10 hours ago) [Prince George] * 58db48ad - [show][muxcable] update `show mux tunnel-route` to check soc_ipv6 as well (10 hours ago) [Jing Zhang] * 24fc1db8 - [dualtor][route_check] filter out `soc_ipv6` (sonic-net#2899) (10 hours ago) [Jing Zhang] * d89d4832 - [route_check][dualtor] Ignore vlan neighbor route miss (sonic-net#2888) (10 hours ago) [Longxiang Lyu]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Danny Allen [email protected]
Description of PR
Summary: Add
wait_untilto syslog test to even out instabilities running the test in a virtual PR environment.Fixes #1998
Type of change
Approach
What is the motivation for this PR?
We noticed that the syslog test occasionally fails the PR tests, but rarely ever on physical switches. We think the discrepancy is because the shared kvm environment that the PR tests is quite a bit noisier and slower than the physical test environment, so we may need to wait longer for the syslog to populate.
How did you do it?
I used
wait_untilto poll for the syslog message rather than checking immediately after the log message is written.In addition, I also added a
wait_untilto the test initialization to speed things along when the syslog service restarts in <30s.I also fixed the
pep8warnings that popped up in my dev environment.How did you verify/test it?
Ran the test locally on my virtual switch and on a physical DUT.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation