PR contain changes in arpall.yml and swap_syncd.yml #2021
Merged
abdosi merged 1 commit intosonic-net:201811from Aug 4, 2020
Merged
PR contain changes in arpall.yml and swap_syncd.yml #2021abdosi merged 1 commit intosonic-net:201811from
abdosi merged 1 commit intosonic-net:201811from
Conversation
a) Instead of teamdctl to add/remove port-channel member we shoudl config port-channel command. Reason being show interface status does not get updated as teadctl bypass config db b) One of change done by me as prt of PR sonic-net#1893 was not complete as I forgot to update Buffer size in swap_syncd.yml. Fixed now. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
prsunny
approved these changes
Aug 4, 2020
| sysctl: | ||
| name: "net.core.rmem_max" | ||
| value: 509430500 | ||
| value: 609430500 |
Contributor
There was a problem hiding this comment.
It is always better to keep the PRs separate. Just in case we want to revert a PR, it will be easy then.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following changes are being done via this PR:
a) Instead of teamdctl to add/remove port-channel member
we should use config port-channel command. Reason being show interface
status does not get updated as teamdctl bypass config db. Same change is is master already.
More information present here PR:sonic-net/sonic-utilities#1026
b) One of change done by me as part of PR# #1893
was not complete as I forgot to update Buffer size in swap_syncd.yml. Fixed now.