Skip to content

skip test_gcu_acl_dhcp_rule_creation for isolated topology#20187

Merged
StormLiangMS merged 1 commit intosonic-net:masterfrom
sdszhang:skip_gcu_dhcp
Aug 13, 2025
Merged

skip test_gcu_acl_dhcp_rule_creation for isolated topology#20187
StormLiangMS merged 1 commit intosonic-net:masterfrom
sdszhang:skip_gcu_dhcp

Conversation

@sdszhang
Copy link
Contributor

Description of PR

Summary:
DHCP relay feature is not enabled in t0-isolated topology. Skip it as it's not supported.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Approach

What is the motivation for this PR?

Skip DHCP test case in test_dynamic_acl.py

How did you do it?

skip it in conditional marker.

How did you verify/test it?

run in local test testbed.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sdszhang
Copy link
Contributor Author

generic_config_updater/test_dynamic_acl.py::test_gcu_acl_arp_rule_creation[IPV4-xxx-None-default-Vlan1000] PASSED [  7%]
generic_config_updater/test_dynamic_acl.py::test_gcu_acl_arp_rule_creation[IPV6-xxx-None-default-Vlan1000] PASSED [ 15%]
generic_config_updater/test_dynamic_acl.py::test_gcu_acl_forward_rule_removal[default-Vlan1000-IPV6] PASSED [ 23%]
generic_config_updater/test_dynamic_acl.py::test_gcu_acl_dhcp_rule_creation[default-Vlan1000] SKIPPED [ 30%]
generic_config_updater/test_dynamic_acl.py::test_gcu_acl_drop_rule_creation[default-Vlan1000] PASSED [ 38%]
generic_config_updater/test_dynamic_acl.py::test_gcu_acl_drop_rule_removal[default-Vlan1000] PASSED [ 46%]
generic_config_updater/test_dynamic_acl.py::test_gcu_acl_forward_rule_priority_respected[default-Vlan1000] PASSED [ 53%]
generic_config_updater/test_dynamic_acl.py::test_gcu_acl_forward_rule_same_priority[default-Vlan1000] PASSED [ 61%]
generic_config_updater/test_dynamic_acl.py::test_gcu_acl_forward_rule_replacement[default-Vlan1000] PASSED [ 69%]
generic_config_updater/test_dynamic_acl.py::test_gcu_acl_forward_rule_removal[default-Vlan1000-IPV4] PASSED [ 76%]
generic_config_updater/test_dynamic_acl.py::test_gcu_acl_scale_rules[default-Vlan1000] PASSED [ 84%]
generic_config_updater/test_dynamic_acl.py::test_gcu_acl_nonexistent_rule_replacement[default-Vlan1000] PASSED [ 92%]
generic_config_updater/test_dynamic_acl.py::test_gcu_acl_nonexistent_table_removal[default-Vlan1000] PASSED [100%]DEBUG:tests.conftest:[log_custom_msg] item: <Function test_gcu_acl_nonexistent_table_removal[default-Vlan1000]>
INFO:root:Can not get Allure report URL. Please check logs


=============================== warnings summary ===============================
../../../usr/local/lib/python3.8/dist-packages/paramiko/transport.py:236
  /usr/local/lib/python3.8/dist-packages/paramiko/transport.py:236: CryptographyDeprecationWarning: Blowfish has been deprecated
    "class": algorithms.Blowfish,

generic_config_updater/test_dynamic_acl.py: 102 warnings
  /usr/local/lib/python3.8/dist-packages/ptf/mask.py:69: DeprecationWarning: "set_do_not_care_scapy" is going to be deprecated, please switch to the new one: "set_do_not_care_packet"
    warnings.warn(

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
- generated xml file: /data/sonic-mgmt-int-th5/tests/logs/generic_config_updater/test_dynamic_acl.xml -
=========================== short test summary info ============================
SKIPPED [1] generic_config_updater/test_dynamic_acl.py: DHCP is not enabled in isolated topo
=========== 12 passed, 1 skipped, 103 warnings in 1296.87s (0:21:36) ===========

Copy link
Collaborator

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StormLiangMS StormLiangMS merged commit 6a39646 into sonic-net:master Aug 13, 2025
22 checks passed
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to msft-202412: Azure/sonic-mgmt.msft#650

mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Aug 14, 2025
…#20187)

What is the motivation for this PR?
Skip DHCP test case in test_dynamic_acl.py

How did you do it?
skip it in conditional marker.

How did you verify/test it?
run in local test testbed.
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202505: #20237

mssonicbld pushed a commit that referenced this pull request Aug 16, 2025
What is the motivation for this PR?
Skip DHCP test case in test_dynamic_acl.py

How did you do it?
skip it in conditional marker.

How did you verify/test it?
run in local test testbed.
nikamirrr pushed a commit to nikamirrr/nmirin-sonic-mgmt that referenced this pull request Aug 20, 2025
…#20187)

What is the motivation for this PR?
Skip DHCP test case in test_dynamic_acl.py

How did you do it?
skip it in conditional marker.

How did you verify/test it?
run in local test testbed.
@sdszhang sdszhang deleted the skip_gcu_dhcp branch September 13, 2025 10:22
vidyac86 pushed a commit to vidyac86/sonic-mgmt that referenced this pull request Oct 23, 2025
…#20187)

What is the motivation for this PR?
Skip DHCP test case in test_dynamic_acl.py

How did you do it?
skip it in conditional marker.

How did you verify/test it?
run in local test testbed.
opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025
…#20187)

What is the motivation for this PR?
Skip DHCP test case in test_dynamic_acl.py

How did you do it?
skip it in conditional marker.

How did you verify/test it?
run in local test testbed.

Signed-off-by: opcoder0 <[email protected]>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 16, 2025
…#20187)

What is the motivation for this PR?
Skip DHCP test case in test_dynamic_acl.py

How did you do it?
skip it in conditional marker.

How did you verify/test it?
run in local test testbed.

Signed-off-by: Guy Shemesh <[email protected]>
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Dec 16, 2025
…#20187)

What is the motivation for this PR?
Skip DHCP test case in test_dynamic_acl.py

How did you do it?
skip it in conditional marker.

How did you verify/test it?
run in local test testbed.

Signed-off-by: Aharon Malkin <[email protected]>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
…#20187)

What is the motivation for this PR?
Skip DHCP test case in test_dynamic_acl.py

How did you do it?
skip it in conditional marker.

How did you verify/test it?
run in local test testbed.

Signed-off-by: Guy Shemesh <[email protected]>
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Jan 13, 2026
…#20187)

What is the motivation for this PR?
Skip DHCP test case in test_dynamic_acl.py

How did you do it?
skip it in conditional marker.

How did you verify/test it?
run in local test testbed.
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026
…#20187)

What is the motivation for this PR?
Skip DHCP test case in test_dynamic_acl.py

How did you do it?
skip it in conditional marker.

How did you verify/test it?
run in local test testbed.

Signed-off-by: Guy Shemesh <[email protected]>
ytzur1 pushed a commit to ytzur1/sonic-mgmt that referenced this pull request Feb 2, 2026
…#20187)

What is the motivation for this PR?
Skip DHCP test case in test_dynamic_acl.py

How did you do it?
skip it in conditional marker.

How did you verify/test it?
run in local test testbed.

Signed-off-by: Yael Tzur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants