Skip to content

skip warm reboot for pfcwd on isolated topology.#20169

Merged
StormLiangMS merged 1 commit intosonic-net:masterfrom
sdszhang:skip_pfcwd_warmreboot
Aug 13, 2025
Merged

skip warm reboot for pfcwd on isolated topology.#20169
StormLiangMS merged 1 commit intosonic-net:masterfrom
sdszhang:skip_pfcwd_warmreboot

Conversation

@sdszhang
Copy link
Contributor

@sdszhang sdszhang commented Aug 10, 2025

Description of PR

Summary:
warm reboot is not supported in isolated topology. change the skip condition to cover both 202412 and 202505 branch.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Approach

What is the motivation for this PR?

skip warm reboot test cases for pfcwd

How did you do it?

skip it with conditional mark

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sdszhang sdszhang requested a review from r12f August 10, 2025 11:09
@sdszhang
Copy link
Contributor Author

test result:

=========================== short test summary info ============================
SKIPPED [3] pfcwd/test_pfcwd_warm_reboot.py: Warm Reboot is not supported in T2 or in standalone topos. / Pfcwd tests skipped on M* testbed. / Warm reboot is not required for isolated topo / Pfcwd warm reboot is not supported on cisco-8000 platform.
======================== 3 skipped, 1 warning in 39.74s ========================

@sdszhang
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sdszhang
Copy link
Contributor Author

cherry-pick PR to 202412: Azure/sonic-mgmt.msft#645

r12f pushed a commit to Azure/sonic-mgmt.msft that referenced this pull request Aug 12, 2025
cherry-pick sonic-net/sonic-mgmt#20169 to 202412
branch.

<!--
Please make sure you've read and understood our contributing guidelines;
https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md

Please provide following information to help code review process a bit
easier:
-->
### Description of PR
<!--
- Please include a summary of the change and which issue is fixed.
- Please also include relevant motivation and context. Where should
reviewer start? background context?
- List any dependencies that are required for this change.
-->

Summary:
warm reboot is not supported in isolated topology. change the skip
condition to cover both 202412 and 202505 branch.

### Type of change

<!--
- Fill x for your type of change.
- e.g.
- [x] Bug fix
-->

- [ ] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [ ] New Test case
    - [ ] Skipped for non-supported platforms
- [ ] Test case improvement


### Back port request
- [ ] 202205
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [ ] 202411
- [ ] 202505

### Approach
#### What is the motivation for this PR?
skip warm reboot test cases for pfcwd

#### How did you do it?
skip it with conditional mark

#### How did you verify/test it?

#### Any platform specific information?

#### Supported testbed topology if it's a new test case?

### Documentation
<!--
(If it's a new feature, new test case)
Did you update documentation/Wiki relevant to your implementation?
Link to the wiki page?
-->
Copy link
Collaborator

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StormLiangMS StormLiangMS merged commit 542d261 into sonic-net:master Aug 13, 2025
26 checks passed
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to msft-202412:

mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Aug 14, 2025
What is the motivation for this PR?
skip warm reboot test cases for pfcwd

How did you do it?
skip it with conditional mark
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202505: #20241

mssonicbld pushed a commit that referenced this pull request Aug 17, 2025
What is the motivation for this PR?
skip warm reboot test cases for pfcwd

How did you do it?
skip it with conditional mark
nikamirrr pushed a commit to nikamirrr/nmirin-sonic-mgmt that referenced this pull request Aug 20, 2025
What is the motivation for this PR?
skip warm reboot test cases for pfcwd

How did you do it?
skip it with conditional mark
@sdszhang sdszhang deleted the skip_pfcwd_warmreboot branch September 13, 2025 10:22
vidyac86 pushed a commit to vidyac86/sonic-mgmt that referenced this pull request Oct 23, 2025
What is the motivation for this PR?
skip warm reboot test cases for pfcwd

How did you do it?
skip it with conditional mark
opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025
What is the motivation for this PR?
skip warm reboot test cases for pfcwd

How did you do it?
skip it with conditional mark

Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 16, 2025
What is the motivation for this PR?
skip warm reboot test cases for pfcwd

How did you do it?
skip it with conditional mark

Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Dec 16, 2025
What is the motivation for this PR?
skip warm reboot test cases for pfcwd

How did you do it?
skip it with conditional mark

Signed-off-by: Aharon Malkin <amalkin@nvidia.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
What is the motivation for this PR?
skip warm reboot test cases for pfcwd

How did you do it?
skip it with conditional mark

Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Jan 13, 2026
What is the motivation for this PR?
skip warm reboot test cases for pfcwd

How did you do it?
skip it with conditional mark
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026
What is the motivation for this PR?
skip warm reboot test cases for pfcwd

How did you do it?
skip it with conditional mark

Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
ytzur1 pushed a commit to ytzur1/sonic-mgmt that referenced this pull request Feb 2, 2026
What is the motivation for this PR?
skip warm reboot test cases for pfcwd

How did you do it?
skip it with conditional mark

Signed-off-by: Yael Tzur <ytzur@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants