Skip to content

[action] [PR:19989] Check for comments in sai.profile lines in the test_link_local_ip.py#20142

Merged
mssonicbld merged 1 commit intosonic-net:202505from
mssonicbld:cherry/202505/19989
Aug 8, 2025
Merged

[action] [PR:19989] Check for comments in sai.profile lines in the test_link_local_ip.py#20142
mssonicbld merged 1 commit intosonic-net:202505from
mssonicbld:cherry/202505/19989

Conversation

@mssonicbld
Copy link
Copy Markdown
Collaborator

Description of PR

Summary:
The issue is the loop at:

 sai_profile = "/usr/share/sonic/device/{}/{}/sai.profile".format(platform, hwsku)
 for line in duthost.command("cat %s" % sai_profile)["stdout_lines"]:
 key, value = line.split("=")
 sai_settings[key] = value

The check in line.split() fails if there is a comment line in the sai.profile. This PR updates the loop to ignore the comment lines and lines without a = sign.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
  • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Approach

What is the motivation for this PR?

Pls see the description.

…onic-net#19989)

* Check the sai.profile lines for comments.

* Add to check for space before the # sign.
@mssonicbld
Copy link
Copy Markdown
Collaborator Author

Original PR: #19989

@mssonicbld
Copy link
Copy Markdown
Collaborator Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld mssonicbld merged commit 53c2e2b into sonic-net:202505 Aug 8, 2025
12 checks passed
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
Signed-off-by: Nazarii Hnydyn nazariig@nvidia.com

A new SKU for MSN4600C platform: Mellanox-SN4600C-D24C52

Requirements for Mellanox-SN4600C-D24C52:

8 x 100Gbps uplink to T2 switch (C25, C26, C29-C30, C33-C34, C37-C38)
12 x 100Gbps downlinks to T0 switch (C1-C2, C3-C4, C7-C8, C53-C54, C57-C58, C63-C64)
1 x 50Gbps downlinks to T0 switch (D62)
Type of transceiver: "100Gb AOC between T0-T1, 100G DAC between T0-Server"
Cable length: “T0-T1 40m default, 300m max; T0-Server 2m”
Breakout mode: "per port layout"
FEC mode: "none"
VxLAN source port: "no"
Static Policy Based Hashing: "no"
Traditional buffer model: "yes"
Shared headroom: “yes”
Over-subscription ratio: “2”
Warm boot: “yes”
Additional details:

Mellanox-SN4600C-D24C52 is a replacement for Mellanox-SN3800-D24C52
Why I did it
Added Mellanox-SN4600C-D24C52 to replace Mellanox-SN3800-D24C52
Work item tracking
N/A
How I did it
Added relevant configuration files
How to verify it
Generate port configuration:
sonic-cfggen -H -k Mellanox-SN4600C-D24C52 --preset t1 > /etc/sonic/config_db.json
Generate QoS configuration:
config qos clear
config qos reload --no-dynamic-buffer
config save -y
Details if related
Backport from master: [Mellanox]: Add Mellanox-SN4600C-D24C52 SKU sonic-net#20142
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants