Skip to content

[test_snmp_cpu] increase wait time for loading to reflect in SNMP#20116

Merged
StormLiangMS merged 1 commit intosonic-net:masterfrom
Janetxxx:dev/jc/test-snmp-cpu
Aug 11, 2025
Merged

[test_snmp_cpu] increase wait time for loading to reflect in SNMP#20116
StormLiangMS merged 1 commit intosonic-net:masterfrom
Janetxxx:dev/jc/test-snmp-cpu

Conversation

@Janetxxx
Copy link
Copy Markdown
Contributor

@Janetxxx Janetxxx commented Aug 7, 2025

Description of PR

Summary: Increase the timeout since the test drives all 16 cores to 100% for over 20 seconds, which leads to bulk counter timeouts.
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Approach

What is the motivation for this PR?

Increase the timeout since the test drives all 16 cores to 100% for over 20 seconds, which leads to bulk counter timeouts.

How did you do it?

Increase the timeout

How did you verify/test it?

Verified it in the internal tests.

collected 1 item

snmp/test_snmp_cpu.py::test_snmp_cpu[str4-sn5640-3] PASSED               [100%]DEBUG:tests.conftest:[log_custom_msg] item: <Function test_snmp_cpu[str4-sn5640-3]>

Any platform specific information?

str4-sn5640-3

Supported testbed topology if it's a new test case?

t1-isolated-d56u1-lag

Documentation

Signed-off-by: Janetxxx <janet970527@gmail.com>
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@Janetxxx Janetxxx requested review from Pterosaur and r12f August 7, 2025 07:22
@Janetxxx Janetxxx changed the title [test_snmp_cu] increase wait time for loading to reflect in SNMP [test_snmp_cpu] increase wait time for loading to reflect in SNMP Aug 7, 2025
Copy link
Copy Markdown
Collaborator

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, with a minor question: have we considered using 'wait until' instead of a fixed wait time?

@StormLiangMS StormLiangMS merged commit b31ec81 into sonic-net:master Aug 11, 2025
22 checks passed
@mssonicbld
Copy link
Copy Markdown
Collaborator

Cherry-pick PR to msft-202412: Azure/sonic-mgmt.msft#637

mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Aug 11, 2025
…ic-net#20116)

hat is the motivation for this PR?
Increase the timeout since the test drives all 16 cores to 100% for over 20 seconds, which leads to bulk counter timeouts.

How did you do it?
Increase the timeout

How did you verify/test it?
Verified it in the internal tests.

collected 1 item

snmp/test_snmp_cpu.py::test_snmp_cpu[str4-sn5640-3] PASSED               [100%]DEBUG:tests.conftest:[log_custom_msg] item: <Function test_snmp_cpu[str4-sn5640-3]>
Any platform specific information?
str4-sn5640-3

Supported testbed topology if it's a new test case?
t1-isolated-d56u1-lag
@mssonicbld
Copy link
Copy Markdown
Collaborator

Cherry-pick PR to 202505: #20178

mssonicbld pushed a commit that referenced this pull request Aug 11, 2025
)

hat is the motivation for this PR?
Increase the timeout since the test drives all 16 cores to 100% for over 20 seconds, which leads to bulk counter timeouts.

How did you do it?
Increase the timeout

How did you verify/test it?
Verified it in the internal tests.

collected 1 item

snmp/test_snmp_cpu.py::test_snmp_cpu[str4-sn5640-3] PASSED               [100%]DEBUG:tests.conftest:[log_custom_msg] item: <Function test_snmp_cpu[str4-sn5640-3]>
Any platform specific information?
str4-sn5640-3

Supported testbed topology if it's a new test case?
t1-isolated-d56u1-lag
ashutosh-agrawal pushed a commit to ashutosh-agrawal/sonic-mgmt that referenced this pull request Aug 14, 2025
…ic-net#20116)

hat is the motivation for this PR?
Increase the timeout since the test drives all 16 cores to 100% for over 20 seconds, which leads to bulk counter timeouts.

How did you do it?
Increase the timeout

How did you verify/test it?
Verified it in the internal tests.

collected 1 item

snmp/test_snmp_cpu.py::test_snmp_cpu[str4-sn5640-3] PASSED               [100%]DEBUG:tests.conftest:[log_custom_msg] item: <Function test_snmp_cpu[str4-sn5640-3]>
Any platform specific information?
str4-sn5640-3

Supported testbed topology if it's a new test case?
t1-isolated-d56u1-lag
@AharonMalkin
Copy link
Copy Markdown
Contributor

Hey @Janetxxx , the test keeps failing even with the 40 seconds sleep.
I'm afraid that you increased the stress to 40 seconds, and I also tried with 5 seconds, I think that the solution here should be ignoring the log messages for mellanox platforms. What do you think?

vidyac86 pushed a commit to vidyac86/sonic-mgmt that referenced this pull request Oct 23, 2025
…ic-net#20116)

hat is the motivation for this PR?
Increase the timeout since the test drives all 16 cores to 100% for over 20 seconds, which leads to bulk counter timeouts.

How did you do it?
Increase the timeout

How did you verify/test it?
Verified it in the internal tests.

collected 1 item

snmp/test_snmp_cpu.py::test_snmp_cpu[str4-sn5640-3] PASSED               [100%]DEBUG:tests.conftest:[log_custom_msg] item: <Function test_snmp_cpu[str4-sn5640-3]>
Any platform specific information?
str4-sn5640-3

Supported testbed topology if it's a new test case?
t1-isolated-d56u1-lag
opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025
…ic-net#20116)

hat is the motivation for this PR?
Increase the timeout since the test drives all 16 cores to 100% for over 20 seconds, which leads to bulk counter timeouts.

How did you do it?
Increase the timeout

How did you verify/test it?
Verified it in the internal tests.

collected 1 item

snmp/test_snmp_cpu.py::test_snmp_cpu[str4-sn5640-3] PASSED               [100%]DEBUG:tests.conftest:[log_custom_msg] item: <Function test_snmp_cpu[str4-sn5640-3]>
Any platform specific information?
str4-sn5640-3

Supported testbed topology if it's a new test case?
t1-isolated-d56u1-lag

Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 16, 2025
…ic-net#20116)

hat is the motivation for this PR?
Increase the timeout since the test drives all 16 cores to 100% for over 20 seconds, which leads to bulk counter timeouts.

How did you do it?
Increase the timeout

How did you verify/test it?
Verified it in the internal tests.

collected 1 item

snmp/test_snmp_cpu.py::test_snmp_cpu[str4-sn5640-3] PASSED               [100%]DEBUG:tests.conftest:[log_custom_msg] item: <Function test_snmp_cpu[str4-sn5640-3]>
Any platform specific information?
str4-sn5640-3

Supported testbed topology if it's a new test case?
t1-isolated-d56u1-lag

Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Dec 16, 2025
…ic-net#20116)

hat is the motivation for this PR?
Increase the timeout since the test drives all 16 cores to 100% for over 20 seconds, which leads to bulk counter timeouts.

How did you do it?
Increase the timeout

How did you verify/test it?
Verified it in the internal tests.

collected 1 item

snmp/test_snmp_cpu.py::test_snmp_cpu[str4-sn5640-3] PASSED               [100%]DEBUG:tests.conftest:[log_custom_msg] item: <Function test_snmp_cpu[str4-sn5640-3]>
Any platform specific information?
str4-sn5640-3

Supported testbed topology if it's a new test case?
t1-isolated-d56u1-lag

Signed-off-by: Aharon Malkin <amalkin@nvidia.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
…ic-net#20116)

hat is the motivation for this PR?
Increase the timeout since the test drives all 16 cores to 100% for over 20 seconds, which leads to bulk counter timeouts.

How did you do it?
Increase the timeout

How did you verify/test it?
Verified it in the internal tests.

collected 1 item

snmp/test_snmp_cpu.py::test_snmp_cpu[str4-sn5640-3] PASSED               [100%]DEBUG:tests.conftest:[log_custom_msg] item: <Function test_snmp_cpu[str4-sn5640-3]>
Any platform specific information?
str4-sn5640-3

Supported testbed topology if it's a new test case?
t1-isolated-d56u1-lag

Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Jan 13, 2026
…ic-net#20116)

hat is the motivation for this PR?
Increase the timeout since the test drives all 16 cores to 100% for over 20 seconds, which leads to bulk counter timeouts.

How did you do it?
Increase the timeout

How did you verify/test it?
Verified it in the internal tests.

collected 1 item

snmp/test_snmp_cpu.py::test_snmp_cpu[str4-sn5640-3] PASSED               [100%]DEBUG:tests.conftest:[log_custom_msg] item: <Function test_snmp_cpu[str4-sn5640-3]>
Any platform specific information?
str4-sn5640-3

Supported testbed topology if it's a new test case?
t1-isolated-d56u1-lag
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026
…ic-net#20116)

hat is the motivation for this PR?
Increase the timeout since the test drives all 16 cores to 100% for over 20 seconds, which leads to bulk counter timeouts.

How did you do it?
Increase the timeout

How did you verify/test it?
Verified it in the internal tests.

collected 1 item

snmp/test_snmp_cpu.py::test_snmp_cpu[str4-sn5640-3] PASSED               [100%]DEBUG:tests.conftest:[log_custom_msg] item: <Function test_snmp_cpu[str4-sn5640-3]>
Any platform specific information?
str4-sn5640-3

Supported testbed topology if it's a new test case?
t1-isolated-d56u1-lag

Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
ytzur1 pushed a commit to ytzur1/sonic-mgmt that referenced this pull request Feb 2, 2026
…ic-net#20116)

hat is the motivation for this PR?
Increase the timeout since the test drives all 16 cores to 100% for over 20 seconds, which leads to bulk counter timeouts.

How did you do it?
Increase the timeout

How did you verify/test it?
Verified it in the internal tests.

collected 1 item

snmp/test_snmp_cpu.py::test_snmp_cpu[str4-sn5640-3] PASSED               [100%]DEBUG:tests.conftest:[log_custom_msg] item: <Function test_snmp_cpu[str4-sn5640-3]>
Any platform specific information?
str4-sn5640-3

Supported testbed topology if it's a new test case?
t1-isolated-d56u1-lag

Signed-off-by: Yael Tzur <ytzur@nvidia.com>
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Mar 27, 2026
…ic-net#20116)

hat is the motivation for this PR?
Increase the timeout since the test drives all 16 cores to 100% for over 20 seconds, which leads to bulk counter timeouts.

How did you do it?
Increase the timeout

How did you verify/test it?
Verified it in the internal tests.

collected 1 item

snmp/test_snmp_cpu.py::test_snmp_cpu[str4-sn5640-3] PASSED               [100%]DEBUG:tests.conftest:[log_custom_msg] item: <Function test_snmp_cpu[str4-sn5640-3]>
Any platform specific information?
str4-sn5640-3

Supported testbed topology if it's a new test case?
t1-isolated-d56u1-lag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants