Skip to content

Ignore router advertisements in PTF#20113

Merged
wangxin merged 1 commit intosonic-net:masterfrom
saiarcot895:ignore-router-advertisements-in-ptf
Aug 8, 2025
Merged

Ignore router advertisements in PTF#20113
wangxin merged 1 commit intosonic-net:masterfrom
saiarcot895:ignore-router-advertisements-in-ptf

Conversation

@saiarcot895
Copy link
Copy Markdown
Contributor

@saiarcot895 saiarcot895 commented Aug 7, 2025

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Approach

What is the motivation for this PR?

Ignore any router advertisements sent by a DUT, and don't set a default route or an address based on it. This could happen if a T0 testbed with radv running sends router advertisements on a VLAN interface, which may result in the PTF container adding a default route on all of the VLAN interfaces. This could result in some IPv6 test cases breaking.

How did you do it?

Set the net.ipv6.conf.default.accept_ra sysctl to 0 when creating the PTF container. All of the interfaces that get created/moved into the PTF container then inherit this setting.

How did you verify/test it?

Ran add-topo for vms-kvm-t0, and verified that the router advertisements sent by the T0 didn't result in a default route being learned.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@saiarcot895
Ignore router advertisements in PTF
e1a3026 
Ignore any router advertisements sent by a DUT, and don't set a default
route or an address based on it. This could happen if a T0 testbed with
radv running sends router advertisements on a VLAN interface, which may
result in the PTF container adding a default route on all of the VLAN
interfaces. This could result in some IPv6 test cases breaking.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Aug 7, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Aug 7, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@wangxin wangxin merged commit d525ae1 into sonic-net:master Aug 8, 2025
22 checks passed
@saiarcot895 saiarcot895 deleted the ignore-router-advertisements-in-ptf branch August 8, 2025 16:20
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Aug 9, 2025
@saiarcot895 @mssonicbld
Ignore router advertisements in PTF (sonic-net#20113)
d9aaacc 
Ignore any router advertisements sent by a DUT, and don't set a default
route or an address based on it. This could happen if a T0 testbed with
radv running sends router advertisements on a VLAN interface, which may
result in the PTF container adding a default route on all of the VLAN
interfaces. This could result in some IPv6 test cases breaking.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Aug 9, 2025

Cherry-pick PR to 202505: #20165

@mssonicbld mssonicbld mentioned this pull request Aug 9, 2025
Merged
11 tasks
mssonicbld pushed a commit that referenced this pull request Aug 13, 2025
@saiarcot895 @mssonicbld
Ignore router advertisements in PTF (#20113)
b14c17b 
Ignore any router advertisements sent by a DUT, and don't set a default
route or an address based on it. This could happen if a T0 testbed with
radv running sends router advertisements on a VLAN interface, which may
result in the PTF container adding a default route on all of the VLAN
interfaces. This could result in some IPv6 test cases breaking.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
ashutosh-agrawal pushed a commit to ashutosh-agrawal/sonic-mgmt that referenced this pull request Aug 14, 2025
@saiarcot895 @ashutosh-agrawal
Ignore router advertisements in PTF (sonic-net#20113)
e0714e7 
Ignore any router advertisements sent by a DUT, and don't set a default
route or an address based on it. This could happen if a T0 testbed with
radv running sends router advertisements on a VLAN interface, which may
result in the PTF container adding a default route on all of the VLAN
interfaces. This could result in some IPv6 test cases breaking.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
@illia-kotvitskyi illia-kotvitskyi mentioned this pull request Sep 22, 2025
Open
vidyac86 pushed a commit to vidyac86/sonic-mgmt that referenced this pull request Oct 23, 2025
@saiarcot895 @vidyac86
Ignore router advertisements in PTF (sonic-net#20113)
e5ca068 
Ignore any router advertisements sent by a DUT, and don't set a default
route or an address based on it. This could happen if a T0 testbed with
radv running sends router advertisements on a VLAN interface, which may
result in the PTF container adding a default route on all of the VLAN
interfaces. This could result in some IPv6 test cases breaking.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025
@saiarcot895
Ignore router advertisements in PTF (sonic-net#20113)
212cac6 
Ignore any router advertisements sent by a DUT, and don't set a default
route or an address based on it. This could happen if a T0 testbed with
radv running sends router advertisements on a VLAN interface, which may
result in the PTF container adding a default route on all of the VLAN
interfaces. This could result in some IPv6 test cases breaking.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 16, 2025
@saiarcot895 @gshemesh2
Ignore router advertisements in PTF (sonic-net#20113)
f8d320a 
Ignore any router advertisements sent by a DUT, and don't set a default
route or an address based on it. This could happen if a T0 testbed with
radv running sends router advertisements on a VLAN interface, which may
result in the PTF container adding a default route on all of the VLAN
interfaces. This could result in some IPv6 test cases breaking.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Dec 16, 2025
@saiarcot895 @AharonMalkin
Ignore router advertisements in PTF (sonic-net#20113)
c65bcfb 
Ignore any router advertisements sent by a DUT, and don't set a default
route or an address based on it. This could happen if a T0 testbed with
radv running sends router advertisements on a VLAN interface, which may
result in the PTF container adding a default route on all of the VLAN
interfaces. This could result in some IPv6 test cases breaking.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
Signed-off-by: Aharon Malkin <amalkin@nvidia.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
@saiarcot895 @gshemesh2
Ignore router advertisements in PTF (sonic-net#20113)
57f80f0 
Ignore any router advertisements sent by a DUT, and don't set a default
route or an address based on it. This could happen if a T0 testbed with
radv running sends router advertisements on a VLAN interface, which may
result in the PTF container adding a default route on all of the VLAN
interfaces. This could result in some IPv6 test cases breaking.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Jan 13, 2026
@saiarcot895 @venu-nexthop
Ignore router advertisements in PTF (sonic-net#20113)
e9e1b8b 
Ignore any router advertisements sent by a DUT, and don't set a default
route or an address based on it. This could happen if a T0 testbed with
radv running sends router advertisements on a VLAN interface, which may
result in the PTF container adding a default route on all of the VLAN
interfaces. This could result in some IPv6 test cases breaking.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026
@saiarcot895 @gshemesh2
Ignore router advertisements in PTF (sonic-net#20113)
580b7a8 
Ignore any router advertisements sent by a DUT, and don't set a default
route or an address based on it. This could happen if a T0 testbed with
radv running sends router advertisements on a VLAN interface, which may
result in the PTF container adding a default route on all of the VLAN
interfaces. This could result in some IPv6 test cases breaking.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
ytzur1 pushed a commit to ytzur1/sonic-mgmt that referenced this pull request Feb 2, 2026
@saiarcot895 @ytzur1
Ignore router advertisements in PTF (sonic-net#20113)
0bea5a3 
Ignore any router advertisements sent by a DUT, and don't set a default
route or an address based on it. This could happen if a T0 testbed with
radv running sends router advertisements on a VLAN interface, which may
result in the PTF container adding a default route on all of the VLAN
interfaces. This could result in some IPv6 test cases breaking.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
Signed-off-by: Yael Tzur <ytzur@nvidia.com>
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Mar 27, 2026
@saiarcot895
Ignore router advertisements in PTF (sonic-net#20113)
a17e22f 
Ignore any router advertisements sent by a DUT, and don't set a default
route or an address based on it. This could happen if a T0 testbed with
radv running sends router advertisements on a VLAN interface, which may
result in the PTF container adding a default route on all of the VLAN
interfaces. This could result in some IPv6 test cases breaking.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wangxin wangxin wangxin approved these changes

@yxieca yxieca Awaiting requested review from yxieca

Assignees

No one assigned

Labels

Approved for 202505 branch Included in 202505 branch Request for 202411 branch Request for 202505 branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@saiarcot895 @mssonicbld @wangxin @yejianquan