Skip to content

Check for comments in sai.profile lines in the test_link_local_ip.py #19989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevinskwang merged 2 commits into from
Aug 8, 2025
Merged

Check for comments in sai.profile lines in the test_link_local_ip.py #19989

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75de3c4
Check the sai.profile lines for comments.
rraghav-cisco Aug 1, 2025
5b857b5
Add to check for space before the # sign.
rraghav-cisco Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions tests/ip/link_local/test_link_local_ip.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,10 @@ def check_if_test_is_supported(duthost):
sai_settings = {}
sai_profile = "/usr/share/sonic/device/{}/{}/sai.profile".format(platform, hwsku)
for line in duthost.command("cat %s" % sai_profile)["stdout_lines"]:
key, value = line.split("=")
sai_settings[key] = value
if (not re.match("^[ \t]*#", line)) and re.search("=", line):
# line should not a comment, and must contain the "=".
key, value = line.split("=")
sai_settings[key] = value
if int(sai_settings.get("SAI_NOT_DROP_SIP_DIP_LINK_LOCAL", 0)) != 1:
pytest.skip("Test is not supported, SAI_NOT_DROP_SIP_DIP_LINK_LOCAL is not equal 1 or not specified")

Expand Down
Loading