Skip to content

Ignore error during config reload in BGP/QOS/FPC test cases#19869

Merged
bingwang-ms merged 2 commits intosonic-net:masterfrom
liuh-80:dev/liuh/ignore_reload_config_tacacs
Jul 29, 2025
Merged

Ignore error during config reload in BGP/QOS/FPC test cases#19869
bingwang-ms merged 2 commits intosonic-net:masterfrom
liuh-80:dev/liuh/ignore_reload_config_tacacs

Conversation

@liuh-80
Copy link
Copy Markdown
Contributor

@liuh-80 liuh-80 commented Jul 28, 2025

Ignore error during config reload in BGP/QOS/FPC test cases

Why I did it

BGP/QOS/FPC test case failed because following error:
E 2025 Jul 28 04:41:57.469604 str2-msn2700-spy-1 ERR iptables: tac_connect_single: connection to 10.64.246.145:49 failed: Network is unreachable

These test case reload_config but not set ignore_loganalyzer parameter.
Because reload config will restart networking service, which will cause TACACS server unreachable during networking service shutdown.

Work item tracking
  • Microsoft ADO (number only):

How I did it

Set reload_config ignore_loganalyzer parameter in BGP/QOS/FPC test cases.

How to verify it

Pass all test case.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Ignore error during config reload in BGP/QOS/FPC test cases

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@liuh-80 liuh-80 marked this pull request as ready for review July 29, 2025 01:03
@liuh-80 liuh-80 requested a review from StormLiangMS as a code owner July 29, 2025 01:03
@bingwang-ms
Copy link
Copy Markdown
Collaborator

Instead of adding the log pattern for each test cases, can we ignore it globally in https://github.com/sonic-net/sonic-mgmt/blob/master/tests/common/plugins/loganalyzer/loganalyzer_common_ignore.txt ?

@liuh-80
Copy link
Copy Markdown
Contributor Author

liuh-80 commented Jul 29, 2025

Instead of adding the log pattern for each test cases, can we ignore it globally in https://github.com/sonic-net/sonic-mgmt/blob/master/tests/common/plugins/loganalyzer/loganalyzer_common_ignore.txt ?

I warry about add to global list may make us ignore some real issue, can we use this ignore_loganalyzer for now? if there are more similer issue in future we can add to global list.

@bingwang-ms bingwang-ms merged commit aebefaa into sonic-net:master Jul 29, 2025
20 checks passed
@liuh-80 liuh-80 deleted the dev/liuh/ignore_reload_config_tacacs branch July 29, 2025 01:42
@bingwang-ms
Copy link
Copy Markdown
Collaborator

@yejianquan Can you help with cherry-pick? Thanks

@mssonicbld
Copy link
Copy Markdown
Collaborator

@liuh-80 PR conflicts with 202505 branch

@yejianquan
Copy link
Copy Markdown
Collaborator

Hi @liuh-80 , could you fix the conflict and create pr to 202505 branch? Thanks

nissampa pushed a commit to nissampa/sonic-mgmt_dpu_test that referenced this pull request Aug 7, 2025
…t#19869)

* Ignore error during config reload

* Fix format issue

---------

Co-authored-by: sonicbld <sonicbld@microsoft.com>
liuh-80 added a commit to liuh-80/sonic-mgmt that referenced this pull request Aug 12, 2025
…t#19869)

* Ignore error during config reload

* Fix format issue

---------

Co-authored-by: sonicbld <sonicbld@microsoft.com>
@liuh-80
Copy link
Copy Markdown
Contributor Author

liuh-80 commented Aug 12, 2025

Hi @liuh-80 , could you fix the conflict and create pr to 202505 branch? Thanks

202505 PR created: #20198

yejianquan pushed a commit that referenced this pull request Aug 14, 2025
…20198)

Ignore error during config reload in BGP/QOS/FPC test cases
Cherry-pick for #19869

Why I did it
BGP/QOS/FPC test case failed because following error:
E 2025 Jul 28 04:41:57.469604 str2-msn2700-spy-1 ERR iptables: tac_connect_single: connection to 10.64.246.145:49 failed: Network is unreachable

These test case reload_config but not set ignore_loganalyzer parameter.
Because reload config will restart networking service, which will cause TACACS server unreachable during networking service shutdown.

Work item tracking
Microsoft ADO (number only):
How I did it
Set reload_config ignore_loganalyzer parameter in BGP/QOS/FPC test cases.

How to verify it
Pass all test case.

Tested branch (Please provide the tested image version)


Description for the changelog
Ignore error during config reload in BGP/QOS/FPC test cases

co-authorized by: jianquanye@microsoft.com
ashutosh-agrawal pushed a commit to ashutosh-agrawal/sonic-mgmt that referenced this pull request Aug 14, 2025
…t#19869)

* Ignore error during config reload

* Fix format issue

---------

Co-authored-by: sonicbld <sonicbld@microsoft.com>
vidyac86 pushed a commit to vidyac86/sonic-mgmt that referenced this pull request Oct 23, 2025
…t#19869)

* Ignore error during config reload

* Fix format issue

---------

Co-authored-by: sonicbld <sonicbld@microsoft.com>
opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025
…t#19869)

* Ignore error during config reload

* Fix format issue

---------

Co-authored-by: sonicbld <sonicbld@microsoft.com>

Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 16, 2025
…t#19869)

* Ignore error during config reload

* Fix format issue

---------

Co-authored-by: sonicbld <sonicbld@microsoft.com>
Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Dec 16, 2025
…t#19869)

* Ignore error during config reload

* Fix format issue

---------

Co-authored-by: sonicbld <sonicbld@microsoft.com>
Signed-off-by: Aharon Malkin <amalkin@nvidia.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
…t#19869)

* Ignore error during config reload

* Fix format issue

---------

Co-authored-by: sonicbld <sonicbld@microsoft.com>
Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Jan 13, 2026
…t#19869)

* Ignore error during config reload

* Fix format issue

---------

Co-authored-by: sonicbld <sonicbld@microsoft.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026
…t#19869)

* Ignore error during config reload

* Fix format issue

---------

Co-authored-by: sonicbld <sonicbld@microsoft.com>
Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
ytzur1 pushed a commit to ytzur1/sonic-mgmt that referenced this pull request Feb 2, 2026
…t#19869)

* Ignore error during config reload

* Fix format issue

---------

Co-authored-by: sonicbld <sonicbld@microsoft.com>
Signed-off-by: Yael Tzur <ytzur@nvidia.com>
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Mar 27, 2026
…t#19869)

* Ignore error during config reload

* Fix format issue

---------

Co-authored-by: sonicbld <sonicbld@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants