Skip to content

[pytest]: Fail WR ARP test earlier with empty DIP #1986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
theasianpianist merged 2 commits into from
Jul 29, 2020
Merged

[pytest]: Fail WR ARP test earlier with empty DIP #1986

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc0e64b
[pytest]: Fail WR ARP test earlier with empty DIP
theasianpianist Jul 28, 2020
2fc1f96
[pytest]: Remove redundant assert in arp/test_wr_arp.py
theasianpianist Jul 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tests/arp/test_wr_arp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import logging
import pytest

from tests.common.helpers.assertions import pytest_assert
from tests.common.fixtures.ptfhost_utils import copy_ptftests_directory # lgtm[py/unused-import]
from tests.common.fixtures.ptfhost_utils import change_mac_addresses # lgtm[py/unused-import]
from tests.common.platform.ssh_utils import prepare_testbed_ssh_keys as prepareTestbedSshKeys
Expand Down Expand Up @@ -97,7 +98,8 @@ def setupFerret(self, duthost, ptfhost):
sed -ne 's/0\/.*$/1/p'
'''
)
assert len(result['stderr_lines']) == 0, 'Could not obtain DIP'

pytest_assert(len(result['stdout'].strip()) > 0, 'Empty DIP returned')

dip = result['stdout']
logger.info('VxLan Sender {0}'.format(dip))
Expand Down