Skip to content

Generate minigraph with default ansible_hostv6 #1983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yxieca merged 1 commit into from
Aug 1, 2020
Merged

Generate minigraph with default ansible_hostv6 #1983

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ansible/templates/minigraph_dpg.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@
<Name>V6HostIP</Name>
<AttachTo>eth0</AttachTo>
<a:Prefix xmlns:b="Microsoft.Search.Autopilot.Evolution">
<b:IPPrefix>{{ ansible_hostv6 }}/64</b:IPPrefix>
<b:IPPrefix>{{ ansible_hostv6 if ansible_hostv6 is defined else 'FC00:2::32' }}/64</b:IPPrefix>
</a:Prefix>
<a:PrefixStr>{{ ansible_hostv6 }}/64</a:PrefixStr>
<a:PrefixStr>{{ ansible_hostv6 if ansible_hostv6 is defined else 'FC00:2::32' }}/64</a:PrefixStr>
Copy link
Contributor

@lguohan lguohan Jul 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to be aware that if ansible_hostv6 is not defined, then tacacs v6 test will fail?

Copy link
Contributor

@lguohan lguohan Jul 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SuvarnaMeenakshi , can you answer this question? If yes, then how do we know whether we should run tacacs v6 test case or not?

Copy link
Contributor

@msosyak msosyak Jul 28, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lguohan As I understand from the "How did you verify/test it?" section the issue is actually during deploy-mg command. The template failed if ansible_hostv6 is not defined for the testbed.

Copy link
Contributor

@SuvarnaMeenakshi SuvarnaMeenakshi Jul 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, we check if ptf has IPv6 address assigned or not. If ptf does not have IPv6 address assigned, then tacacs ipv6 test case will be skipped.
If ptf has IPv6 assigned and minigraph does not have IPv6, tacacs ipv6 will be executed, and it will fail.
Should we have additional check to see if both ptf and DUT has IPv6 configured, only then execute tacacs ipv6 test?

Copy link
Contributor Author

@NazarTkachuk NazarTkachuk Jul 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for my 2 cents, I suppose we need to have backward compatibility, run deploy-mg with/without ansible_hostv6 definition

Copy link
Contributor

@lguohan lguohan Jul 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NazarTkachuk , I am trying understand what else changes we need so that we are not breaking the tacacs v6 test.

Copy link
Contributor

@lguohan lguohan Jul 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SuvarnaMeenakshi , in this case, the dut will have ipv6 address. How do you check?

Copy link
Contributor

@SuvarnaMeenakshi SuvarnaMeenakshi Jul 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lguohan, that is right, we will have IPv6 address in this case, can think of 2 options: 1. Expect that if PTF docker has IPv6 address, then the DUT has IPv6 address reachable from ptf docker – If that is the case, then current implementation is good.
2. Specifically check for the default IPv6 address given to DUT here, if it is the default address, then skip IPv6 tacacs test. This does not seem clean as it is specific check for address: 'FC00:2::32'.

Copy link
Contributor

@lguohan lguohan Jul 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we change the default v6 address on DUT a IPv6 address that is reachable to the ptf docker?

Copy link
Contributor

@SuvarnaMeenakshi SuvarnaMeenakshi Aug 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lguohan We could do that for VS testbed, if ptf-docker IP address is taken from a specific lab network, then we cannot generate a default reachable IPv6 address for DUT.

</a:ManagementIPInterface>
</ManagementIPInterfaces>
<ManagementVIPInterfaces xmlns:a="http://schemas.datacontract.org/2004/07/Microsoft.Search.Autopilot.Evolution"/>
Expand Down