Skip to content

[action] [PR:19463] Remove policer for MIRROR_SESSION creation on TH5 platform#19777

Merged
mssonicbld merged 1 commit intosonic-net:202505from
mssonicbld:cherry/202505/19463
Jul 23, 2025
Merged

[action] [PR:19463] Remove policer for MIRROR_SESSION creation on TH5 platform#19777
mssonicbld merged 1 commit intosonic-net:202505from
mssonicbld:cherry/202505/19463

Conversation

@mssonicbld
Copy link
Copy Markdown
Collaborator

Description of PR

Summary:
Fixes # (issue)
To fix generic_config_updater/test_monitor_config.py::test_monitor_config_tc1_suite failure on 202412 due to policer not supported for MIRROR_SESSION creation on TH5 platform.

E 2025 Jul 4 23:42:18.666920 str4-7060x6-512-1 ERR syncd#syncd: [none] SAI_API_MIRROR:_brcm_sai_create_mirror_session:2437 Platform does not support SAI_MIRROR_SESSION_ATTR_POLICER.
E 
E 2025 Jul 4 23:42:18.666929 str4-7060x6-512-1 ERR syncd#syncd: [none] SAI_API_MIRROR:_brcm_sai_create_mirror_session:2523 Error processing mirror attributes

MSADO: 33479806

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
  • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202412
  • 202505

Approach

What is the motivation for this PR?

Fix generic_config_updater/test_monitor_config.py::test_monitor_config_tc1_suite failure on 202412 due to policer not supported for MIRROR_SESSION creation on TH5 platform as Broadcom clarified it in CS00012412189: [TH5-512]Error log "Platform does not support SAI_MIRROR_SESSION_ATTR_POLICER".

How did you do it?

Check the platform before building and verifying monitor session config, remove the policer if platform startwith "x86_64-arista_7060x6_64pe".

How did you verify/test it?

Run generic_config_updater/test_monitor_config.py::test_monitor_config_tc1_suite locally on 7060x6 and it passed.

generic_config_updater/test_monitor_config.py::test_monitor_config_tc1_suite PASSED [100%]

Signed-off-by: zitingguo-ms zitingguo@microsoft.com

…#19463)

What is the motivation for this PR?
Fix generic_config_updater/test_monitor_config.py::test_monitor_config_tc1_suite failure on 202412 due to policer not supported for MIRROR_SESSION creation on TH5 platform as Broadcom clarified it in CS00012412189: [TH5-512]Error log "Platform does not support SAI_MIRROR_SESSION_ATTR_POLICER".

How did you do it?
Check the platform before building and verifying monitor session config, remove the policer if platform startwith "x86_64-arista_7060x6_64pe".

How did you verify/test it?
Run generic_config_updater/test_monitor_config.py::test_monitor_config_tc1_suite locally on 7060x6 and it passed.

generic_config_updater/test_monitor_config.py::test_monitor_config_tc1_suite PASSED   [100%]
@mssonicbld
Copy link
Copy Markdown
Collaborator Author

Original PR: #19463

@mssonicbld
Copy link
Copy Markdown
Collaborator Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld mssonicbld merged commit 2d2d835 into sonic-net:202505 Jul 23, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants