[T2] Everflow - "erspan_ip_ver" support for the new recycle port queue tests by sanjair-git · Pull Request #19594 · sonic-net/sonic-mgmt

sanjair-git · 2025-07-14T20:19:32Z

Description of PR

Summary:
Fixes # (issue)

This PR adds erspan-ip-ver support to the newly added 'test_everflow_fwd_recircle_port_queue_check'
It adds 'erspan_ip_ver' to the mirror session configuration for the respective test.

Type of change

Back port request

Approach

What is the motivation for this PR?

On the latest sonic-mgmt master, after the merge of PR Everflow - Test for recycle port queue counter #16018, Ipv6 tests of 'test_everflow_fwd_recircle_port_queue_check' started failing which needed erspan_ip_ver support.

How did you do it?

Added 'erspan_ip_ver' to the mirror session config for the test 'test_everflow_fwd_recircle_port_queue_check'

How did you verify/test it?

Ran the tests on T2 testbed and made sure all the respective tests are passing.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

mssonicbld · 2025-07-14T20:19:40Z

/azp run

azure-pipelines · 2025-07-14T20:19:54Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-07-14T20:27:55Z

/azp run

azure-pipelines · 2025-07-14T20:28:08Z

Azure Pipelines successfully started running 1 pipeline(s).

arista-nwolfe · 2025-10-03T00:27:13Z

tests/everflow/everflow_test_utilities.py

+                for asic_index in duthost.get_frontend_asic_ids():
+                    if asic_index is not None:
+                        # Adding IPv6 ERSPAN sessions for each asic, from the CLI is currently not supported.
+                        command = f"sonic-db-cli -n asic{asic_index} CONFIG_DB HSET " \
+                                  f"'MIRROR_SESSION|{session_info['session_name']}' " \
+                                  f"'dscp' '{session_info['session_dscp']}' " \
+                                  f"'dst_ip' '{session_info['session_dst_ipv6']}' " \
+                                  f"'gre_type' '{session_info['session_gre']}' " \
+                                  f"'type' '{session_info['session_type']}' " \
+                                  f"'src_ip' '{session_info['session_src_ipv6']}' 'ttl' '{session_info['session_ttl']}'"
+                        if queue_num:
+                            command += f" 'queue' {queue_num}"
+                        if policer:
+                            command += f" 'policer' {policer}"
+                    else:
+                        # Adding IPv6 ERSPAN sessions, from the CLI is currently not supported.
+                        command = f"sonic-db-cli CONFIG_DB HSET 'MIRROR_SESSION|{session_info['session_name']}' " \
+                                  f"'dscp' '{session_info['session_dscp']}' " \
+                                  f"'dst_ip' '{session_info['session_dst_ipv6']}' " \
+                                  f"'gre_type' '{session_info['session_gre']}' " \
+                                  f"'src_ip' '{session_info['session_src_ipv6']}' 'ttl' '{session_info['session_ttl']}'"


What's the reason for only setting the type attribute in multi-asic?
Won't we still need to set this for single-asic VOQ systems?

Thanks for pointing it out. I missed adding it on the else part of the code. Updated the same.

mssonicbld · 2025-10-08T15:54:30Z

/azp run

azure-pipelines · 2025-10-08T15:54:45Z

Azure Pipelines successfully started running 1 pipeline(s).

rlhui · 2025-10-22T17:57:04Z

@arista-nwolfe , @abdosi reminder to re-review, thx

arista-nwolfe · 2025-10-22T18:19:35Z

tests/everflow/everflow_test_utilities.py

+                for asic_index in duthost.get_frontend_asic_ids():
+                    if asic_index is not None:
+                        # Adding IPv6 ERSPAN sessions for each asic, from the CLI is currently not supported.
+                        command = f"sonic-db-cli -n asic{asic_index} CONFIG_DB HSET " \
+                                  f"'MIRROR_SESSION|{session_info['session_name']}' " \
+                                  f"'dscp' '{session_info['session_dscp']}' " \
+                                  f"'dst_ip' '{session_info['session_dst_ipv6']}' " \
+                                  f"'gre_type' '{session_info['session_gre']}' " \
+                                  f"'type' '{session_info['session_type']}' " \
+                                  f"'src_ip' '{session_info['session_src_ipv6']}' 'ttl' '{session_info['session_ttl']}'"
+                        if queue_num:
+                            command += f" 'queue' {queue_num}"
+                        if policer:
+                            command += f" 'policer' {policer}"
+                    else:
+                        # Adding IPv6 ERSPAN sessions, from the CLI is currently not supported.
+                        command = f"sonic-db-cli CONFIG_DB HSET 'MIRROR_SESSION|{session_info['session_name']}' " \
+                                  f"'dscp' '{session_info['session_dscp']}' " \
+                                  f"'dst_ip' '{session_info['session_dst_ipv6']}' " \
+                                  f"'gre_type' '{session_info['session_gre']}' " \
+                                  f"'type' '{session_info['session_type']}' " \
+                                  f"'src_ip' '{session_info['session_src_ipv6']}' 'ttl' '{session_info['session_ttl']}'"
+                        if queue_num:
+                            command += f" 'queue' {queue_num}"
+                        if policer:
+                            command += f" 'policer' {policer}"
+                    commands_list.append(command)


Could maybe reduce the code duplication here with:

if asic_index is not None: command = f"sonic-db-cli -n asic{asic_index} " else: command = f"sonic-db-cli " command += f"CONFIG_DB hset 'MIRROR_SESSION|{session_info['session_name']}' "\ <etc, all remaining commands should be common between single-asic and multi-asic>

@arista-nwolfe , taken care. Removed the code duplication.

mssonicbld · 2025-11-12T16:42:50Z

/azp run

azure-pipelines · 2025-11-12T16:43:05Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-11-12T18:06:35Z

/azp run

azure-pipelines · 2025-11-12T18:06:49Z

Azure Pipelines successfully started running 1 pipeline(s).

Add missing session_type

flake8 fix

mssonicbld · 2025-11-26T17:21:34Z

/azp run

azure-pipelines · 2025-11-26T17:21:49Z

Azure Pipelines successfully started running 1 pipeline(s).

…e tests (sonic-net#19594) This PR adds erspan-ip-ver support to the newly added 'test_everflow_fwd_recircle_port_queue_check' It adds 'erspan_ip_ver' to the mirror session configuration for the respective test.

mssonicbld · 2026-01-20T19:03:18Z

Cherry-pick PR to 202511: #22002

…e tests (sonic-net#19594) This PR adds erspan-ip-ver support to the newly added 'test_everflow_fwd_recircle_port_queue_check' It adds 'erspan_ip_ver' to the mirror session configuration for the respective test. Signed-off-by: Priyansh Tratiya <ptratiya@microsoft.com>

…e tests (sonic-net#19594) This PR adds erspan-ip-ver support to the newly added 'test_everflow_fwd_recircle_port_queue_check' It adds 'erspan_ip_ver' to the mirror session configuration for the respective test. Signed-off-by: Saravanan Sellappa <saravanan@nexthop.ai>

…e tests (sonic-net#19594) This PR adds erspan-ip-ver support to the newly added 'test_everflow_fwd_recircle_port_queue_check' It adds 'erspan_ip_ver' to the mirror session configuration for the respective test.

…e tests (sonic-net#19594) This PR adds erspan-ip-ver support to the newly added 'test_everflow_fwd_recircle_port_queue_check' It adds 'erspan_ip_ver' to the mirror session configuration for the respective test. Signed-off-by: Yael Tzur <ytzur@nvidia.com>

…e tests (sonic-net#19594) This PR adds erspan-ip-ver support to the newly added 'test_everflow_fwd_recircle_port_queue_check' It adds 'erspan_ip_ver' to the mirror session configuration for the respective test.

…e tests (sonic-net#19594) This PR adds erspan-ip-ver support to the newly added 'test_everflow_fwd_recircle_port_queue_check' It adds 'erspan_ip_ver' to the mirror session configuration for the respective test. Signed-off-by: ayya <anirudh.ayya@nokia.com>

…e tests (sonic-net#19594) This PR adds erspan-ip-ver support to the newly added 'test_everflow_fwd_recircle_port_queue_check' It adds 'erspan_ip_ver' to the mirror session configuration for the respective test. Signed-off-by: nnelluri-cisco <nnelluri@cisco.com>

…e tests (sonic-net#19594) This PR adds erspan-ip-ver support to the newly added 'test_everflow_fwd_recircle_port_queue_check' It adds 'erspan_ip_ver' to the mirror session configuration for the respective test. Signed-off-by: Raghavendran Ramanathan <rraghav@cisco.com>

…e tests (sonic-net#19594) This PR adds erspan-ip-ver support to the newly added 'test_everflow_fwd_recircle_port_queue_check' It adds 'erspan_ip_ver' to the mirror session configuration for the respective test. Signed-off-by: Zhuohui Tan <zhuohui.tan@amd.com>

…e tests (sonic-net#19594) This PR adds erspan-ip-ver support to the newly added 'test_everflow_fwd_recircle_port_queue_check' It adds 'erspan_ip_ver' to the mirror session configuration for the respective test. Signed-off-by: Abhishek <abhishek@nexthop.ai>

…e tests (sonic-net#19594) This PR adds erspan-ip-ver support to the newly added 'test_everflow_fwd_recircle_port_queue_check' It adds 'erspan_ip_ver' to the mirror session configuration for the respective test.

sanjair-git force-pushed the eflow-queue-erspan branch from fc66748 to 5ba1952 Compare July 14, 2025 20:27

mlok-nokia added this to SONiC Chassis Jul 30, 2025

abdosi self-requested a review July 30, 2025 17:16

sanjair-git mentioned this pull request Jul 30, 2025

[T2] Multi-asic support for everflow IPV6 mirror-session config tests #18155

Closed

11 tasks

arista-nwolfe reviewed Oct 3, 2025

View reviewed changes

sanjair-git force-pushed the eflow-queue-erspan branch from 5ba1952 to 9c70c88 Compare October 8, 2025 15:54

rlhui mentioned this pull request Oct 22, 2025

Everflow IPv6 tests failing since mirror type is not set correctly (test_everflow_ipv6.py) #20884

Closed

11 tasks

arista-nwolfe approved these changes Oct 22, 2025

View reviewed changes

venu-nexthop approved these changes Oct 22, 2025

View reviewed changes

sanjair-git force-pushed the eflow-queue-erspan branch from 9c70c88 to b6e60ee Compare November 12, 2025 16:42

sanjair-git force-pushed the eflow-queue-erspan branch from b6e60ee to 163a61c Compare November 12, 2025 18:06

sanjair-git added 2 commits November 26, 2025 12:21

"erspan_ip_ver" support for recycle port queue tests

9792884

Add missing session_type

Remove duplicate code for IPV6 mirror session config

ec20955

flake8 fix

sanjair-git force-pushed the eflow-queue-erspan branch from 163a61c to ec20955 Compare November 26, 2025 17:21

rlhui approved these changes Jan 20, 2026

View reviewed changes

rlhui merged commit b762374 into sonic-net:master Jan 20, 2026
15 checks passed

github-project-automation bot moved this to Done in SONiC Chassis Jan 20, 2026

rlhui added the Request for 202511 branch Request to backport a change to 202511 branch label Jan 20, 2026

vmittal-msft added the Approved for 202511 branch label Jan 20, 2026

mssonicbld added the Created PR to 202511 branch label Jan 20, 2026

mssonicbld mentioned this pull request Jan 20, 2026

[action] [PR:19594] [T2] Everflow - "erspan_ip_ver" support for the new recycle port queue tests #22002

Open

11 tasks

Conversation

sanjair-git commented Jul 14, 2025

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

mssonicbld commented Jul 14, 2025

Uh oh!

azure-pipelines bot commented Jul 14, 2025

Uh oh!

mssonicbld commented Jul 14, 2025

Uh oh!

azure-pipelines bot commented Jul 14, 2025

Uh oh!

arista-nwolfe Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

sanjair-git Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

mssonicbld commented Oct 8, 2025

Uh oh!

azure-pipelines bot commented Oct 8, 2025

Uh oh!

rlhui commented Oct 22, 2025

Uh oh!

arista-nwolfe Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

sanjair-git Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

mssonicbld commented Nov 12, 2025

Uh oh!

azure-pipelines bot commented Nov 12, 2025

Uh oh!

mssonicbld commented Nov 12, 2025

Uh oh!

azure-pipelines bot commented Nov 12, 2025

Uh oh!

mssonicbld commented Nov 26, 2025

Uh oh!

azure-pipelines bot commented Nov 26, 2025

Uh oh!

Uh oh!

mssonicbld commented Jan 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants