Refactor DPU check in device_utils and test_watchdog#19574
Merged
roy-sror merged 3 commits intosonic-net:masterfrom Jul 29, 2025
Merged
Refactor DPU check in device_utils and test_watchdog#19574roy-sror merged 3 commits intosonic-net:masterfrom
roy-sror merged 3 commits intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nhe-NV
approved these changes
Jul 14, 2025
Contributor
Author
|
Hi @prgeor, can you please review the PR when you're available? Thanks |
This changes is because is_dpu method was removed by below PR [smartswitch]: Add is_smartswitch and is_dpu facts to simplify platform-specific test handling (sonic-net#19313)
xixuej
force-pushed
the
is_dpu_method_update
branch
from
c344ffe to
212318d
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
Hi @vvolam , can you please review this PR? Thanks |
vvolam
approved these changes
Jul 29, 2025
Contributor
Author
|
Hi @roy-sror , can you please review and merge? |
roy-sror
approved these changes
Jul 29, 2025
Collaborator
|
@xixuej PR conflicts with 202505 branch |
Collaborator
|
Hi @xixuej , please fix the conflict and raise PR to 202505 branch |
Contributor
Author
|
Hi @yejianquan , I've resolved the merge conflicts for branch 202505 in the new PR #19912 |
yejianquan
pushed a commit
that referenced
this pull request
Jul 30, 2025
cherry-pick #19574 Description of PR Summary: This changes is because is_dpu method was removed by below PR [smartswitch]: Add is_smartswitch and is_dpu facts to simplify platform-specific test handling (#19313) The way to check if is dpu should use duthost.dut_basic_facts()['ansible_facts']['dut_basic_facts'].get("is_dpu") instead of duthost.get_facts().get('is_dpu') becasue PR #19313 added the facts into dut_basic_facts Resolve merge conflicts for branch 202505 Co-authored-by: Cong Hou <[email protected]>
yejianquan
added
Included in 202505 branch
and removed
Cherry Pick Conflict_202505
labels
nissampa
pushed a commit
to nissampa/sonic-mgmt_dpu_test
that referenced
this pull request
Aug 7, 2025
* Refactor DPU check in device_utils and test_watchdog This changes is because is_dpu method was removed by below PR [smartswitch]: Add is_smartswitch and is_dpu facts to simplify platform-specific test handling (sonic-net#19313) * Fix the condition for dpu in techsupport test * Fix skip dpu logic in techsupport test --------- Co-authored-by: Cong Hou <[email protected]>
ashutosh-agrawal
pushed a commit
to ashutosh-agrawal/sonic-mgmt
that referenced
this pull request
Aug 14, 2025
* Refactor DPU check in device_utils and test_watchdog This changes is because is_dpu method was removed by below PR [smartswitch]: Add is_smartswitch and is_dpu facts to simplify platform-specific test handling (sonic-net#19313) * Fix the condition for dpu in techsupport test * Fix skip dpu logic in techsupport test --------- Co-authored-by: Cong Hou <[email protected]>
vidyac86
pushed a commit
to vidyac86/sonic-mgmt
that referenced
this pull request
Oct 23, 2025
* Refactor DPU check in device_utils and test_watchdog This changes is because is_dpu method was removed by below PR [smartswitch]: Add is_smartswitch and is_dpu facts to simplify platform-specific test handling (sonic-net#19313) * Fix the condition for dpu in techsupport test * Fix skip dpu logic in techsupport test --------- Co-authored-by: Cong Hou <[email protected]>
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
* Refactor DPU check in device_utils and test_watchdog This changes is because is_dpu method was removed by below PR [smartswitch]: Add is_smartswitch and is_dpu facts to simplify platform-specific test handling (sonic-net#19313) * Fix the condition for dpu in techsupport test * Fix skip dpu logic in techsupport test --------- Co-authored-by: Cong Hou <[email protected]> Signed-off-by: opcoder0 <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
* Refactor DPU check in device_utils and test_watchdog This changes is because is_dpu method was removed by below PR [smartswitch]: Add is_smartswitch and is_dpu facts to simplify platform-specific test handling (sonic-net#19313) * Fix the condition for dpu in techsupport test * Fix skip dpu logic in techsupport test --------- Co-authored-by: Cong Hou <[email protected]> Signed-off-by: Guy Shemesh <[email protected]>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
* Refactor DPU check in device_utils and test_watchdog This changes is because is_dpu method was removed by below PR [smartswitch]: Add is_smartswitch and is_dpu facts to simplify platform-specific test handling (sonic-net#19313) * Fix the condition for dpu in techsupport test * Fix skip dpu logic in techsupport test --------- Co-authored-by: Cong Hou <[email protected]> Signed-off-by: Aharon Malkin <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
* Refactor DPU check in device_utils and test_watchdog This changes is because is_dpu method was removed by below PR [smartswitch]: Add is_smartswitch and is_dpu facts to simplify platform-specific test handling (sonic-net#19313) * Fix the condition for dpu in techsupport test * Fix skip dpu logic in techsupport test --------- Co-authored-by: Cong Hou <[email protected]> Signed-off-by: Guy Shemesh <[email protected]>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Jan 13, 2026
* Refactor DPU check in device_utils and test_watchdog This changes is because is_dpu method was removed by below PR [smartswitch]: Add is_smartswitch and is_dpu facts to simplify platform-specific test handling (sonic-net#19313) * Fix the condition for dpu in techsupport test * Fix skip dpu logic in techsupport test --------- Co-authored-by: Cong Hou <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
* Refactor DPU check in device_utils and test_watchdog This changes is because is_dpu method was removed by below PR [smartswitch]: Add is_smartswitch and is_dpu facts to simplify platform-specific test handling (sonic-net#19313) * Fix the condition for dpu in techsupport test * Fix skip dpu logic in techsupport test --------- Co-authored-by: Cong Hou <[email protected]> Signed-off-by: Guy Shemesh <[email protected]>
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Feb 2, 2026
* Refactor DPU check in device_utils and test_watchdog This changes is because is_dpu method was removed by below PR [smartswitch]: Add is_smartswitch and is_dpu facts to simplify platform-specific test handling (sonic-net#19313) * Fix the condition for dpu in techsupport test * Fix skip dpu logic in techsupport test --------- Co-authored-by: Cong Hou <[email protected]> Signed-off-by: Yael Tzur <[email protected]>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Mar 27, 2026
* Refactor DPU check in device_utils and test_watchdog This changes is because is_dpu method was removed by below PR [smartswitch]: Add is_smartswitch and is_dpu facts to simplify platform-specific test handling (sonic-net#19313) * Fix the condition for dpu in techsupport test * Fix skip dpu logic in techsupport test --------- Co-authored-by: Cong Hou <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes is because is_dpu method was removed
by below PR
[smartswitch]: Add is_smartswitch and is_dpu facts to simplify platform-specific test handling (#19313)
The way to check if is dpu should use
duthost.dut_basic_facts()['ansible_facts']['dut_basic_facts'].get("is_dpu")instead ofduthost.get_facts().get('is_dpu')becasue PR #19313 added the facts into dut_basic_factsDescription of PR
Summary:
Fixes #19573
Type of change
Back port request
Approach
What is the motivation for this PR?
To fix bugs that cause test failure
How did you do it?
update tests that calls method that does not exist
How did you verify/test it?
run test before and after the PR to verify it works as expected
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation