[action] [PR:18301] Fix PortChannel name matching in verify_attr_change to handle leading spaces#19458
Merged
mssonicbld merged 1 commit intosonic-net:202411from Jul 9, 2025
Merged
Conversation
… spaces (sonic-net#18301) What is the motivation for this PR? test_portchannel_interface_tc2_attributes failed with the following error: if attr == "mtu": output = duthost.shell("show interfaces status | grep -w '^{}' | awk '{{print $4}}'".format(po_name)) > pytest_assert(output['stdout'] == value, "{} attribute {} failed to change to {}".format(po_name, attr, value)) E Failed: PortChannel102 attribute mtu failed to change to 3324 This is due to cmd "show interfaces status | grep -w '^{}' | awk '{{print $4}}'" failed to filter out the correct PortChannel interface line when the PortChannel name is indented with spaces: PortChannel102 N/A 100G 9100 N/A N/A routed up up N/A N/A PortChannel104 N/A 100G 9100 N/A N/A routed up up N/A N/A PortChannel106 N/A 100G 9100 N/A N/A routed up up N/A N/A PortChannel108 N/A 100G 9100 N/A N/A routed up up N/A N/A PortChannel109 N/A 100G 9100 N/A N/A routed up up N/A N/A PortChannel1010 N/A 100G 9100 N/A N/A routed up up N/A N/A PortChannel1011 N/A 100G 9100 N/A N/A routed up up N/A N/A PortChannel1012 N/A 100G 9100 N/A N/A routed up up N/A N/A This PR updates the verify_attr_change function in test_portchannel_interface.py to correctly handle leading spaces in the PortChannel name when parsing interface status output. How did you do it? Modified the grep pattern from '^{}' to ^[[:space:]]*{} to match interface lines with leading spaces robustly. How did you verify/test it? Run generic_config_updater/test_portchannel_interface.py::test_portchannel_interface_tc2_attributes manually on DUT. generic_config_updater/test_portchannel_interface.py::test_portchannel_interface_tc2_attributes PASSED
7 tasks
Collaborator
Author
|
Original PR: #18301 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
test_portchannel_interface_tc2_attributes failed with the following error:
This is due to cmd "show interfaces status | grep -w '^{}' | awk '{{print $4}}'" failed to filter out the correct PortChannel interface line when the PortChannel name is indented with spaces:
This PR updates the verify_attr_change function in test_portchannel_interface.py to correctly handle leading spaces in the PortChannel name when parsing interface status output.
How did you do it?
Modified the grep pattern from '^{}' to ^[[:space:]]*{} to match interface lines with leading spaces robustly.
How did you verify/test it?
Run generic_config_updater/test_portchannel_interface.py::test_portchannel_interface_tc2_attributes manually on DUT.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation
Signed-off-by: zitingguo-ms zitingguo@microsoft.com