[Snappi] Fix tx/rx port sequence in test_pfc_port_congestion.py by sdszhang · Pull Request #19445 · sonic-net/sonic-mgmt

sdszhang · 2025-07-07T07:30:29Z

Description of PR

Summary:
Fixes the following issues in test_pfc_port_congestion.py:

Fixed the rx/tx port sequence, the currnet port_map is defined as [total egress port, egress port speed, total ingress ports, ingress port speed]. So get the rx port info from the first two elements.
pfcwd will be triggered on cisco platform as we are sending oversubscribed traffic, so disabling it during the test.

Type of change

Back port request

Approach

What is the motivation for this PR?

Adopt this test case for 400G speed

How did you do it?

Fixed the case to use correct RX/TX port_map sequence. and disable pfcwd inside the test case.

How did you verify/test it?

snappi_tests/pfc/test_pfc_port_congestion.py::test_multiple_prio_diff_dist[multidut_port_info0-port_map0] SKIPPED [  6%]
snappi_tests/pfc/test_pfc_port_congestion.py::test_multiple_prio_diff_dist[multidut_port_info0-port_map1] 
-------------------------------- live log call ---------------------------------
05:07:37 connection._warn                         L0332 WARNING| Verification of certificates is disabled
05:07:37 connection._warn                         L0332 WARNING| Unable to connect to http://10.206.144.17:443.
PASSED                                                                   [ 12%]
snappi_tests/pfc/test_pfc_port_congestion.py::test_multiple_prio_diff_dist[multidut_port_info1-port_map0] SKIPPED [ 18%]
snappi_tests/pfc/test_pfc_port_congestion.py::test_multiple_prio_diff_dist[multidut_port_info1-port_map1] PASSED [ 25%]
snappi_tests/pfc/test_pfc_port_congestion.py::test_multiple_prio_uni_dist[multidut_port_info0-port_map0] SKIPPED [ 31%]
snappi_tests/pfc/test_pfc_port_congestion.py::test_multiple_prio_uni_dist[multidut_port_info0-port_map1] PASSED [ 37%]
snappi_tests/pfc/test_pfc_port_congestion.py::test_multiple_prio_uni_dist[multidut_port_info1-port_map0] SKIPPED [ 43%]
snappi_tests/pfc/test_pfc_port_congestion.py::test_multiple_prio_uni_dist[multidut_port_info1-port_map1] PASSED [ 50%]
snappi_tests/pfc/test_pfc_port_congestion.py::test_multiple_prio_equal_dist[multidut_port_info0-port_map0] SKIPPED [ 56%]
snappi_tests/pfc/test_pfc_port_congestion.py::test_multiple_prio_equal_dist[multidut_port_info0-port_map1] PASSED [ 62%]
snappi_tests/pfc/test_pfc_port_congestion.py::test_multiple_prio_equal_dist[multidut_port_info1-port_map0] SKIPPED [ 68%]
snappi_tests/pfc/test_pfc_port_congestion.py::test_multiple_prio_equal_dist[multidut_port_info1-port_map1] PASSED [ 75%]
snappi_tests/pfc/test_pfc_port_congestion.py::test_multiple_prio_non_cngtn[multidut_port_info0-port_map0] SKIPPED [ 81%]
snappi_tests/pfc/test_pfc_port_congestion.py::test_multiple_prio_non_cngtn[multidut_port_info0-port_map1] PASSED [ 87%]
snappi_tests/pfc/test_pfc_port_congestion.py::test_multiple_prio_non_cngtn[multidut_port_info1-port_map0] SKIPPED [ 93%]
snappi_tests/pfc/test_pfc_port_congestion.py::test_multiple_prio_non_cngtn[multidut_port_info1-port_map1] PASSED [100%]

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

mssonicbld · 2025-07-07T07:30:37Z

/azp run

azure-pipelines · 2025-07-07T07:30:50Z

Azure Pipelines successfully started running 1 pipeline(s).

tests/snappi_tests/pfc/test_pfc_port_congestion.py

mssonicbld · 2025-07-15T14:18:16Z

/azp run

azure-pipelines · 2025-07-15T14:18:30Z

Azure Pipelines successfully started running 1 pipeline(s).

…c-net#19445) * swap rx tx port and disable pfcwd * disable pfcwd for cisco chassis.

mssonicbld · 2025-07-31T07:41:12Z

Cherry-pick PR to 202505: #19959

mssonicbld · 2025-07-31T07:49:04Z

Cherry-pick PR to msft-202405: Azure/sonic-mgmt.msft#598

* swap rx tx port and disable pfcwd * disable pfcwd for cisco chassis.

…c-net#19445) * swap rx tx port and disable pfcwd * disable pfcwd for cisco chassis.

…c-net#19445) * swap rx tx port and disable pfcwd * disable pfcwd for cisco chassis. Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>

…c-net#19445) * swap rx tx port and disable pfcwd * disable pfcwd for cisco chassis. Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>

…c-net#19445) * swap rx tx port and disable pfcwd * disable pfcwd for cisco chassis. Signed-off-by: Aharon Malkin <amalkin@nvidia.com>

…c-net#19445) * swap rx tx port and disable pfcwd * disable pfcwd for cisco chassis. Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>

…c-net#19445) * swap rx tx port and disable pfcwd * disable pfcwd for cisco chassis.

…c-net#19445) * swap rx tx port and disable pfcwd * disable pfcwd for cisco chassis. Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>

…c-net#19445) * swap rx tx port and disable pfcwd * disable pfcwd for cisco chassis. Signed-off-by: Yael Tzur <ytzur@nvidia.com>

Why I did it DEFAULT_CONTAINER_REGISTRY didn't work as expected in some scenario. How I did it When check for docker arch, use DEFAULT_CONTAINER_REGISTRY if it is not null.

…c-net#19445) * swap rx tx port and disable pfcwd * disable pfcwd for cisco chassis.

swap rx tx port and disable pfcwd

21156ff

sdszhang commented Jul 7, 2025

View reviewed changes

tests/snappi_tests/pfc/test_pfc_port_congestion.py Outdated Show resolved Hide resolved

sdszhang added this to SONiC Snappi Jul 7, 2025

sdszhang moved this to In Progress in SONiC Snappi Jul 7, 2025

disable pfcwd for cisco chassis.

4cfb5fc

sdszhang moved this from In Progress to To be Merged in SONiC Snappi Jul 30, 2025

auspham approved these changes Jul 31, 2025

View reviewed changes

sdszhang added the Request for 202505 branch label Jul 31, 2025

yejianquan merged commit 621cfcc into sonic-net:master Jul 31, 2025
11 checks passed

github-project-automation bot moved this from To be Merged to Done in SONiC Snappi Jul 31, 2025

yejianquan added the Approved for 202505 branch label Jul 31, 2025

mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Jul 31, 2025

[Snappi] Fix tx/rx port sequence in test_pfc_port_congestion.py (soni…

9fd97b3

…c-net#19445) * swap rx tx port and disable pfcwd * disable pfcwd for cisco chassis.

mssonicbld added the Created PR to 202505 branch label Jul 31, 2025

mssonicbld mentioned this pull request Jul 31, 2025

[action] [PR:19445] [Snappi] Fix tx/rx port sequence in test_pfc_port_congestion.py #19959

Merged

11 tasks

sdszhang added the Request for msft-202405 Branch label Jul 31, 2025

yejianquan added the Approved for msft-202405 Branch label Jul 31, 2025

mssonicbld mentioned this pull request Jul 31, 2025

[action] [PR:19445] [Snappi] Fix tx/rx port sequence in test_pfc_port_congestion.py Azure/sonic-mgmt.msft#598

Merged

11 tasks

mssonicbld added the Created PR to msft-202405 Branch label Jul 31, 2025

mssonicbld added Included in msft-202405 Branch and removed Created PR to msft-202405 Branch labels Jul 31, 2025

mssonicbld pushed a commit that referenced this pull request Jul 31, 2025

[Snappi] Fix tx/rx port sequence in test_pfc_port_congestion.py (#19445)

66464fe

* swap rx tx port and disable pfcwd * disable pfcwd for cisco chassis.

mssonicbld added Included in 202505 branch and removed Created PR to 202505 branch labels Jul 31, 2025

nissampa pushed a commit to nissampa/sonic-mgmt_dpu_test that referenced this pull request Aug 7, 2025

[Snappi] Fix tx/rx port sequence in test_pfc_port_congestion.py (soni…

f572ebb

…c-net#19445) * swap rx tx port and disable pfcwd * disable pfcwd for cisco chassis.

ashutosh-agrawal pushed a commit to ashutosh-agrawal/sonic-mgmt that referenced this pull request Aug 14, 2025

[Snappi] Fix tx/rx port sequence in test_pfc_port_congestion.py (soni…

5a68496

…c-net#19445) * swap rx tx port and disable pfcwd * disable pfcwd for cisco chassis.

sdszhang deleted the ixia_pfc_congestion branch September 13, 2025 10:22

kanchanavelusamy pushed a commit to kanchanavelusamy/sonic-mgmt that referenced this pull request Oct 7, 2025

[Snappi] Fix tx/rx port sequence in test_pfc_port_congestion.py (soni…

10620b2

…c-net#19445) * swap rx tx port and disable pfcwd * disable pfcwd for cisco chassis.

vidyac86 pushed a commit to vidyac86/sonic-mgmt that referenced this pull request Oct 23, 2025

[Snappi] Fix tx/rx port sequence in test_pfc_port_congestion.py (soni…

8579f1f

…c-net#19445) * swap rx tx port and disable pfcwd * disable pfcwd for cisco chassis.

venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Jan 13, 2026

[Snappi] Fix tx/rx port sequence in test_pfc_port_congestion.py (soni…

5ab09e9

…c-net#19445) * swap rx tx port and disable pfcwd * disable pfcwd for cisco chassis.

venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Mar 27, 2026

[Snappi] Fix tx/rx port sequence in test_pfc_port_congestion.py (soni…

aed7618

…c-net#19445) * swap rx tx port and disable pfcwd * disable pfcwd for cisco chassis.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Snappi] Fix tx/rx port sequence in test_pfc_port_congestion.py#19445

[Snappi] Fix tx/rx port sequence in test_pfc_port_congestion.py#19445
yejianquan merged 2 commits intosonic-net:masterfrom
sdszhang:ixia_pfc_congestion

sdszhang commented Jul 7, 2025 •

edited

Loading

Uh oh!

mssonicbld commented Jul 7, 2025

Uh oh!

azure-pipelines bot commented Jul 7, 2025

Uh oh!

Uh oh!

mssonicbld commented Jul 15, 2025

Uh oh!

azure-pipelines bot commented Jul 15, 2025

Uh oh!

Uh oh!

mssonicbld commented Jul 31, 2025

Uh oh!

mssonicbld commented Jul 31, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

sdszhang commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

mssonicbld commented Jul 7, 2025

Uh oh!

azure-pipelines bot commented Jul 7, 2025

Uh oh!

Uh oh!

mssonicbld commented Jul 15, 2025

Uh oh!

azure-pipelines bot commented Jul 15, 2025

Uh oh!

Uh oh!

mssonicbld commented Jul 31, 2025

Uh oh!

mssonicbld commented Jul 31, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sdszhang commented Jul 7, 2025 •

edited

Loading