[bgp-scale-test] Use different icmp type for each traffic thread to remove packet count noise#19380
Merged
Blueve merged 2 commits intosonic-net:masterfrom Jul 7, 2025
Merged
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
w1nda
requested review from
Blueve and
yaqiangz
and removed request for
StormLiangMS
Member
Author
|
@weiguo-nvidia, this is the fix for negative downtime |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
r12f
approved these changes
Jul 3, 2025
Blueve
approved these changes
Jul 7, 2025
Member
Author
|
Hi @Blueve, cloud you merge this PR? |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jul 7, 2025
…emove packet count noise (sonic-net#19380) What is the motivation for this PR? We run test cases one by one, however, when count packets in next test case, it may count some packets from previous test case. How did you do it? To remove the noise, we use different icmp type for each traffic thread in test case, so that the packet count is more accurate. How did you verify/test it? Run test on 5640 testbed with 510 bgp session
Collaborator
|
Cherry-pick PR to 202505: #19448 |
This was referenced Jul 7, 2025
Collaborator
|
Cherry-pick PR to msft-202412: Azure/sonic-mgmt.msft#503 |
mssonicbld
added
Included in msft-202412 Branch
and removed
Created PR to msft-202412 Branch
labels
mssonicbld
pushed a commit
that referenced
this pull request
Jul 7, 2025
…emove packet count noise (#19380) What is the motivation for this PR? We run test cases one by one, however, when count packets in next test case, it may count some packets from previous test case. How did you do it? To remove the noise, we use different icmp type for each traffic thread in test case, so that the packet count is more accurate. How did you verify/test it? Run test on 5640 testbed with 510 bgp session
11 tasks
nissampa
pushed a commit
to nissampa/sonic-mgmt_dpu_test
that referenced
this pull request
Aug 7, 2025
…emove packet count noise (sonic-net#19380) What is the motivation for this PR? We run test cases one by one, however, when count packets in next test case, it may count some packets from previous test case. How did you do it? To remove the noise, we use different icmp type for each traffic thread in test case, so that the packet count is more accurate. How did you verify/test it? Run test on 5640 testbed with 510 bgp session
ashutosh-agrawal
pushed a commit
to ashutosh-agrawal/sonic-mgmt
that referenced
this pull request
Aug 14, 2025
…emove packet count noise (sonic-net#19380) What is the motivation for this PR? We run test cases one by one, however, when count packets in next test case, it may count some packets from previous test case. How did you do it? To remove the noise, we use different icmp type for each traffic thread in test case, so that the packet count is more accurate. How did you verify/test it? Run test on 5640 testbed with 510 bgp session
vidyac86
pushed a commit
to vidyac86/sonic-mgmt
that referenced
this pull request
Oct 23, 2025
…emove packet count noise (sonic-net#19380) What is the motivation for this PR? We run test cases one by one, however, when count packets in next test case, it may count some packets from previous test case. How did you do it? To remove the noise, we use different icmp type for each traffic thread in test case, so that the packet count is more accurate. How did you verify/test it? Run test on 5640 testbed with 510 bgp session
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
…emove packet count noise (sonic-net#19380) What is the motivation for this PR? We run test cases one by one, however, when count packets in next test case, it may count some packets from previous test case. How did you do it? To remove the noise, we use different icmp type for each traffic thread in test case, so that the packet count is more accurate. How did you verify/test it? Run test on 5640 testbed with 510 bgp session Signed-off-by: opcoder0 <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
…emove packet count noise (sonic-net#19380) What is the motivation for this PR? We run test cases one by one, however, when count packets in next test case, it may count some packets from previous test case. How did you do it? To remove the noise, we use different icmp type for each traffic thread in test case, so that the packet count is more accurate. How did you verify/test it? Run test on 5640 testbed with 510 bgp session Signed-off-by: Guy Shemesh <[email protected]>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
…emove packet count noise (sonic-net#19380) What is the motivation for this PR? We run test cases one by one, however, when count packets in next test case, it may count some packets from previous test case. How did you do it? To remove the noise, we use different icmp type for each traffic thread in test case, so that the packet count is more accurate. How did you verify/test it? Run test on 5640 testbed with 510 bgp session Signed-off-by: Aharon Malkin <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
…emove packet count noise (sonic-net#19380) What is the motivation for this PR? We run test cases one by one, however, when count packets in next test case, it may count some packets from previous test case. How did you do it? To remove the noise, we use different icmp type for each traffic thread in test case, so that the packet count is more accurate. How did you verify/test it? Run test on 5640 testbed with 510 bgp session Signed-off-by: Guy Shemesh <[email protected]>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Jan 13, 2026
…emove packet count noise (sonic-net#19380) What is the motivation for this PR? We run test cases one by one, however, when count packets in next test case, it may count some packets from previous test case. How did you do it? To remove the noise, we use different icmp type for each traffic thread in test case, so that the packet count is more accurate. How did you verify/test it? Run test on 5640 testbed with 510 bgp session
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
…emove packet count noise (sonic-net#19380) What is the motivation for this PR? We run test cases one by one, however, when count packets in next test case, it may count some packets from previous test case. How did you do it? To remove the noise, we use different icmp type for each traffic thread in test case, so that the packet count is more accurate. How did you verify/test it? Run test on 5640 testbed with 510 bgp session Signed-off-by: Guy Shemesh <[email protected]>
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Feb 2, 2026
…emove packet count noise (sonic-net#19380) What is the motivation for this PR? We run test cases one by one, however, when count packets in next test case, it may count some packets from previous test case. How did you do it? To remove the noise, we use different icmp type for each traffic thread in test case, so that the packet count is more accurate. How did you verify/test it? Run test on 5640 testbed with 510 bgp session Signed-off-by: Yael Tzur <[email protected]>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Mar 27, 2026
…emove packet count noise (sonic-net#19380) What is the motivation for this PR? We run test cases one by one, however, when count packets in next test case, it may count some packets from previous test case. How did you do it? To remove the noise, we use different icmp type for each traffic thread in test case, so that the packet count is more accurate. How did you verify/test it? Run test on 5640 testbed with 510 bgp session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
We run test cases one by one, however, when count packets in next test case, it may count some packets from previous test case.
To remove the noise, we use different icmp type for each traffic thread in test case, so that the packet count is more accurate.
Type of change
Back port request
Approach
What is the motivation for this PR?
We run test cases one by one, however, when count packets in next test case, it may count some packets from previous test case.
How did you do it?
To remove the noise, we use different icmp type for each traffic thread in test case, so that the packet count is more accurate.
How did you verify/test it?
Run test on 5640 testbed with 510 bgp session
Any platform specific information?
No
Supported testbed topology if it's a new test case?
Documentation