Exclude disabled/missing features on non-modulars as well in critical_services_tracking_list#19353
Merged
abdosi merged 1 commit intosonic-net:masterfrom Jul 16, 2025
Conversation
In critical_services_tracking_list it previously only removed disabled features from the critical services list on modulars. We can have disabled features on non-modulars as well. Also handle the case where the feature is missing from config_db
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@eswaran-nexthop will review |
abdosi
approved these changes
Jul 16, 2025
nissampa
pushed a commit
to nissampa/sonic-mgmt_dpu_test
that referenced
this pull request
Aug 7, 2025
…19353) In critical_services_tracking_list it previously only removed disabled features from the critical services list on modulars. We can have disabled features on non-modulars as well. Also handle the case where the feature is missing from config_db
ashutosh-agrawal
pushed a commit
to ashutosh-agrawal/sonic-mgmt
that referenced
this pull request
Aug 14, 2025
…19353) In critical_services_tracking_list it previously only removed disabled features from the critical services list on modulars. We can have disabled features on non-modulars as well. Also handle the case where the feature is missing from config_db
vidyac86
pushed a commit
to vidyac86/sonic-mgmt
that referenced
this pull request
Oct 23, 2025
…19353) In critical_services_tracking_list it previously only removed disabled features from the critical services list on modulars. We can have disabled features on non-modulars as well. Also handle the case where the feature is missing from config_db
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
…19353) In critical_services_tracking_list it previously only removed disabled features from the critical services list on modulars. We can have disabled features on non-modulars as well. Also handle the case where the feature is missing from config_db Signed-off-by: opcoder0 <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
…19353) In critical_services_tracking_list it previously only removed disabled features from the critical services list on modulars. We can have disabled features on non-modulars as well. Also handle the case where the feature is missing from config_db Signed-off-by: Guy Shemesh <[email protected]>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
…19353) In critical_services_tracking_list it previously only removed disabled features from the critical services list on modulars. We can have disabled features on non-modulars as well. Also handle the case where the feature is missing from config_db Signed-off-by: Aharon Malkin <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
…19353) In critical_services_tracking_list it previously only removed disabled features from the critical services list on modulars. We can have disabled features on non-modulars as well. Also handle the case where the feature is missing from config_db Signed-off-by: Guy Shemesh <[email protected]>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Jan 13, 2026
…19353) In critical_services_tracking_list it previously only removed disabled features from the critical services list on modulars. We can have disabled features on non-modulars as well. Also handle the case where the feature is missing from config_db
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
…19353) In critical_services_tracking_list it previously only removed disabled features from the critical services list on modulars. We can have disabled features on non-modulars as well. Also handle the case where the feature is missing from config_db Signed-off-by: Guy Shemesh <[email protected]>
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Feb 2, 2026
…19353) In critical_services_tracking_list it previously only removed disabled features from the critical services list on modulars. We can have disabled features on non-modulars as well. Also handle the case where the feature is missing from config_db Signed-off-by: Yael Tzur <[email protected]>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Mar 27, 2026
…19353) In critical_services_tracking_list it previously only removed disabled features from the critical services list on modulars. We can have disabled features on non-modulars as well. Also handle the case where the feature is missing from config_db
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In critical_services_tracking_list it previously only removed disabled features from the critical services list on modulars.
We can have disabled features on non-modulars as well.
Also handle the case where the feature is missing from config_db.
This came up in the context of the
bmpfeature which can be enabled/disabled.It's being added to the
DEFAULT_ASIC_SERVICESin #18653Type of change
Back port request