Skip to content

Add --show-capture no argument in run_tests.sh#1935

Merged
wangxin merged 1 commit intosonic-net:masterfrom
wangxin:no-show-capture
Jul 22, 2020
Merged

Add --show-capture no argument in run_tests.sh#1935
wangxin merged 1 commit intosonic-net:masterfrom
wangxin:no-show-capture

Conversation

@wangxin
Copy link
Collaborator

@wangxin wangxin commented Jul 20, 2020

Description of PR

Summary:
Fixes # (issue)

The run_tests.sh is able to store all the testing logs in
log files. It's unnecessary to show captured logs in
cli log. Otherwise, the cli log is also huge.
This commit add the --show-capture no argument
to the PYTEST_COMMON_OPTS in run_tests.sh to
disable that.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

To limit the log size of pytest cli console log.

How did you do it?

Add --show-capture no argument to PYTEST_COMMON_OPTS in run_tests.sh.

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

The run_tests.sh is able to store all the testing logs in
log files. It's unnecessary to show captured logs in
cli log. Otherwise, the cli log is also huge.
This commit add the `--show-capture no` argument
to the PYTEST_COMMON_OPTS in `run_tests.sh` to
disable that.

Signed-off-by: Xin Wang <xiwang5@microsoft.com>
@wangxin wangxin requested a review from a team July 20, 2020 08:56
@wangxin
Copy link
Collaborator Author

wangxin commented Jul 21, 2020

retest this please

@wangxin wangxin merged commit 84f6687 into sonic-net:master Jul 22, 2020
@wangxin wangxin deleted the no-show-capture branch September 24, 2020 02:33
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
Commits:
f147d9e - 2021-10-27 : [Mux orch] Handle setting unknown mux state (sonic-net#1984) [Prince Sunny]
4618b2b - 2021-10-28 : Change tunnel orch order (sonic-net#1990) [Prince Sunny]
505d52d - 2021-10-20 : Fix the option missing in kernel config issue (sonic-net#1973) [xumia]
7bf4dfb - 2021-10-18 : SAI_REDIS_SWITCH_ATTR_CONTEXT shouldbe the last attribute. This is what sairedis library expects (sonic-net#1935) [judyjoseph]
c58919e - 2021-10-08 : [logfile][202012]: Add option to specify swss rec file name (sonic-net#1946) [judyjoseph]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants