Skip to content

Fix test_watchdog.py import issues#1934

Merged
wangxin merged 1 commit intosonic-net:masterfrom
wangxin:fix-watchdog-imports
Jul 20, 2020
Merged

Fix test_watchdog.py import issues#1934
wangxin merged 1 commit intosonic-net:masterfrom
wangxin:fix-watchdog-imports

Conversation

@wangxin
Copy link
Copy Markdown
Collaborator

@wangxin wangxin commented Jul 20, 2020

Description of PR

Summary:
Fixes # (issue)

After PR #1864 is merged, from common.xx import yy is
no longer supported. Probably this PR was created/tested
before PR#1864 was merged. This commit is to fix the
from common.xx import yy issue.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

Fix the import issue in test_watchdog.py.

How did you do it?

Change the imports to:

from tests.common.helpers.platform_api import watchdog
from tests.common.helpers.assertions import pytest_assert

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

After PR #1864 is merged, `from common.xx import yy' is
no longer supported. Probably this PR was created/tested
before PR#1864 was merged. This commit is to fix the
`from common.xx import yy' issue.

Signed-off-by: Xin Wang <xiwang5@microsoft.com>
@wangxin wangxin requested a review from a team July 20, 2020 08:46
@wangxin wangxin merged commit 23bf43a into sonic-net:master Jul 20, 2020
@wangxin wangxin deleted the fix-watchdog-imports branch September 24, 2020 02:33
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
c31a362 - 2021-11-18 : [202012][Mux orch] set default as standby, change mux orch priority (sonic-net#2015) [Prince Sunny]
9a9e8e6 - 2021-11-18 : [202012] Check VS test failure (sonic-net#2033) [Prince Sunny]
7eaabca - 2021-11-11 : [202012] Fix random failure in PR/CI build. (sonic-net#2016) [Shilong Liu]
85230fe - 2021-11-04 : [orchagent] Fix group name of port-buffer-drop in flexcounterorch.cpp (sonic-net#1967) [Junchao-Mellanox]
a55c2ca - 2021-11-03 : [teammgrd]: Handle LAGs cleanup gracefully on Warm/Fast reboot. (sonic-net#1934) [Nazarii Hnydyn]
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
  67278be [teammgrd]: Handle LAGs cleanup gracefully on Warm/Fast reboot. (sonic-net#1934)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants