-
Notifications
You must be signed in to change notification settings - Fork 1k
Convert ansible syslog test to pytest #1930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| import time | ||
| import logging | ||
| import pytest | ||
| from common.helpers.assertions import pytest_assert | ||
|
|
||
yxieca marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
| @pytest.fixture(scope="module") | ||
| def config_syslog_srv(ptfhost): | ||
| logger.info( "Configuring the syslog srver") | ||
|
||
|
|
||
| # add the imudp configuration if not present | ||
| ptfhost.shell('sed -ni \'/module/!p;$a module(load="imudp")\' /etc/rsyslog.conf') | ||
| ptfhost.shell('sed -i \'/input(type/!p;$a input(type="imudp" port="514")\' /etc/rsyslog.conf') | ||
|
|
||
| #Remove local /var/log/syslog | ||
| ptfhost.shell("rm -rf /var/log/syslog") | ||
|
|
||
| #restart Syslog Daemon | ||
| ptfhost.shell("service rsyslog restart") | ||
|
|
||
| #Wait a little bit for service to start | ||
| time.sleep(30) | ||
|
|
||
| yield | ||
|
|
||
| @pytest.fixture(scope="module") | ||
| def config_dut(testbed, duthost): | ||
| logger.info( "Configuring the DUT") | ||
| local_syslog_srv_ip = testbed['ptf_ip'] | ||
| logger.info("test_syslog_srv_ip {}".format(local_syslog_srv_ip)) | ||
|
|
||
| #Add Rsyslog destination for testing | ||
| duthost.shell("sudo config syslog add {}".format(local_syslog_srv_ip)) | ||
|
|
||
| yield | ||
|
|
||
| #remove the syslog configuration | ||
| duthost.shell("sudo config syslog del {}".format(local_syslog_srv_ip)) | ||
|
|
||
| def test_syslog(duthost, ptfhost, config_dut, config_syslog_srv): | ||
| logger.info( "Starting syslog tests") | ||
| test_message = "Basic Test Message" | ||
|
|
||
| #generate a syslog from the DUT | ||
| duthost.shell(" logger --priority INFO {}".format(test_message)) | ||
|
|
||
| #Check syslog messages for the test message | ||
| result = ptfhost.shell("grep {} /var/log/syslog | grep \"{}\" | grep -v ansible".format(duthost.hostname, test_message))['stdout_lines'] | ||
| pytest_assert(result is not None, "Test syslog not seen on the server") | ||
wangxin marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.