Skip to content

[FIB]: Add more logging messages#193

Merged
stcheng merged 1 commit intosonic-net:masterfrom
stcheng:fib_log
Jun 6, 2017
Merged

[FIB]: Add more logging messages#193
stcheng merged 1 commit intosonic-net:masterfrom
stcheng:fib_log

Conversation

@stcheng
Copy link
Contributor

@stcheng stcheng commented Jun 6, 2017

No description provided.

@stcheng
Copy link
Contributor Author

stcheng commented Jun 6, 2017

ECMP/LAG logging messages will be improved in a separate pull request.

@stcheng stcheng requested a review from maggiemsft June 6, 2017 00:37
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make it clear, this is the ecmp group

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make it clear, this is the lag member.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

total_entry_hit_cnt is an integer, so it is better to use (total_entry_hit_cnt == 0). "not" is used for bool.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Contributor

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@stcheng stcheng merged commit 86e1a9f into sonic-net:master Jun 6, 2017
@stcheng stcheng deleted the fib_log branch June 6, 2017 23:56
lguohan pushed a commit that referenced this pull request Aug 3, 2017
nhe-NV pushed a commit to nhe-NV/sonic-mgmt that referenced this pull request May 12, 2025
…v6 advertisement interface (sonic-net#193)

<!--
Please make sure you've read and understood our contributing guidelines;
https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md

Please provide following information to help code review process a bit easier:
-->
### Description of PR
<!--
- Please include a summary of the change and which issue is fixed.
- Please also include relevant motivation and context. Where should reviewer start? background context?
- List any dependencies that are required for this change.
-->

Summary:
Fixes # (issue)

### Type of change

<!--
- Fill x for your type of change.
- e.g.
- [x] Bug fix
-->

- [ ] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [ ] New Test case
 - [ ] Skipped for non-supported platforms
- [x] Test case improvement

### Back port request
- [ ] 202012
- [ ] 202205
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [ ] 202411

### Approach
#### What is the motivation for this PR?
In some testbeds, `eth1` isn't always present. This PR is to enhance the test case to support the testbed without `eth1`.
#### How did you do it?
Replace the `ptf_port_index` as IPv6 advertisement interface which will be always present in the testbed.

#### How did you verify/test it?

```
radv/test_radv_ipv6_ra.py::test_radv_router_advertisement PASSED [ 25%]
radv/test_radv_ipv6_ra.py::test_solicited_router_advertisement PASSED [ 50%]
radv/test_radv_ipv6_ra.py::test_unsolicited_router_advertisement_with_m_flag PASSED [ 75%]
radv/test_radv_ipv6_ra.py::test_solicited_router_advertisement_with_m_flag PASSED [ 100%]
```

#### Any platform specific information?

#### Supported testbed topology if it's a new test case?

### Documentation
<!--
(If it's a new feature, new test case)
Did you update documentation/Wiki relevant to your implementation?
Link to the wiki page?
-->
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
* 3885f19 2021-02-02 | let sysDescr_pass use python3 (sonic-net#195) (HEAD, origin/master, origin/HEAD) [lguohan]
* ad302d4 2021-01-28 | Fix: 'key not found' exception in bgp4.py (sonic-net#192) [bingwang-ms]
* 59e2a1c 2021-01-27 | Fix fdb_vlanmac() on corner cases (sonic-net#193) [Qi Luo]

Signed-off-by: Guohan Lu <[email protected]>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
b0dad8c Add to check pcie configuration revision to get the right configuration. (sonic-net#195)
f66ffc3 [eeprom_tlv_info] Optimize EEPROM data process by using visitor pattern (sonic-net#193)
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
3ab5a04 [xcvrd] Force cleanup of chassis global variable on deinit (sonic-net#193)
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
sonic-net#15324)

src/linkmgrd

* c0f7c50 - (HEAD -> 202205, origin/202205) Increase verbosity for mux config and default route handlers (sonic-net#193) (14 minutes ago) [Longxiang Lyu]
* 2040a5e - Ignore mux probe unknown for health calculation (sonic-net#188) (14 minutes ago) [Longxiang Lyu]
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
d81828c6740f2d4fca59fe3ec1d0adb1088a9dbb (HEAD -> 201911, origin/201911) Updated lldpRemManAddrTable to use all the management ip address associated with interface. (sonic-net#201)
093a3c2c5bc688ddc5e5362dc657f19175e12ce8 Fix fdb_vlanmac() on corner cases (sonic-net#193)

Signed-off-by: Abhishek Dosi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants