[sanity] Fix sanity check bgp not ready after restart

[lolyu]

Description of PR

Summary:
Fixes # (issue)

Type of change

• Bug fix
• Testbed and Framework(new/improvement)
• New Test case
  • Skipped for non-supported platforms
• Test case improvement

Back port request

• 202205
• 202305
• 202311
• 202405
• 202411
• 202505

Approach

What is the motivation for this PR?

Fix the following error:

tests.common.errors.RunAnsibleModuleFail: run module bgp_facts failed, Ansible Results =>
failed = True
msg = Command failed rc=1, out=, err=Exiting: failed to connect to any daemons.

invocation = {'module_args': {'num_npus': 1, 'instance_id': None}}
_ansible_no_log = None
changed = False
stdout =
stderr =

, error:run module bgp_facts failed, Ansible Results =>
failed = True
msg = Command failed rc=1, out=, err=Exiting: failed to connect to any daemons.

invocation = {'module_args': {'num_npus': 1, 'instance_id': None}}
_ansible_no_log = None
changed = False
stdout =
stderr =

This issue is due to that, if the first _check_bgp_status_helper fails, the recover tries to restart bgp on the DUT; but bgpd takes time to startup, so the vtysh is not responsive.

sonic-mgmt/tests/common/plugins/sanity_check/checks.py

Lines 282 to 286 in 1b3006f

	wait_until(timeout, interval, 0, _check_bgp_status_helper)
	if (check_result['failed']):
	# try restart bgp and verify again
	_restart_bgp(dut)
	wait_until(60, interval, 0, _check_bgp_status_helper)

Signed-off-by: Longxiang Lyu [email protected]

How did you do it?

catch any exception raised by the bgp_facts and return False in this case.

How did you verify/test it?

Run testcase with no default route, verify no complain that vtysh is not responsive:

bgp/test_bgp_fact.py::test_bgp_facts[str2-7050cx3-acs-06-None] PASSED                                                                                                                                                                                                  [ 50%]
bgp/test_bgp_fact.py::test_bgp_facts[str2-7050cx3-acs-07-None] PASSED                                                                                                                                                                                                  [100%]

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

[mssonicbld]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[mssonicbld]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[bingwang-ms]

LGTM

[mssonicbld]

Cherry-pick PR to 202505: #19390