Skip to content

Update announce_routes script for LT2 topology#19260

Merged
bingwang-ms merged 1 commit intosonic-net:masterfrom
bingwang-ms:update_announce_routes_lt2
Jun 30, 2025
Merged

Update announce_routes script for LT2 topology#19260
bingwang-ms merged 1 commit intosonic-net:masterfrom
bingwang-ms:update_announce_routes_lt2

Conversation

@bingwang-ms
Copy link
Collaborator

Description of PR

Summary:
This PR is to update announce_routes.py for LT2 topology.

Change list

  • Announce ``192.128.0.0/9(including 192.168.0.0/24) and20c0:a800::0:0/108` to be compatible with some test (e.g. ACL test).
  • Fix ip_network arguments
  • Forcedly convert number into integer.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Approach

What is the motivation for this PR?

This PR is to update announce_routes.py for LT2 topology.

How did you do it?

  • Announce ``192.128.0.0/9(including 192.168.0.0/24) and20c0:a800::0:0/108` to be compatible with some test (e.g. ACL test).
  • Fix ip_network arguments
  • Forcedly convert number into integer.

How did you verify/test it?

The change is verified by running announce_routes on a physical testbed.

Any platform specific information?

No.

Supported testbed topology if it's a new test case?

Not a new test.

Documentation

@bingwang-ms bingwang-ms requested a review from auspham June 30, 2025 06:39
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bingwang-ms bingwang-ms mentioned this pull request Jun 30, 2025
11 tasks
@bingwang-ms bingwang-ms merged commit 7d656e6 into sonic-net:master Jun 30, 2025
17 of 19 checks passed
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to msft-202503: Azure/sonic-mgmt.msft#471

mssonicbld added a commit to mssonicbld/sonic-mgmt.msft that referenced this pull request Jun 30, 2025
<!--
Please make sure you've read and understood our contributing guidelines;
https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md

Please provide following information to help code review process a bit easier:
-->
### Description of PR
<!--
- Please include a summary of the change and which issue is fixed.
- Please also include relevant motivation and context. Where should reviewer start? background context?
- List any dependencies that are required for this change.
-->

Summary:
This PR is to enhance ACL test on LT2 topology.
The change is done by updating port selection logic to include both upstream ports and downstream ports on LT2.
Depends on sonic-net/sonic-mgmt#19260

### Type of change

<!--
- Fill x for your type of change.
- e.g.
- [x] Bug fix
-->

- [ ] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [ ] New Test case
    - [ ] Skipped for non-supported platforms
- [x] Test case improvement

### Back port request
- [ ] 202205
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [ ] 202411
- [ ] 202505

### Approach
#### What is the motivation for this PR?
This PR is to enhance ACL test on LT2 topology.

#### How did you do it?
The change is done by updating port selection logic to include both upstream ports and downstream ports on LT2.

#### How did you verify/test it?
The change is verified by running `test_acl` on a physical testbed.

#### Any platform specific information?
No.

#### Supported testbed topology if it's a new test case?
Not a new test.

### Documentation
<!--
(If it's a new feature, new test case)
Did you update documentation/Wiki relevant to your implementation?
Link to the wiki page?
-->
bingwang-ms added a commit to Azure/sonic-mgmt.msft that referenced this pull request Jun 30, 2025
<!--
Please make sure you've read and understood our contributing guidelines;
https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md

Please provide following information to help code review process a bit
easier:
-->
### Description of PR
<!--
- Please include a summary of the change and which issue is fixed.
- Please also include relevant motivation and context. Where should
reviewer start? background context?
- List any dependencies that are required for this change.
-->

Summary:
This PR is to enhance ACL test on LT2 topology.
The change is done by updating port selection logic to include both
upstream ports and downstream ports on LT2.
Depends on sonic-net/sonic-mgmt#19260

### Type of change

<!--
- Fill x for your type of change.
- e.g.
- [x] Bug fix
-->

- [ ] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [ ] New Test case
    - [ ] Skipped for non-supported platforms
- [x] Test case improvement

### Back port request
- [ ] 202205
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [ ] 202411
- [ ] 202505

### Approach
#### What is the motivation for this PR?
This PR is to enhance ACL test on LT2 topology.

#### How did you do it?
The change is done by updating port selection logic to include both
upstream ports and downstream ports on LT2.

#### How did you verify/test it?
The change is verified by running `test_acl` on a physical testbed.

#### Any platform specific information?
No.

#### Supported testbed topology if it's a new test case?
Not a new test.

### Documentation
<!--
(If it's a new feature, new test case)
Did you update documentation/Wiki relevant to your implementation?
Link to the wiki page?
-->
@mssonicbld
Copy link
Collaborator

@bingwang-ms PR conflicts with 202505 branch

nissampa pushed a commit to nissampa/sonic-mgmt_dpu_test that referenced this pull request Aug 7, 2025
ashutosh-agrawal pushed a commit to ashutosh-agrawal/sonic-mgmt that referenced this pull request Aug 14, 2025
vidyac86 pushed a commit to vidyac86/sonic-mgmt that referenced this pull request Oct 23, 2025
opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 16, 2025
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Dec 16, 2025
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Jan 13, 2026
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026
ytzur1 pushed a commit to ytzur1/sonic-mgmt that referenced this pull request Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants