Skip to content

Support t1-48-lag topo for acl tests#19235

Merged
bingwang-ms merged 1 commit intosonic-net:masterfrom
prabhataravind:paravind/acl
Jun 30, 2025
Merged

Support t1-48-lag topo for acl tests#19235
bingwang-ms merged 1 commit intosonic-net:masterfrom
prabhataravind:paravind/acl

Conversation

@prabhataravind
Copy link
Contributor

Description of PR

In t1-48-lag topo, the downstream links are physical ports, the upstream links are portchannels.
This change is needed to add the links to the acl_table_ports and prevent test failure.

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Approach

What is the motivation for this PR?

Fix test_acl failures with t1-48-lag topo

How did you do it?

By adding support for this topo in the test

How did you verify/test it?

By running the test case manually.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@prabhataravind prabhataravind marked this pull request as ready for review June 27, 2025 21:41
@prabhataravind
Copy link
Contributor Author

hi @prsunny @bingwang-ms, could you please help approve? I added a request label for 202505 as well.
For 202411, I created a separate PR due to urgency #19236

@bingwang-ms bingwang-ms merged commit 01b78ac into sonic-net:master Jun 30, 2025
14 checks passed
@mssonicbld
Copy link
Collaborator

@prabhataravind PR conflicts with 202505 branch

prabhataravind added a commit to prabhataravind/sonic-mgmt that referenced this pull request Aug 3, 2025
Cherry-pick changes in PR sonic-net#19235 to 202505.

Signed-off-by: Prabhat Aravind <[email protected]>
yejianquan pushed a commit that referenced this pull request Aug 4, 2025
Cherry-pick changes in PR #19235 to 202505.

Signed-off-by: Prabhat Aravind <[email protected]>
nissampa pushed a commit to nissampa/sonic-mgmt_dpu_test that referenced this pull request Aug 7, 2025
ashutosh-agrawal pushed a commit to ashutosh-agrawal/sonic-mgmt that referenced this pull request Aug 14, 2025
vidyac86 pushed a commit to vidyac86/sonic-mgmt that referenced this pull request Oct 23, 2025
opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 16, 2025
Signed-off-by: Prabhat Aravind <[email protected]>
Signed-off-by: Guy Shemesh <[email protected]>
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Dec 16, 2025
Signed-off-by: Prabhat Aravind <[email protected]>
Signed-off-by: Aharon Malkin <[email protected]>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
Signed-off-by: Prabhat Aravind <[email protected]>
Signed-off-by: Guy Shemesh <[email protected]>
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Jan 13, 2026
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026
Signed-off-by: Prabhat Aravind <[email protected]>
Signed-off-by: Guy Shemesh <[email protected]>
ytzur1 pushed a commit to ytzur1/sonic-mgmt that referenced this pull request Feb 2, 2026
Signed-off-by: Prabhat Aravind <[email protected]>
Signed-off-by: Yael Tzur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants